style: unify identifier naming per updated conventions

Automated with clang-tidy readability-identifier-naming (config added to
.clang-tidy) plus scripted passes, per the updated rules now documented
in CONTRIBUTING.md:

- types (class/struct/enum/alias/template params): PascalCase
- functions, variables, members: snake_case (incl. rational -> Rational)
- private/protected members: trailing underscore; static member
  variables likewise (instance_, available_themes_)
- constants and enum values: snake_case (kLinear -> k_linear,
  F32P -> f32p); ALL_CAPS reserved for macros
- macros: OAK_ prefix (OLIVE_ADD_TEST/OLIVE_ASSERT/OLIVE_CONFIG ->
  OAK_ADD_TEST/OAK_ASSERT/OAK_CONFIG, GL_PREAMBLE -> OAK_GL_PREAMBLE,
  include guards -> OAK_*)
- file names: all lowercase (Current/Plugin/OliveHost/OliveClip/
  OlivePluginInstance -> current/plugin/olivehost/oliveclip/
  oliveplugininstance)
- getters share the member name sans underscore, setters set_foo()
- Qt and third-party (OpenFX) virtual overrides and framework callbacks
  keep their original names (exempt in .clang-tidy)

Manual follow-ups required where automation could not reach:
- string-based QMetaObject/SIGNAL/SLOT references updated to renamed
  methods (AddTask, CreatedFile, DeleteSpecificFile, moveSelectionUp, ...)
- macro bodies referencing renamed methods (OLIVE_CONFIG,
  NODE_DEFAULT_DESTRUCTOR, MANAGEDDISPLAYWIDGET_*)
- self-shadowing locals renamed where signals/methods became same-named
  (size_changed, worker_count, selected_items, import param, filters)
- third_party OFX member/namespace usages restored (OFX::Host::*,
  _created, _clipPrefsDirty, createInstance, clearPersistentMessage)
- STL protocol aliases restored (const_iterator) with .clang-tidy
  ignore rules; qHash overloads restored

Full build and test suite pass: ctest 4/4, ~1960 gtest cases green.
This commit is contained in:
2026-07-19 16:10:54 +08:00
parent cb1718a103
commit bb40b4923e
1014 changed files with 44257 additions and 44220 deletions
+18 -18
View File
@@ -29,40 +29,40 @@ namespace olive
IntegerSlider::IntegerSlider(QWidget *parent)
: super(parent)
{
SetValue(0);
set_value(0);
}
int64_t IntegerSlider::GetValue()
int64_t IntegerSlider::get_value()
{
return GetValueInternal().toLongLong();
return get_value_internal().toLongLong();
}
void IntegerSlider::SetValue(const int64_t &v)
void IntegerSlider::set_value(const int64_t &v)
{
SetValueInternal(QVariant::fromValue(v));
set_value_internal(QVariant::fromValue(v));
}
void IntegerSlider::SetMinimum(const int64_t &d)
void IntegerSlider::set_minimum(const int64_t &d)
{
SetMinimumInternal(QVariant::fromValue(d));
set_minimum_internal(QVariant::fromValue(d));
}
void IntegerSlider::SetMaximum(const int64_t &d)
void IntegerSlider::set_maximum(const int64_t &d)
{
SetMaximumInternal(QVariant::fromValue(d));
set_maximum_internal(QVariant::fromValue(d));
}
void IntegerSlider::SetDefaultValue(const int64_t &d)
{
super::SetDefaultValue(QVariant::fromValue(d));
super::set_default_value(QVariant::fromValue(d));
}
QString IntegerSlider::ValueToString(const QVariant &v) const
QString IntegerSlider::value_to_string(const QVariant &v) const
{
return QString::number(v.toLongLong() + GetOffset().toLongLong());
return QString::number(v.toLongLong() + get_offset().toLongLong());
}
QVariant IntegerSlider::StringToValue(const QString &s, bool *ok) const
QVariant IntegerSlider::string_to_value(const QString &s, bool *ok) const
{
bool valid;
@@ -73,7 +73,7 @@ QVariant IntegerSlider::StringToValue(const QString &s, bool *ok) const
*ok = valid;
}
decimal_val -= GetOffset().toLongLong();
decimal_val -= get_offset().toLongLong();
if (valid) {
// But for an integer, we round it
@@ -83,15 +83,15 @@ QVariant IntegerSlider::StringToValue(const QString &s, bool *ok) const
return QVariant();
}
void IntegerSlider::ValueSignalEvent(const QVariant &value)
void IntegerSlider::value_signal_event(const QVariant &value)
{
emit ValueChanged(value.toInt());
emit value_changed(value.toInt());
}
QVariant IntegerSlider::AdjustDragDistanceInternal(const QVariant &start,
QVariant IntegerSlider::adjust_drag_distance_internal(const QVariant &start,
const double &drag) const
{
return qRound64(super::AdjustDragDistanceInternal(start, drag).toDouble());
return qRound64(super::adjust_drag_distance_internal(start, drag).toDouble());
}
}