style: unify identifier naming per updated conventions

Automated with clang-tidy readability-identifier-naming (config added to
.clang-tidy) plus scripted passes, per the updated rules now documented
in CONTRIBUTING.md:

- types (class/struct/enum/alias/template params): PascalCase
- functions, variables, members: snake_case (incl. rational -> Rational)
- private/protected members: trailing underscore; static member
  variables likewise (instance_, available_themes_)
- constants and enum values: snake_case (kLinear -> k_linear,
  F32P -> f32p); ALL_CAPS reserved for macros
- macros: OAK_ prefix (OLIVE_ADD_TEST/OLIVE_ASSERT/OLIVE_CONFIG ->
  OAK_ADD_TEST/OAK_ASSERT/OAK_CONFIG, GL_PREAMBLE -> OAK_GL_PREAMBLE,
  include guards -> OAK_*)
- file names: all lowercase (Current/Plugin/OliveHost/OliveClip/
  OlivePluginInstance -> current/plugin/olivehost/oliveclip/
  oliveplugininstance)
- getters share the member name sans underscore, setters set_foo()
- Qt and third-party (OpenFX) virtual overrides and framework callbacks
  keep their original names (exempt in .clang-tidy)

Manual follow-ups required where automation could not reach:
- string-based QMetaObject/SIGNAL/SLOT references updated to renamed
  methods (AddTask, CreatedFile, DeleteSpecificFile, moveSelectionUp, ...)
- macro bodies referencing renamed methods (OLIVE_CONFIG,
  NODE_DEFAULT_DESTRUCTOR, MANAGEDDISPLAYWIDGET_*)
- self-shadowing locals renamed where signals/methods became same-named
  (size_changed, worker_count, selected_items, import param, filters)
- third_party OFX member/namespace usages restored (OFX::Host::*,
  _created, _clipPrefsDirty, createInstance, clearPersistentMessage)
- STL protocol aliases restored (const_iterator) with .clang-tidy
  ignore rules; qHash overloads restored

Full build and test suite pass: ctest 4/4, ~1960 gtest cases green.
This commit is contained in:
2026-07-19 16:10:54 +08:00
parent cb1718a103
commit bb40b4923e
1014 changed files with 44257 additions and 44220 deletions
+21 -21
View File
@@ -19,8 +19,8 @@
***/
#ifndef VIEWMODEL_H
#define VIEWMODEL_H
#ifndef OAK_VIEWMODEL_H
#define OAK_VIEWMODEL_H
#include <QAbstractItemModel>
@@ -44,25 +44,25 @@ class ProjectViewModel : public QAbstractItemModel {
public:
enum ColumnType {
/// Media name
kName,
k_name,
/// Media duration
kDuration,
k_duration,
/// Media rate (frame rate for video, sample rate for audio)
kRate,
k_rate,
/// Last modified time (for footage/files)
kLastModified,
k_last_modified,
/// Creation time (for footage/files)
kCreatedTime,
k_created_time,
/// Count
kColumnCount
k_column_count
};
static const int kInnerTextRole = Qt::UserRole + 1;
static const int k_inner_text_role = Qt::UserRole + 1;
/**
* @brief ProjectViewModel Constructor
@@ -124,7 +124,7 @@ public:
/**
* @brief Convenience function for creating QModelIndexes from an Item object
*/
QModelIndex CreateIndexFromItem(Node *item, int column = 0);
QModelIndex create_index_from_item(Node *item, int column = 0);
private:
/**
@@ -137,40 +137,40 @@ private:
*
* Index of the specified item, or -1 if the item is root (in which case it has no parent).
*/
int IndexOfChild(Node *item) const;
int index_of_child(Node *item) const;
/**
* @brief Retrieves the Item object from a given index
*
* A convenience function for retrieving Item objects. If the index is not valid, this returns the root Item.
*/
Node *GetItemObjectFromIndex(const QModelIndex &index) const;
Node *get_item_object_from_index(const QModelIndex &index) const;
/**
* @brief Check if an Item is a parent of a Child
*
* Checks entire "parent hierarchy" of `child` to see if `parent` is one of its parents.
*/
bool ItemIsParentOfChild(Folder *parent, Node *child) const;
bool item_is_parent_of_child(Folder *parent, Node *child) const;
void ConnectItem(Node *n);
void connect_item(Node *n);
void DisconnectItem(Node *n);
void disconnect_item(Node *n);
Project *project_;
private slots:
void FolderBeginInsertItem(Node *n, int insert_index);
void folder_begin_insert_item(Node *n, int insert_index);
void FolderEndInsertItem();
void folder_end_insert_item();
void FolderBeginRemoveItem(Node *n, int child_index);
void folder_begin_remove_item(Node *n, int child_index);
void FolderEndRemoveItem();
void folder_end_remove_item();
void ItemRenamed();
void item_renamed();
};
}
#endif // VIEWMODEL_H
#endif // OAK_VIEWMODEL_H