style: unify identifier naming per updated conventions
Automated with clang-tidy readability-identifier-naming (config added to .clang-tidy) plus scripted passes, per the updated rules now documented in CONTRIBUTING.md: - types (class/struct/enum/alias/template params): PascalCase - functions, variables, members: snake_case (incl. rational -> Rational) - private/protected members: trailing underscore; static member variables likewise (instance_, available_themes_) - constants and enum values: snake_case (kLinear -> k_linear, F32P -> f32p); ALL_CAPS reserved for macros - macros: OAK_ prefix (OLIVE_ADD_TEST/OLIVE_ASSERT/OLIVE_CONFIG -> OAK_ADD_TEST/OAK_ASSERT/OAK_CONFIG, GL_PREAMBLE -> OAK_GL_PREAMBLE, include guards -> OAK_*) - file names: all lowercase (Current/Plugin/OliveHost/OliveClip/ OlivePluginInstance -> current/plugin/olivehost/oliveclip/ oliveplugininstance) - getters share the member name sans underscore, setters set_foo() - Qt and third-party (OpenFX) virtual overrides and framework callbacks keep their original names (exempt in .clang-tidy) Manual follow-ups required where automation could not reach: - string-based QMetaObject/SIGNAL/SLOT references updated to renamed methods (AddTask, CreatedFile, DeleteSpecificFile, moveSelectionUp, ...) - macro bodies referencing renamed methods (OLIVE_CONFIG, NODE_DEFAULT_DESTRUCTOR, MANAGEDDISPLAYWIDGET_*) - self-shadowing locals renamed where signals/methods became same-named (size_changed, worker_count, selected_items, import param, filters) - third_party OFX member/namespace usages restored (OFX::Host::*, _created, _clipPrefsDirty, createInstance, clearPersistentMessage) - STL protocol aliases restored (const_iterator) with .clang-tidy ignore rules; qHash overloads restored Full build and test suite pass: ctest 4/4, ~1960 gtest cases green.
This commit is contained in:
@@ -37,31 +37,31 @@ NodeValueTree::NodeValueTree(QWidget *parent)
|
||||
p.setHorizontalStretch(1);
|
||||
setSizePolicy(p);
|
||||
|
||||
static const int kMinimumRows = 10;
|
||||
setMinimumHeight(fontMetrics().height() * kMinimumRows);
|
||||
static const int k_minimum_rows = 10;
|
||||
setMinimumHeight(fontMetrics().height() * k_minimum_rows);
|
||||
|
||||
Retranslate();
|
||||
retranslate();
|
||||
}
|
||||
|
||||
void NodeValueTree::SetNode(const NodeInput &input, const rational &time)
|
||||
void NodeValueTree::set_node(const NodeInput &input, const Rational &time)
|
||||
{
|
||||
clear();
|
||||
|
||||
NodeTraverser traverser;
|
||||
|
||||
Node *connected_node = input.GetConnectedOutput();
|
||||
Node *connected_node = input.get_connected_output();
|
||||
|
||||
NodeValueTable table =
|
||||
traverser.GenerateTable(connected_node, TimeRange(time, time));
|
||||
traverser.generate_table(connected_node, TimeRange(time, time));
|
||||
|
||||
int index = traverser.GenerateRowValueElementIndex(
|
||||
int index = traverser.generate_row_value_element_index(
|
||||
input.node(), input.input(), input.element(), &table);
|
||||
|
||||
for (int i = 0; i < table.Count(); i++) {
|
||||
for (int i = 0; i < table.count(); i++) {
|
||||
const NodeValue &value = table.at(i);
|
||||
QTreeWidgetItem *item = new QTreeWidgetItem(this);
|
||||
|
||||
Node::ValueHint hint({ value.type() }, table.Count() - 1 - i,
|
||||
Node::ValueHint hint({ value.type() }, table.count() - 1 - i,
|
||||
value.tag());
|
||||
|
||||
QRadioButton *radio = new QRadioButton(this);
|
||||
@@ -71,37 +71,37 @@ void NodeValueTree::SetNode(const NodeInput &input, const rational &time)
|
||||
radio->setChecked(true);
|
||||
}
|
||||
connect(radio, &QRadioButton::clicked, this,
|
||||
&NodeValueTree::RadioButtonChecked);
|
||||
&NodeValueTree::radio_button_checked);
|
||||
|
||||
setItemWidget(item, 0, radio);
|
||||
item->setText(1, NodeValue::GetPrettyDataTypeName(value.type()));
|
||||
item->setText(2, NodeValue::ValueToString(value, false));
|
||||
item->setText(3, value.source()->GetLabelAndName());
|
||||
item->setText(1, NodeValue::get_pretty_data_type_name(value.type()));
|
||||
item->setText(2, NodeValue::value_to_string(value, false));
|
||||
item->setText(3, value.source()->get_label_and_name());
|
||||
}
|
||||
}
|
||||
|
||||
void NodeValueTree::changeEvent(QEvent *event)
|
||||
{
|
||||
if (event->type() == QEvent::LanguageChange) {
|
||||
Retranslate();
|
||||
retranslate();
|
||||
}
|
||||
|
||||
super::changeEvent(event);
|
||||
}
|
||||
|
||||
void NodeValueTree::Retranslate()
|
||||
void NodeValueTree::retranslate()
|
||||
{
|
||||
setHeaderLabels({ QString(), tr("Type"), tr("Value"), tr("Source") });
|
||||
}
|
||||
|
||||
void NodeValueTree::RadioButtonChecked(bool e)
|
||||
void NodeValueTree::radio_button_checked(bool e)
|
||||
{
|
||||
if (e) {
|
||||
QRadioButton *btn = static_cast<QRadioButton *>(sender());
|
||||
Node::ValueHint hint = btn->property("hint").value<Node::ValueHint>();
|
||||
NodeInput input = btn->property("input").value<NodeInput>();
|
||||
|
||||
input.node()->SetValueHintForInput(input.input(), hint,
|
||||
input.node()->set_value_hint_for_input(input.input(), hint,
|
||||
input.element());
|
||||
}
|
||||
}
|
||||
|
||||
@@ -16,8 +16,8 @@
|
||||
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
||||
*/
|
||||
|
||||
#ifndef NODEVALUETREE_H
|
||||
#define NODEVALUETREE_H
|
||||
#ifndef OAK_NODEVALUETREE_H
|
||||
#define OAK_NODEVALUETREE_H
|
||||
|
||||
#include <QRadioButton>
|
||||
#include <QTreeWidget>
|
||||
@@ -32,18 +32,18 @@ class NodeValueTree : public QTreeWidget {
|
||||
public:
|
||||
NodeValueTree(QWidget *parent = nullptr);
|
||||
|
||||
void SetNode(const NodeInput &input, const rational &time);
|
||||
void set_node(const NodeInput &input, const Rational &time);
|
||||
|
||||
protected:
|
||||
virtual void changeEvent(QEvent *event) override;
|
||||
|
||||
private:
|
||||
void Retranslate();
|
||||
void retranslate();
|
||||
|
||||
private slots:
|
||||
void RadioButtonChecked(bool e);
|
||||
void radio_button_checked(bool e);
|
||||
};
|
||||
|
||||
}
|
||||
|
||||
#endif // NODEVALUETREE_H
|
||||
#endif // OAK_NODEVALUETREE_H
|
||||
|
||||
Reference in New Issue
Block a user