style: unify identifier naming per updated conventions

Automated with clang-tidy readability-identifier-naming (config added to
.clang-tidy) plus scripted passes, per the updated rules now documented
in CONTRIBUTING.md:

- types (class/struct/enum/alias/template params): PascalCase
- functions, variables, members: snake_case (incl. rational -> Rational)
- private/protected members: trailing underscore; static member
  variables likewise (instance_, available_themes_)
- constants and enum values: snake_case (kLinear -> k_linear,
  F32P -> f32p); ALL_CAPS reserved for macros
- macros: OAK_ prefix (OLIVE_ADD_TEST/OLIVE_ASSERT/OLIVE_CONFIG ->
  OAK_ADD_TEST/OAK_ASSERT/OAK_CONFIG, GL_PREAMBLE -> OAK_GL_PREAMBLE,
  include guards -> OAK_*)
- file names: all lowercase (Current/Plugin/OliveHost/OliveClip/
  OlivePluginInstance -> current/plugin/olivehost/oliveclip/
  oliveplugininstance)
- getters share the member name sans underscore, setters set_foo()
- Qt and third-party (OpenFX) virtual overrides and framework callbacks
  keep their original names (exempt in .clang-tidy)

Manual follow-ups required where automation could not reach:
- string-based QMetaObject/SIGNAL/SLOT references updated to renamed
  methods (AddTask, CreatedFile, DeleteSpecificFile, moveSelectionUp, ...)
- macro bodies referencing renamed methods (OLIVE_CONFIG,
  NODE_DEFAULT_DESTRUCTOR, MANAGEDDISPLAYWIDGET_*)
- self-shadowing locals renamed where signals/methods became same-named
  (size_changed, worker_count, selected_items, import param, filters)
- third_party OFX member/namespace usages restored (OFX::Host::*,
  _created, _clipPrefsDirty, createInstance, clearPersistentMessage)
- STL protocol aliases restored (const_iterator) with .clang-tidy
  ignore rules; qHash overloads restored

Full build and test suite pass: ctest 4/4, ~1960 gtest cases green.
This commit is contained in:
2026-07-19 16:10:54 +08:00
parent cb1718a103
commit bb40b4923e
1014 changed files with 44257 additions and 44220 deletions
+36 -36
View File
@@ -19,8 +19,8 @@
***/
#ifndef MENUSHARED_H
#define MENUSHARED_H
#ifndef OAK_MENUSHARED_H
#define OAK_MENUSHARED_H
#include <olive/core/core.h>
#include "widget/colorlabelmenu/colorlabelmenu.h"
@@ -40,20 +40,20 @@ public:
MenuShared();
virtual ~MenuShared() override;
static void CreateInstance();
static void DestroyInstance();
static void create_instance();
static void destroy_instance();
void Retranslate();
void retranslate();
void AddItemsForNewMenu(Menu *m);
void AddItemsForEditMenu(Menu *m, bool for_clips);
void AddItemsForAddableObjectsMenu(Menu *m);
void AddItemsForInOutMenu(Menu *m);
void AddColorCodingMenu(Menu *m);
void AddItemsForClipEditMenu(Menu *m);
void AddItemsForTimeRulerMenu(Menu *m);
void add_items_for_new_menu(Menu *m);
void add_items_for_edit_menu(Menu *m, bool for_clips);
void add_items_for_addable_objects_menu(Menu *m);
void add_items_for_in_out_menu(Menu *m);
void add_color_coding_menu(Menu *m);
void add_items_for_clip_edit_menu(Menu *m);
void add_items_for_time_ruler_menu(Menu *m);
void AboutToShowTimeRulerActions(const rational &timebase);
void about_to_show_time_ruler_actions(const Rational &timebase);
static MenuShared *instance();
@@ -63,7 +63,7 @@ public:
}
public slots:
void DeleteSelectedTriggered();
void delete_selected_triggered();
private:
// "New" menu shared items
@@ -113,39 +113,39 @@ private:
static MenuShared *instance_;
private slots:
void SplitAtPlayheadTriggered();
void split_at_playhead_triggered();
void RippleDeleteTriggered();
void ripple_delete_triggered();
void SetInTriggered();
void set_in_triggered();
void SetOutTriggered();
void set_out_triggered();
void ResetInTriggered();
void reset_in_triggered();
void ResetOutTriggered();
void reset_out_triggered();
void ClearInOutTriggered();
void clear_in_out_triggered();
void ToggleLinksTriggered();
void toggle_links_triggered();
void CutTriggered();
void cut_triggered();
void CopyTriggered();
void copy_triggered();
void PasteTriggered();
void paste_triggered();
void PasteInsertTriggered();
void paste_insert_triggered();
void DuplicateTriggered();
void duplicate_triggered();
void RenameSelectedTriggered();
void rename_selected_triggered();
void EnableDisableTriggered();
void enable_disable_triggered();
void NestTriggered();
void nest_triggered();
void DefaultTransitionTriggered();
void default_transition_triggered();
/**
* @brief A slot for the timecode display menu items
@@ -153,15 +153,15 @@ private slots:
* Assumes a QAction* sender() and its data() is a member of enum Timecode::Display. Uses the data() to signal a
* timecode change throughout the rest of the application.
*/
void TimecodeDisplayTriggered();
void timecode_display_triggered();
void ColorLabelTriggered(int color_index);
void color_label_triggered(int color_index);
void SpeedDurationTriggered();
void speed_duration_triggered();
void AddableItemTriggered();
void addable_item_triggered();
};
}
#endif // MENUSHARED_H
#endif // OAK_MENUSHARED_H