style: unify identifier naming per updated conventions

Automated with clang-tidy readability-identifier-naming (config added to
.clang-tidy) plus scripted passes, per the updated rules now documented
in CONTRIBUTING.md:

- types (class/struct/enum/alias/template params): PascalCase
- functions, variables, members: snake_case (incl. rational -> Rational)
- private/protected members: trailing underscore; static member
  variables likewise (instance_, available_themes_)
- constants and enum values: snake_case (kLinear -> k_linear,
  F32P -> f32p); ALL_CAPS reserved for macros
- macros: OAK_ prefix (OLIVE_ADD_TEST/OLIVE_ASSERT/OLIVE_CONFIG ->
  OAK_ADD_TEST/OAK_ASSERT/OAK_CONFIG, GL_PREAMBLE -> OAK_GL_PREAMBLE,
  include guards -> OAK_*)
- file names: all lowercase (Current/Plugin/OliveHost/OliveClip/
  OlivePluginInstance -> current/plugin/olivehost/oliveclip/
  oliveplugininstance)
- getters share the member name sans underscore, setters set_foo()
- Qt and third-party (OpenFX) virtual overrides and framework callbacks
  keep their original names (exempt in .clang-tidy)

Manual follow-ups required where automation could not reach:
- string-based QMetaObject/SIGNAL/SLOT references updated to renamed
  methods (AddTask, CreatedFile, DeleteSpecificFile, moveSelectionUp, ...)
- macro bodies referencing renamed methods (OLIVE_CONFIG,
  NODE_DEFAULT_DESTRUCTOR, MANAGEDDISPLAYWIDGET_*)
- self-shadowing locals renamed where signals/methods became same-named
  (size_changed, worker_count, selected_items, import param, filters)
- third_party OFX member/namespace usages restored (OFX::Host::*,
  _created, _clipPrefsDirty, createInstance, clearPersistentMessage)
- STL protocol aliases restored (const_iterator) with .clang-tidy
  ignore rules; qHash overloads restored

Full build and test suite pass: ctest 4/4, ~1960 gtest cases green.
This commit is contained in:
2026-07-19 16:10:54 +08:00
parent cb1718a103
commit bb40b4923e
1014 changed files with 44257 additions and 44220 deletions
@@ -19,8 +19,8 @@
***/
#ifndef KEYFRAMEVIEWINPUTCONNECTION_H
#define KEYFRAMEVIEWINPUTCONNECTION_H
#ifndef OAK_KEYFRAMEVIEWINPUTCONNECTION_H
#define OAK_KEYFRAMEVIEWINPUTCONNECTION_H
#include <QObject>
@@ -38,41 +38,41 @@ public:
KeyframeViewInputConnection(const NodeKeyframeTrackReference &input,
KeyframeView *parent);
const int &GetKeyframeY() const
const int &get_keyframe_y() const
{
return y_;
}
void SetKeyframeY(int y);
void set_keyframe_y(int y);
enum YBehavior { kSingleRow, kValueIsHeight };
enum YBehavior { k_single_row, k_value_is_height };
void SetYBehavior(YBehavior e);
void set_y_behavior(YBehavior e);
const QVector<NodeKeyframe *> &GetKeyframes() const
const QVector<NodeKeyframe *> &get_keyframes() const
{
return input_.input()
.node()
->GetKeyframeTracks(input_.input())
->get_keyframe_tracks(input_.input())
.at(input_.track());
}
const QBrush &GetBrush() const
const QBrush &get_brush() const
{
return brush_;
}
const NodeKeyframeTrackReference &GetReference() const
const NodeKeyframeTrackReference &get_reference() const
{
return input_;
}
void SetBrush(const QBrush &brush);
void set_brush(const QBrush &brush);
signals:
void RequireUpdate();
void require_update();
void TypeChanged();
void type_changed();
private:
KeyframeView *keyframe_view_;
@@ -86,15 +86,15 @@ private:
QBrush brush_;
private slots:
void AddKeyframe(NodeKeyframe *key);
void add_keyframe(NodeKeyframe *key);
void RemoveKeyframe(NodeKeyframe *key);
void remove_keyframe(NodeKeyframe *key);
void KeyframeChanged(NodeKeyframe *key);
void keyframe_changed(NodeKeyframe *key);
void KeyframeTypeChanged(NodeKeyframe *key);
void keyframe_type_changed(NodeKeyframe *key);
};
}
#endif // KEYFRAMEVIEWINPUTCONNECTION_H
#endif // OAK_KEYFRAMEVIEWINPUTCONNECTION_H