oak-team/oak-editor
3
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

style: unify identifier naming per updated conventions

Browse Source 
Automated with clang-tidy readability-identifier-naming (config added to
.clang-tidy) plus scripted passes, per the updated rules now documented
in CONTRIBUTING.md:

- types (class/struct/enum/alias/template params): PascalCase
- functions, variables, members: snake_case (incl. rational -> Rational)
- private/protected members: trailing underscore; static member
  variables likewise (instance_, available_themes_)
- constants and enum values: snake_case (kLinear -> k_linear,
  F32P -> f32p); ALL_CAPS reserved for macros
- macros: OAK_ prefix (OLIVE_ADD_TEST/OLIVE_ASSERT/OLIVE_CONFIG ->
  OAK_ADD_TEST/OAK_ASSERT/OAK_CONFIG, GL_PREAMBLE -> OAK_GL_PREAMBLE,
  include guards -> OAK_*)
- file names: all lowercase (Current/Plugin/OliveHost/OliveClip/
  OlivePluginInstance -> current/plugin/olivehost/oliveclip/
  oliveplugininstance)
- getters share the member name sans underscore, setters set_foo()
- Qt and third-party (OpenFX) virtual overrides and framework callbacks
  keep their original names (exempt in .clang-tidy)

Manual follow-ups required where automation could not reach:
- string-based QMetaObject/SIGNAL/SLOT references updated to renamed
  methods (AddTask, CreatedFile, DeleteSpecificFile, moveSelectionUp, ...)
- macro bodies referencing renamed methods (OLIVE_CONFIG,
  NODE_DEFAULT_DESTRUCTOR, MANAGEDDISPLAYWIDGET_*)
- self-shadowing locals renamed where signals/methods became same-named
  (size_changed, worker_count, selected_items, import param, filters)
- third_party OFX member/namespace usages restored (OFX::Host::*,
  _created, _clipPrefsDirty, createInstance, clearPersistentMessage)
- STL protocol aliases restored (const_iterator) with .clang-tidy
  ignore rules; qHash overloads restored

Full build and test suite pass: ctest 4/4, ~1960 gtest cases green.
This commit is contained in:
Mike-Solar
2026-07-19 16:10:54 +08:00
parent cb1718a103
commit bb40b4923e
1014 changed files with 44257 additions and 44220 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/widget/bezier/bezierwidget.cpp
+26 -26
View File
@@ -37,13 +37,13 @@ BezierWidget::BezierWidget(QWidget *parent)
layout->addWidget(new QLabel(tr("Center:")), row, 0);
x_slider_ = new FloatSlider();
connect(x_slider_, &FloatSlider::ValueChanged, this,
&BezierWidget::ValueChanged);
connect(x_slider_, &FloatSlider::value_changed, this,
&BezierWidget::value_changed);
layout->addWidget(x_slider_, row, 1);
y_slider_ = new FloatSlider();
connect(y_slider_, &FloatSlider::ValueChanged, this,
&BezierWidget::ValueChanged);
connect(y_slider_, &FloatSlider::value_changed, this,
&BezierWidget::value_changed);
layout->addWidget(y_slider_, row, 2);
row++;
@@ -58,13 +58,13 @@ BezierWidget::BezierWidget(QWidget *parent)
bezier_layout->addWidget(new QLabel(tr("In:")), row, 0);
cp1_x_slider_ = new FloatSlider();
connect(cp1_x_slider_, &FloatSlider::ValueChanged, this,
&BezierWidget::ValueChanged);
connect(cp1_x_slider_, &FloatSlider::value_changed, this,
&BezierWidget::value_changed);
bezier_layout->addWidget(cp1_x_slider_, row, 1);
cp1_y_slider_ = new FloatSlider();
connect(cp1_y_slider_, &FloatSlider::ValueChanged, this,
&BezierWidget::ValueChanged);
connect(cp1_y_slider_, &FloatSlider::value_changed, this,
&BezierWidget::value_changed);
bezier_layout->addWidget(cp1_y_slider_, row, 2);
row++;
@@ -72,38 +72,38 @@ BezierWidget::BezierWidget(QWidget *parent)
bezier_layout->addWidget(new QLabel(tr("Out:")), row, 0);
cp2_x_slider_ = new FloatSlider();
connect(cp2_x_slider_, &FloatSlider::ValueChanged, this,
&BezierWidget::ValueChanged);
connect(cp2_x_slider_, &FloatSlider::value_changed, this,
&BezierWidget::value_changed);
bezier_layout->addWidget(cp2_x_slider_, row, 1);
cp2_y_slider_ = new FloatSlider();
connect(cp2_y_slider_, &FloatSlider::ValueChanged, this,
&BezierWidget::ValueChanged);
connect(cp2_y_slider_, &FloatSlider::value_changed, this,
&BezierWidget::value_changed);
bezier_layout->addWidget(cp2_y_slider_, row, 2);
}
Bezier BezierWidget::GetValue() const
Bezier BezierWidget::get_value() const
{
Bezier b;
b.set_x(x_slider_->GetValue());
b.set_y(y_slider_->GetValue());
b.set_cp1_x(cp1_x_slider_->GetValue());
b.set_cp1_y(cp1_y_slider_->GetValue());
b.set_cp2_x(cp2_x_slider_->GetValue());
b.set_cp2_y(cp2_y_slider_->GetValue());
b.set_x(x_slider_->get_value());
b.set_y(y_slider_->get_value());
b.set_cp1_x(cp1_x_slider_->get_value());
b.set_cp1_y(cp1_y_slider_->get_value());
b.set_cp2_x(cp2_x_slider_->get_value());
b.set_cp2_y(cp2_y_slider_->get_value());
return b;
}
void BezierWidget::SetValue(const Bezier &b)
void BezierWidget::set_value(const Bezier &b)
{
x_slider_->SetValue(b.x());
y_slider_->SetValue(b.y());
cp1_x_slider_->SetValue(b.cp1_x());
cp1_y_slider_->SetValue(b.cp1_y());
cp2_x_slider_->SetValue(b.cp2_x());
cp2_y_slider_->SetValue(b.cp2_y());
x_slider_->set_value(b.x());
y_slider_->set_value(b.y());
cp1_x_slider_->set_value(b.cp1_x());
cp1_y_slider_->set_value(b.cp1_y());
cp2_x_slider_->set_value(b.cp2_x());
cp2_y_slider_->set_value(b.cp2_y());
}
}