oak-team/oak-editor
3
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

style: unify identifier naming per updated conventions

Browse Source 
Automated with clang-tidy readability-identifier-naming (config added to
.clang-tidy) plus scripted passes, per the updated rules now documented
in CONTRIBUTING.md:

- types (class/struct/enum/alias/template params): PascalCase
- functions, variables, members: snake_case (incl. rational -> Rational)
- private/protected members: trailing underscore; static member
  variables likewise (instance_, available_themes_)
- constants and enum values: snake_case (kLinear -> k_linear,
  F32P -> f32p); ALL_CAPS reserved for macros
- macros: OAK_ prefix (OLIVE_ADD_TEST/OLIVE_ASSERT/OLIVE_CONFIG ->
  OAK_ADD_TEST/OAK_ASSERT/OAK_CONFIG, GL_PREAMBLE -> OAK_GL_PREAMBLE,
  include guards -> OAK_*)
- file names: all lowercase (Current/Plugin/OliveHost/OliveClip/
  OlivePluginInstance -> current/plugin/olivehost/oliveclip/
  oliveplugininstance)
- getters share the member name sans underscore, setters set_foo()
- Qt and third-party (OpenFX) virtual overrides and framework callbacks
  keep their original names (exempt in .clang-tidy)

Manual follow-ups required where automation could not reach:
- string-based QMetaObject/SIGNAL/SLOT references updated to renamed
  methods (AddTask, CreatedFile, DeleteSpecificFile, moveSelectionUp, ...)
- macro bodies referencing renamed methods (OLIVE_CONFIG,
  NODE_DEFAULT_DESTRUCTOR, MANAGEDDISPLAYWIDGET_*)
- self-shadowing locals renamed where signals/methods became same-named
  (size_changed, worker_count, selected_items, import param, filters)
- third_party OFX member/namespace usages restored (OFX::Host::*,
  _created, _clipPrefsDirty, createInstance, clearPersistentMessage)
- STL protocol aliases restored (const_iterator) with .clang-tidy
  ignore rules; qHash overloads restored

Full build and test suite pass: ctest 4/4, ~1960 gtest cases green.
This commit is contained in:
Mike-Solar
2026-07-19 16:10:54 +08:00
parent cb1718a103
commit bb40b4923e
1014 changed files with 44257 additions and 44220 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/ui/style/style.h
+11 -11
View File
@@ -19,8 +19,8 @@
***/
#ifndef STYLEMANAGER_H
#define STYLEMANAGER_H
#ifndef OAK_STYLEMANAGER_H
#define OAK_STYLEMANAGER_H
#include <QSettings>
#include <QWidget>
@@ -32,13 +32,13 @@ namespace olive
class StyleManager : public QObject {
public:
static void Init();
static void init();
static const QString &GetStyle();
static const QString &get_style();
static void SetStyle(const QString &style_path);
static void set_style(const QString &style_path);
inline static const char *kDefaultStyle = "olive-dark";
inline static const char *k_default_style = "olive-dark";
static const QMap<QString, QString> &available_themes()
{
@@ -46,20 +46,20 @@ public:
}
private:
static QPalette ParsePalette(const QString &ini_path);
static QPalette parse_palette(const QString &ini_path);
static void ParsePaletteGroup(QSettings *ini, QPalette *palette,
static void parse_palette_group(QSettings *ini, QPalette *palette,
QPalette::ColorGroup group);
static void ParsePaletteColor(QSettings *ini, QPalette *palette,
static void parse_palette_color(QSettings *ini, QPalette *palette,
QPalette::ColorGroup group,
const QString &role_name);
static QString current_style_;
static QString current_style;
static QMap<QString, QString> available_themes_;
};
}
#endif // STYLEMANAGER_H
#endif // OAK_STYLEMANAGER_H