style: unify identifier naming per updated conventions
Automated with clang-tidy readability-identifier-naming (config added to .clang-tidy) plus scripted passes, per the updated rules now documented in CONTRIBUTING.md: - types (class/struct/enum/alias/template params): PascalCase - functions, variables, members: snake_case (incl. rational -> Rational) - private/protected members: trailing underscore; static member variables likewise (instance_, available_themes_) - constants and enum values: snake_case (kLinear -> k_linear, F32P -> f32p); ALL_CAPS reserved for macros - macros: OAK_ prefix (OLIVE_ADD_TEST/OLIVE_ASSERT/OLIVE_CONFIG -> OAK_ADD_TEST/OAK_ASSERT/OAK_CONFIG, GL_PREAMBLE -> OAK_GL_PREAMBLE, include guards -> OAK_*) - file names: all lowercase (Current/Plugin/OliveHost/OliveClip/ OlivePluginInstance -> current/plugin/olivehost/oliveclip/ oliveplugininstance) - getters share the member name sans underscore, setters set_foo() - Qt and third-party (OpenFX) virtual overrides and framework callbacks keep their original names (exempt in .clang-tidy) Manual follow-ups required where automation could not reach: - string-based QMetaObject/SIGNAL/SLOT references updated to renamed methods (AddTask, CreatedFile, DeleteSpecificFile, moveSelectionUp, ...) - macro bodies referencing renamed methods (OLIVE_CONFIG, NODE_DEFAULT_DESTRUCTOR, MANAGEDDISPLAYWIDGET_*) - self-shadowing locals renamed where signals/methods became same-named (size_changed, worker_count, selected_items, import param, filters) - third_party OFX member/namespace usages restored (OFX::Host::*, _created, _clipPrefsDirty, createInstance, clearPersistentMessage) - STL protocol aliases restored (const_iterator) with .clang-tidy ignore rules; qHash overloads restored Full build and test suite pass: ctest 4/4, ~1960 gtest cases green.
This commit is contained in:
@@ -16,8 +16,8 @@
|
||||
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
||||
*/
|
||||
|
||||
#ifndef HUMANSTRINGS_H
|
||||
#define HUMANSTRINGS_H
|
||||
#ifndef OAK_HUMANSTRINGS_H
|
||||
#define OAK_HUMANSTRINGS_H
|
||||
|
||||
#include <olive/core/core.h>
|
||||
#include <QObject>
|
||||
@@ -32,13 +32,13 @@ class HumanStrings : public QObject {
|
||||
public:
|
||||
HumanStrings() = default;
|
||||
|
||||
static QString SampleRateToString(const int &sample_rate);
|
||||
static QString sample_rate_to_string(const int &sample_rate);
|
||||
|
||||
static QString ChannelLayoutToString(const uint64_t &layout);
|
||||
static QString channel_layout_to_string(const uint64_t &layout);
|
||||
|
||||
static QString FormatToString(const SampleFormat &f);
|
||||
static QString format_to_string(const SampleFormat &f);
|
||||
};
|
||||
|
||||
}
|
||||
|
||||
#endif // HUMANSTRINGS_H
|
||||
#endif // OAK_HUMANSTRINGS_H
|
||||
|
||||
Reference in New Issue
Block a user