style: unify identifier naming per updated conventions

Automated with clang-tidy readability-identifier-naming (config added to
.clang-tidy) plus scripted passes, per the updated rules now documented
in CONTRIBUTING.md:

- types (class/struct/enum/alias/template params): PascalCase
- functions, variables, members: snake_case (incl. rational -> Rational)
- private/protected members: trailing underscore; static member
  variables likewise (instance_, available_themes_)
- constants and enum values: snake_case (kLinear -> k_linear,
  F32P -> f32p); ALL_CAPS reserved for macros
- macros: OAK_ prefix (OLIVE_ADD_TEST/OLIVE_ASSERT/OLIVE_CONFIG ->
  OAK_ADD_TEST/OAK_ASSERT/OAK_CONFIG, GL_PREAMBLE -> OAK_GL_PREAMBLE,
  include guards -> OAK_*)
- file names: all lowercase (Current/Plugin/OliveHost/OliveClip/
  OlivePluginInstance -> current/plugin/olivehost/oliveclip/
  oliveplugininstance)
- getters share the member name sans underscore, setters set_foo()
- Qt and third-party (OpenFX) virtual overrides and framework callbacks
  keep their original names (exempt in .clang-tidy)

Manual follow-ups required where automation could not reach:
- string-based QMetaObject/SIGNAL/SLOT references updated to renamed
  methods (AddTask, CreatedFile, DeleteSpecificFile, moveSelectionUp, ...)
- macro bodies referencing renamed methods (OLIVE_CONFIG,
  NODE_DEFAULT_DESTRUCTOR, MANAGEDDISPLAYWIDGET_*)
- self-shadowing locals renamed where signals/methods became same-named
  (size_changed, worker_count, selected_items, import param, filters)
- third_party OFX member/namespace usages restored (OFX::Host::*,
  _created, _clipPrefsDirty, createInstance, clearPersistentMessage)
- STL protocol aliases restored (const_iterator) with .clang-tidy
  ignore rules; qHash overloads restored

Full build and test suite pass: ctest 4/4, ~1960 gtest cases green.
This commit is contained in:
2026-07-19 16:10:54 +08:00
parent cb1718a103
commit bb40b4923e
1014 changed files with 44257 additions and 44220 deletions
+22 -22
View File
@@ -23,23 +23,23 @@
namespace olive
{
QString HumanStrings::SampleRateToString(const int &sample_rate)
QString HumanStrings::sample_rate_to_string(const int &sample_rate)
{
return QCoreApplication::translate("AudioParams", "%1 Hz").arg(sample_rate);
}
QString HumanStrings::ChannelLayoutToString(const uint64_t &layout)
QString HumanStrings::channel_layout_to_string(const uint64_t &layout)
{
switch (layout) {
case kChannelLayoutMono:
case k_channel_layout_mono:
return QCoreApplication::translate("AudioParams", "Mono");
case kChannelLayoutStereo:
case k_channel_layout_stereo:
return QCoreApplication::translate("AudioParams", "Stereo");
case kChannelLayout2_1:
case k_channel_layout2_1:
return QCoreApplication::translate("AudioParams", "2.1");
case kChannelLayout5Point1:
case k_channel_layout5_point1:
return QCoreApplication::translate("AudioParams", "5.1");
case kChannelLayout7Point1:
case k_channel_layout7_point1:
return QCoreApplication::translate("AudioParams", "7.1");
default:
return QCoreApplication::translate("AudioParams", "Unknown (0x%1)")
@@ -47,48 +47,48 @@ QString HumanStrings::ChannelLayoutToString(const uint64_t &layout)
}
}
QString HumanStrings::FormatToString(const SampleFormat &f)
QString HumanStrings::format_to_string(const SampleFormat &f)
{
switch (f) {
case SampleFormat::U8:
case SampleFormat::u8:
return QCoreApplication::translate("AudioParams",
"Unsigned 8-bit (Packed)");
case SampleFormat::S16:
case SampleFormat::s16:
return QCoreApplication::translate("AudioParams",
"Signed 16-bit (Packed)");
case SampleFormat::S32:
case SampleFormat::s32:
return QCoreApplication::translate("AudioParams",
"Signed 32-bit (Packed)");
case SampleFormat::S64:
case SampleFormat::s64:
return QCoreApplication::translate("AudioParams",
"Signed 64-bit (Packed)");
case SampleFormat::F32:
case SampleFormat::f32:
return QCoreApplication::translate("AudioParams",
"Float 32-bit (Packed)");
case SampleFormat::F64:
case SampleFormat::f64:
return QCoreApplication::translate("AudioParams",
"Float 64-bit (Packed)");
case SampleFormat::U8P:
case SampleFormat::u8_p:
return QCoreApplication::translate("AudioParams",
"Unsigned 8-bit (Planar)");
case SampleFormat::S16P:
case SampleFormat::s16_p:
return QCoreApplication::translate("AudioParams",
"Signed 16-bit (Planar)");
case SampleFormat::S32P:
case SampleFormat::s32_p:
return QCoreApplication::translate("AudioParams",
"Signed 32-bit (Planar)");
case SampleFormat::S64P:
case SampleFormat::s64_p:
return QCoreApplication::translate("AudioParams",
"Signed 64-bit (Planar)");
case SampleFormat::F32P:
case SampleFormat::f32_p:
return QCoreApplication::translate("AudioParams",
"Float 32-bit (Planar)");
case SampleFormat::F64P:
case SampleFormat::f64_p:
return QCoreApplication::translate("AudioParams",
"Float 64-bit (Planar)");
case SampleFormat::INVALID:
case SampleFormat::COUNT:
case SampleFormat::invalid:
case SampleFormat::count:
break;
}