style: unify identifier naming per updated conventions

Automated with clang-tidy readability-identifier-naming (config added to
.clang-tidy) plus scripted passes, per the updated rules now documented
in CONTRIBUTING.md:

- types (class/struct/enum/alias/template params): PascalCase
- functions, variables, members: snake_case (incl. rational -> Rational)
- private/protected members: trailing underscore; static member
  variables likewise (instance_, available_themes_)
- constants and enum values: snake_case (kLinear -> k_linear,
  F32P -> f32p); ALL_CAPS reserved for macros
- macros: OAK_ prefix (OLIVE_ADD_TEST/OLIVE_ASSERT/OLIVE_CONFIG ->
  OAK_ADD_TEST/OAK_ASSERT/OAK_CONFIG, GL_PREAMBLE -> OAK_GL_PREAMBLE,
  include guards -> OAK_*)
- file names: all lowercase (Current/Plugin/OliveHost/OliveClip/
  OlivePluginInstance -> current/plugin/olivehost/oliveclip/
  oliveplugininstance)
- getters share the member name sans underscore, setters set_foo()
- Qt and third-party (OpenFX) virtual overrides and framework callbacks
  keep their original names (exempt in .clang-tidy)

Manual follow-ups required where automation could not reach:
- string-based QMetaObject/SIGNAL/SLOT references updated to renamed
  methods (AddTask, CreatedFile, DeleteSpecificFile, moveSelectionUp, ...)
- macro bodies referencing renamed methods (OLIVE_CONFIG,
  NODE_DEFAULT_DESTRUCTOR, MANAGEDDISPLAYWIDGET_*)
- self-shadowing locals renamed where signals/methods became same-named
  (size_changed, worker_count, selected_items, import param, filters)
- third_party OFX member/namespace usages restored (OFX::Host::*,
  _created, _clipPrefsDirty, createInstance, clearPersistentMessage)
- STL protocol aliases restored (const_iterator) with .clang-tidy
  ignore rules; qHash overloads restored

Full build and test suite pass: ctest 4/4, ~1960 gtest cases green.
This commit is contained in:
2026-07-19 16:10:54 +08:00
parent cb1718a103
commit bb40b4923e
1014 changed files with 44257 additions and 44220 deletions
+16 -16
View File
@@ -19,8 +19,8 @@
***/
#ifndef TASKMANAGER_H
#define TASKMANAGER_H
#ifndef OAK_TASKMANAGER_H
#define OAK_TASKMANAGER_H
#include <QtConcurrent/QtConcurrent>
#include <QVector>
@@ -54,17 +54,17 @@ public:
*/
virtual ~TaskManager();
static void CreateInstance();
static void create_instance();
static void DestroyInstance();
static void destroy_instance();
static TaskManager *instance();
int GetTaskCount() const;
int get_task_count() const;
Task *GetFirstTask() const;
Task *get_first_task() const;
void CancelTaskAndWait(Task *t);
void cancel_task_and_wait(Task *t);
public slots:
/**
@@ -82,9 +82,9 @@ public slots:
*
* The task to add and run. TaskManager takes ownership of this Task and will be responsible for freeing it.
*/
void AddTask(Task *t);
void add_task(Task *t);
void CancelTask(Task *t);
void cancel_task(Task *t);
signals:
/**
@@ -94,22 +94,22 @@ signals:
*
* Task that was added
*/
void TaskAdded(Task *t);
void task_added(Task *t);
/**
* @brief Signal emitted when any change to the running task list has been made
*/
void TaskListChanged();
void task_list_changed();
/**
* @brief Signal emitted when a task is deleted
*/
void TaskRemoved(Task *t);
void task_removed(Task *t);
/**
* @brief Signal emitted when a task fails
*/
void TaskFailed(Task *t);
void task_failed(Task *t);
private:
/**
@@ -128,14 +128,14 @@ private:
QThreadPool thread_pool_;
/**
* @brief TaskManager singleton instance
* @brief TaskManager singleton instance_
*/
static TaskManager *instance_;
private slots:
void TaskFinished();
void task_finished();
};
}
#endif // TASKMANAGER_H
#endif // OAK_TASKMANAGER_H