style: unify identifier naming per updated conventions
Automated with clang-tidy readability-identifier-naming (config added to .clang-tidy) plus scripted passes, per the updated rules now documented in CONTRIBUTING.md: - types (class/struct/enum/alias/template params): PascalCase - functions, variables, members: snake_case (incl. rational -> Rational) - private/protected members: trailing underscore; static member variables likewise (instance_, available_themes_) - constants and enum values: snake_case (kLinear -> k_linear, F32P -> f32p); ALL_CAPS reserved for macros - macros: OAK_ prefix (OLIVE_ADD_TEST/OLIVE_ASSERT/OLIVE_CONFIG -> OAK_ADD_TEST/OAK_ASSERT/OAK_CONFIG, GL_PREAMBLE -> OAK_GL_PREAMBLE, include guards -> OAK_*) - file names: all lowercase (Current/Plugin/OliveHost/OliveClip/ OlivePluginInstance -> current/plugin/olivehost/oliveclip/ oliveplugininstance) - getters share the member name sans underscore, setters set_foo() - Qt and third-party (OpenFX) virtual overrides and framework callbacks keep their original names (exempt in .clang-tidy) Manual follow-ups required where automation could not reach: - string-based QMetaObject/SIGNAL/SLOT references updated to renamed methods (AddTask, CreatedFile, DeleteSpecificFile, moveSelectionUp, ...) - macro bodies referencing renamed methods (OLIVE_CONFIG, NODE_DEFAULT_DESTRUCTOR, MANAGEDDISPLAYWIDGET_*) - self-shadowing locals renamed where signals/methods became same-named (size_changed, worker_count, selected_items, import param, filters) - third_party OFX member/namespace usages restored (OFX::Host::*, _created, _clipPrefsDirty, createInstance, clearPersistentMessage) - STL protocol aliases restored (const_iterator) with .clang-tidy ignore rules; qHash overloads restored Full build and test suite pass: ctest 4/4, ~1960 gtest cases green.
This commit is contained in:
@@ -19,8 +19,8 @@
|
||||
|
||||
***/
|
||||
|
||||
#ifndef PROJECTIMPORTMANAGER_H
|
||||
#define PROJECTIMPORTMANAGER_H
|
||||
#ifndef OAK_PROJECTIMPORTMANAGER_H
|
||||
#define OAK_PROJECTIMPORTMANAGER_H
|
||||
|
||||
#include <QFileInfoList>
|
||||
#include <QUndoCommand>
|
||||
@@ -37,45 +37,45 @@ class ProjectImportTask : public Task {
|
||||
public:
|
||||
ProjectImportTask(Folder *folder, const QStringList &filenames);
|
||||
|
||||
const int &GetFileCount() const;
|
||||
const int &get_file_count() const;
|
||||
|
||||
MultiUndoCommand *GetCommand() const
|
||||
MultiUndoCommand *get_command() const
|
||||
{
|
||||
return command_;
|
||||
}
|
||||
|
||||
const QStringList &GetInvalidFiles() const
|
||||
const QStringList &get_invalid_files() const
|
||||
{
|
||||
return invalid_files_;
|
||||
}
|
||||
|
||||
bool HasInvalidFiles() const
|
||||
bool has_invalid_files() const
|
||||
{
|
||||
return !invalid_files_.isEmpty();
|
||||
}
|
||||
|
||||
const QVector<Footage *> &GetImportedFootage() const
|
||||
const QVector<Footage *> &get_imported_footage() const
|
||||
{
|
||||
return imported_footage_;
|
||||
}
|
||||
|
||||
protected:
|
||||
virtual bool Run() override;
|
||||
virtual bool run() override;
|
||||
|
||||
private:
|
||||
void Import(Folder *folder, QFileInfoList import, int &counter,
|
||||
void import(Folder *folder, QFileInfoList entries, int &counter,
|
||||
MultiUndoCommand *parent_command);
|
||||
|
||||
void ValidateImageSequence(Footage *footage, QFileInfoList &info_list,
|
||||
void validate_image_sequence(Footage *footage, QFileInfoList &info_list,
|
||||
int index);
|
||||
|
||||
void AddItemToFolder(Folder *folder, Node *item, MultiUndoCommand *command);
|
||||
void add_item_to_folder(Folder *folder, Node *item, MultiUndoCommand *command);
|
||||
|
||||
static bool ItemIsStillImageFootageOnly(Footage *footage);
|
||||
static bool item_is_still_image_footage_only(Footage *footage);
|
||||
|
||||
static bool CompareStillImageSize(Footage *footage, const QSize &sz);
|
||||
static bool compare_still_image_size(Footage *footage, const QSize &sz);
|
||||
|
||||
static int64_t GetImageSequenceLimit(const QString &start_fn, int64_t start,
|
||||
static int64_t get_image_sequence_limit(const QString &start_fn, int64_t start,
|
||||
bool up);
|
||||
|
||||
MultiUndoCommand *command_;
|
||||
@@ -95,4 +95,4 @@ private:
|
||||
|
||||
}
|
||||
|
||||
#endif // PROJECTIMPORTMANAGER_H
|
||||
#endif // OAK_PROJECTIMPORTMANAGER_H
|
||||
|
||||
Reference in New Issue
Block a user