oak-team/oak-editor
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

style: unify identifier naming per updated conventions

Browse Source 
Automated with clang-tidy readability-identifier-naming (config added to
.clang-tidy) plus scripted passes, per the updated rules now documented
in CONTRIBUTING.md:

- types (class/struct/enum/alias/template params): PascalCase
- functions, variables, members: snake_case (incl. rational -> Rational)
- private/protected members: trailing underscore; static member
  variables likewise (instance_, available_themes_)
- constants and enum values: snake_case (kLinear -> k_linear,
  F32P -> f32p); ALL_CAPS reserved for macros
- macros: OAK_ prefix (OLIVE_ADD_TEST/OLIVE_ASSERT/OLIVE_CONFIG ->
  OAK_ADD_TEST/OAK_ASSERT/OAK_CONFIG, GL_PREAMBLE -> OAK_GL_PREAMBLE,
  include guards -> OAK_*)
- file names: all lowercase (Current/Plugin/OliveHost/OliveClip/
  OlivePluginInstance -> current/plugin/olivehost/oliveclip/
  oliveplugininstance)
- getters share the member name sans underscore, setters set_foo()
- Qt and third-party (OpenFX) virtual overrides and framework callbacks
  keep their original names (exempt in .clang-tidy)

Manual follow-ups required where automation could not reach:
- string-based QMetaObject/SIGNAL/SLOT references updated to renamed
  methods (AddTask, CreatedFile, DeleteSpecificFile, moveSelectionUp, ...)
- macro bodies referencing renamed methods (OLIVE_CONFIG,
  NODE_DEFAULT_DESTRUCTOR, MANAGEDDISPLAYWIDGET_*)
- self-shadowing locals renamed where signals/methods became same-named
  (size_changed, worker_count, selected_items, import param, filters)
- third_party OFX member/namespace usages restored (OFX::Host::*,
  _created, _clipPrefsDirty, createInstance, clearPersistentMessage)
- STL protocol aliases restored (const_iterator) with .clang-tidy
  ignore rules; qHash overloads restored

Full build and test suite pass: ctest 4/4, ~1960 gtest cases green.
This commit is contained in:
Mike-Solar
2026-07-19 16:10:54 +08:00
parent cb1718a103
commit bb40b4923e
1014 changed files with 44257 additions and 44220 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/task/export/export.h
+11 -11
View File
@@ -19,8 +19,8 @@
***/
#ifndef EXPORTTASK_H
#define EXPORTTASK_H
#ifndef OAK_EXPORTTASK_H
#define OAK_EXPORTTASK_H
#include "codec/encoder.h"
#include "node/output/viewer/viewer.h"
@@ -39,26 +39,26 @@ public:
const EncodingParams &params);
protected:
virtual bool Run() override;
virtual bool run() override;
virtual bool FrameDownloaded(FramePtr frame, const rational &time) override;
virtual bool frame_downloaded(FramePtr frame, const Rational &time) override;
virtual bool AudioDownloaded(const TimeRange &range,
virtual bool audio_downloaded(const TimeRange &range,
const SampleBuffer &samples) override;
virtual bool EncodeSubtitle(const SubtitleBlock *sub) override;
virtual bool encode_subtitle(const SubtitleBlock *sub) override;
virtual bool TwoStepFrameRendering() const override
virtual bool two_step_frame_rendering() const override
{
return false;
}
private:
bool WriteAudioLoop(const TimeRange &time, const SampleBuffer &samples);
bool write_audio_loop(const TimeRange &time, const SampleBuffer &samples);
ProjectCopier *copier_;
QHash<rational, FramePtr> time_map_;
QHash<Rational, FramePtr> time_map_;
QHash<TimeRange, SampleBuffer> audio_map_;
@@ -74,11 +74,11 @@ private:
int64_t frame_time_;
rational audio_time_;
Rational audio_time_;
TimeRange export_range_;
};
}
#endif // EXPORTTASK_H
#endif // OAK_EXPORTTASK_H