style: unify identifier naming per updated conventions

Automated with clang-tidy readability-identifier-naming (config added to
.clang-tidy) plus scripted passes, per the updated rules now documented
in CONTRIBUTING.md:

- types (class/struct/enum/alias/template params): PascalCase
- functions, variables, members: snake_case (incl. rational -> Rational)
- private/protected members: trailing underscore; static member
  variables likewise (instance_, available_themes_)
- constants and enum values: snake_case (kLinear -> k_linear,
  F32P -> f32p); ALL_CAPS reserved for macros
- macros: OAK_ prefix (OLIVE_ADD_TEST/OLIVE_ASSERT/OLIVE_CONFIG ->
  OAK_ADD_TEST/OAK_ASSERT/OAK_CONFIG, GL_PREAMBLE -> OAK_GL_PREAMBLE,
  include guards -> OAK_*)
- file names: all lowercase (Current/Plugin/OliveHost/OliveClip/
  OlivePluginInstance -> current/plugin/olivehost/oliveclip/
  oliveplugininstance)
- getters share the member name sans underscore, setters set_foo()
- Qt and third-party (OpenFX) virtual overrides and framework callbacks
  keep their original names (exempt in .clang-tidy)

Manual follow-ups required where automation could not reach:
- string-based QMetaObject/SIGNAL/SLOT references updated to renamed
  methods (AddTask, CreatedFile, DeleteSpecificFile, moveSelectionUp, ...)
- macro bodies referencing renamed methods (OLIVE_CONFIG,
  NODE_DEFAULT_DESTRUCTOR, MANAGEDDISPLAYWIDGET_*)
- self-shadowing locals renamed where signals/methods became same-named
  (size_changed, worker_count, selected_items, import param, filters)
- third_party OFX member/namespace usages restored (OFX::Host::*,
  _created, _clipPrefsDirty, createInstance, clearPersistentMessage)
- STL protocol aliases restored (const_iterator) with .clang-tidy
  ignore rules; qHash overloads restored

Full build and test suite pass: ctest 4/4, ~1960 gtest cases green.
This commit is contained in:
2026-07-19 16:10:54 +08:00
parent cb1718a103
commit bb40b4923e
1014 changed files with 44257 additions and 44220 deletions
+14 -14
View File
@@ -17,10 +17,10 @@
*
*/
#ifndef PLUGINJOB_H
#define PLUGINJOB_H
#ifndef OAK_PLUGINJOB_H
#define OAK_PLUGINJOB_H
#include "acceleratedjob.h"
#include "pluginSupport/OlivePluginInstance.h"
#include "pluginSupport/oliveplugininstance.h"
#include "olive/core/util/rational.h"
#include <any>
@@ -33,19 +33,19 @@ namespace plugin
class PluginJob : public AcceleratedJob {
public:
explicit PluginJob(const OFX::Host::ImageEffect::Instance *pluginInstance,
explicit PluginJob(const OFX::Host::ImageEffect::Instance *plugin_instance,
const PluginNode *node, NodeValueRow row,
const olive::core::rational &time)
const olive::core::Rational &time)
: AcceleratedJob()
, time_seconds_(time.toDouble())
, time_seconds_(time.to_double())
{
this->pluginInstance_ = pluginInstance;
this->pluginInstance_ = plugin_instance;
this->node_ = node;
Insert(row);
insert(row);
}
explicit PluginJob(const OFX::Host::ImageEffect::Instance *pluginInstance,
explicit PluginJob(const OFX::Host::ImageEffect::Instance *plugin_instance,
const PluginNode *node, NodeValueRow row)
: PluginJob(pluginInstance, node, row, olive::core::rational(0))
: PluginJob(plugin_instance, node, row, olive::core::Rational(0))
{
}
@@ -54,7 +54,7 @@ public:
return const_cast<PluginNode *>(node_);
}
OFX::Host::ImageEffect::Instance *pluginInstance()
OFX::Host::ImageEffect::Instance *plugin_instance()
{
return const_cast<OFX::Host::ImageEffect::Instance *>(pluginInstance_);
}
@@ -67,9 +67,9 @@ public:
private:
const OFX::Host::ImageEffect::Instance *pluginInstance_ = nullptr;
QHash<OfxTime, QHash<QString, std::any>> paramsOnTime;
QHash<OfxTime, QHash<QString, std::any>> paramsOnTime_;
QHash<QString, std::any> params;
QHash<QString, std::any> params_;
const PluginNode *node_ = nullptr;
double time_seconds_ = 0.0;
@@ -78,4 +78,4 @@ private:
} // plugin
} // olive
#endif //PLUGINJOB_H
#endif //OAK_PLUGINJOB_H