style: unify identifier naming per updated conventions

Automated with clang-tidy readability-identifier-naming (config added to
.clang-tidy) plus scripted passes, per the updated rules now documented
in CONTRIBUTING.md:

- types (class/struct/enum/alias/template params): PascalCase
- functions, variables, members: snake_case (incl. rational -> Rational)
- private/protected members: trailing underscore; static member
  variables likewise (instance_, available_themes_)
- constants and enum values: snake_case (kLinear -> k_linear,
  F32P -> f32p); ALL_CAPS reserved for macros
- macros: OAK_ prefix (OLIVE_ADD_TEST/OLIVE_ASSERT/OLIVE_CONFIG ->
  OAK_ADD_TEST/OAK_ASSERT/OAK_CONFIG, GL_PREAMBLE -> OAK_GL_PREAMBLE,
  include guards -> OAK_*)
- file names: all lowercase (Current/Plugin/OliveHost/OliveClip/
  OlivePluginInstance -> current/plugin/olivehost/oliveclip/
  oliveplugininstance)
- getters share the member name sans underscore, setters set_foo()
- Qt and third-party (OpenFX) virtual overrides and framework callbacks
  keep their original names (exempt in .clang-tidy)

Manual follow-ups required where automation could not reach:
- string-based QMetaObject/SIGNAL/SLOT references updated to renamed
  methods (AddTask, CreatedFile, DeleteSpecificFile, moveSelectionUp, ...)
- macro bodies referencing renamed methods (OLIVE_CONFIG,
  NODE_DEFAULT_DESTRUCTOR, MANAGEDDISPLAYWIDGET_*)
- self-shadowing locals renamed where signals/methods became same-named
  (size_changed, worker_count, selected_items, import param, filters)
- third_party OFX member/namespace usages restored (OFX::Host::*,
  _created, _clipPrefsDirty, createInstance, clearPersistentMessage)
- STL protocol aliases restored (const_iterator) with .clang-tidy
  ignore rules; qHash overloads restored

Full build and test suite pass: ctest 4/4, ~1960 gtest cases green.
This commit is contained in:
2026-07-19 16:10:54 +08:00
parent cb1718a103
commit bb40b4923e
1014 changed files with 44257 additions and 44220 deletions
+13 -13
View File
@@ -52,31 +52,31 @@ PanelWidget::PanelWidget(const QString &object_name)
connect(this, &PanelWidget::shown, this,
reinterpret_cast<void (PanelWidget::*)()>(&PanelWidget::setFocus));
PanelManager::instance()->RegisterPanel(this);
PanelManager::instance()->register_panel(this);
}
PanelWidget::~PanelWidget()
{
PanelManager::instance()->UnregisterPanel(this);
PanelManager::instance()->unregister_panel(this);
}
void PanelWidget::SetBorderVisible(bool enabled)
void PanelWidget::set_border_visible(bool enabled)
{
border_visible_ = enabled;
update();
}
void PanelWidget::SetTitle(const QString &t)
void PanelWidget::set_title(const QString &t)
{
title_ = t;
UpdateTitle();
update_title();
}
void PanelWidget::SetSubtitle(const QString &t)
void PanelWidget::set_subtitle(const QString &t)
{
subtitle_ = t;
UpdateTitle();
update_title();
}
void PanelWidget::paintEvent(QPaintEvent *event)
@@ -101,7 +101,7 @@ void PanelWidget::paintEvent(QPaintEvent *event)
}
}
void PanelWidget::UpdateTitle()
void PanelWidget::update_title()
{
// If there's no subtitle, just use the title. Otherwise, we set a formatted combination of the two that can
// differ based on translation
@@ -112,7 +112,7 @@ void PanelWidget::UpdateTitle()
}
}
void PanelWidget::SetSignalInsteadOfClose(bool e)
void PanelWidget::set_signal_instead_of_close(bool e)
{
signal_instead_of_close_ = e;
}
@@ -121,7 +121,7 @@ void PanelWidget::closeEvent(QCloseEvent *event)
{
if (signal_instead_of_close_) {
event->ignore();
emit CloseRequested();
emit close_requested();
} else {
super::closeEvent(event);
}
@@ -130,7 +130,7 @@ void PanelWidget::closeEvent(QCloseEvent *event)
void PanelWidget::changeEvent(QEvent *e)
{
if (e->type() == QEvent::LanguageChange) {
Retranslate();
retranslate();
}
if (e->type() == QEvent::WindowStateChange) {
@@ -143,11 +143,11 @@ void PanelWidget::changeEvent(QEvent *e)
super::changeEvent(e);
}
void PanelWidget::Retranslate()
void PanelWidget::retranslate()
{
}
void PanelWidget::SetWidgetWithPadding(QWidget *widget)
void PanelWidget::set_widget_with_padding(QWidget *widget)
{
QWidget *wrapper = new QWidget();
QHBoxLayout *layout = new QHBoxLayout(wrapper);