style: unify identifier naming per updated conventions
Automated with clang-tidy readability-identifier-naming (config added to .clang-tidy) plus scripted passes, per the updated rules now documented in CONTRIBUTING.md: - types (class/struct/enum/alias/template params): PascalCase - functions, variables, members: snake_case (incl. rational -> Rational) - private/protected members: trailing underscore; static member variables likewise (instance_, available_themes_) - constants and enum values: snake_case (kLinear -> k_linear, F32P -> f32p); ALL_CAPS reserved for macros - macros: OAK_ prefix (OLIVE_ADD_TEST/OLIVE_ASSERT/OLIVE_CONFIG -> OAK_ADD_TEST/OAK_ASSERT/OAK_CONFIG, GL_PREAMBLE -> OAK_GL_PREAMBLE, include guards -> OAK_*) - file names: all lowercase (Current/Plugin/OliveHost/OliveClip/ OlivePluginInstance -> current/plugin/olivehost/oliveclip/ oliveplugininstance) - getters share the member name sans underscore, setters set_foo() - Qt and third-party (OpenFX) virtual overrides and framework callbacks keep their original names (exempt in .clang-tidy) Manual follow-ups required where automation could not reach: - string-based QMetaObject/SIGNAL/SLOT references updated to renamed methods (AddTask, CreatedFile, DeleteSpecificFile, moveSelectionUp, ...) - macro bodies referencing renamed methods (OLIVE_CONFIG, NODE_DEFAULT_DESTRUCTOR, MANAGEDDISPLAYWIDGET_*) - self-shadowing locals renamed where signals/methods became same-named (size_changed, worker_count, selected_items, import param, filters) - third_party OFX member/namespace usages restored (OFX::Host::*, _created, _clipPrefsDirty, createInstance, clearPersistentMessage) - STL protocol aliases restored (const_iterator) with .clang-tidy ignore rules; qHash overloads restored Full build and test suite pass: ctest 4/4, ~1960 gtest cases green.
This commit is contained in:
@@ -26,16 +26,16 @@ namespace olive
|
||||
MulticamPanel::MulticamPanel()
|
||||
: super(QStringLiteral("MultiCamPanel"))
|
||||
{
|
||||
SetTimeBasedWidget(new MulticamWidget(this));
|
||||
set_time_based_widget(new MulticamWidget(this));
|
||||
|
||||
Retranslate();
|
||||
retranslate();
|
||||
}
|
||||
|
||||
void MulticamPanel::Retranslate()
|
||||
void MulticamPanel::retranslate()
|
||||
{
|
||||
super::Retranslate();
|
||||
super::retranslate();
|
||||
|
||||
SetTitle(tr("Multi-Cam"));
|
||||
set_title(tr("Multi-Cam"));
|
||||
}
|
||||
|
||||
}
|
||||
|
||||
@@ -16,8 +16,8 @@
|
||||
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
||||
*/
|
||||
|
||||
#ifndef MULTICAMPANEL_H
|
||||
#define MULTICAMPANEL_H
|
||||
#ifndef OAK_MULTICAMPANEL_H
|
||||
#define OAK_MULTICAMPANEL_H
|
||||
|
||||
#include "panel/viewer/viewerbase.h"
|
||||
#include "widget/multicam/multicamwidget.h"
|
||||
@@ -30,15 +30,15 @@ class MulticamPanel : public TimeBasedPanel {
|
||||
public:
|
||||
MulticamPanel();
|
||||
|
||||
MulticamWidget *GetMulticamWidget() const
|
||||
MulticamWidget *get_multicam_widget() const
|
||||
{
|
||||
return static_cast<MulticamWidget *>(GetTimeBasedWidget());
|
||||
return static_cast<MulticamWidget *>(get_time_based_widget());
|
||||
}
|
||||
|
||||
protected:
|
||||
virtual void Retranslate() override;
|
||||
virtual void retranslate() override;
|
||||
};
|
||||
|
||||
}
|
||||
|
||||
#endif // MULTICAMPANEL_H
|
||||
#endif // OAK_MULTICAMPANEL_H
|
||||
|
||||
Reference in New Issue
Block a user