oak-team/oak-editor
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

style: unify identifier naming per updated conventions

Browse Source 
Automated with clang-tidy readability-identifier-naming (config added to
.clang-tidy) plus scripted passes, per the updated rules now documented
in CONTRIBUTING.md:

- types (class/struct/enum/alias/template params): PascalCase
- functions, variables, members: snake_case (incl. rational -> Rational)
- private/protected members: trailing underscore; static member
  variables likewise (instance_, available_themes_)
- constants and enum values: snake_case (kLinear -> k_linear,
  F32P -> f32p); ALL_CAPS reserved for macros
- macros: OAK_ prefix (OLIVE_ADD_TEST/OLIVE_ASSERT/OLIVE_CONFIG ->
  OAK_ADD_TEST/OAK_ASSERT/OAK_CONFIG, GL_PREAMBLE -> OAK_GL_PREAMBLE,
  include guards -> OAK_*)
- file names: all lowercase (Current/Plugin/OliveHost/OliveClip/
  OlivePluginInstance -> current/plugin/olivehost/oliveclip/
  oliveplugininstance)
- getters share the member name sans underscore, setters set_foo()
- Qt and third-party (OpenFX) virtual overrides and framework callbacks
  keep their original names (exempt in .clang-tidy)

Manual follow-ups required where automation could not reach:
- string-based QMetaObject/SIGNAL/SLOT references updated to renamed
  methods (AddTask, CreatedFile, DeleteSpecificFile, moveSelectionUp, ...)
- macro bodies referencing renamed methods (OLIVE_CONFIG,
  NODE_DEFAULT_DESTRUCTOR, MANAGEDDISPLAYWIDGET_*)
- self-shadowing locals renamed where signals/methods became same-named
  (size_changed, worker_count, selected_items, import param, filters)
- third_party OFX member/namespace usages restored (OFX::Host::*,
  _created, _clipPrefsDirty, createInstance, clearPersistentMessage)
- STL protocol aliases restored (const_iterator) with .clang-tidy
  ignore rules; qHash overloads restored

Full build and test suite pass: ctest 4/4, ~1960 gtest cases green.
This commit is contained in:
Mike-Solar
2026-07-19 16:10:54 +08:00
parent cb1718a103
commit bb40b4923e
1014 changed files with 44257 additions and 44220 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/node/time/timeformat/timeformat.cpp
+20 -20
View File
@@ -28,18 +28,18 @@ namespace olive
#define super Node
const QString TimeFormatNode::kTimeInput = QStringLiteral("time_in");
const QString TimeFormatNode::kFormatInput = QStringLiteral("format_in");
const QString TimeFormatNode::kLocalTimeInput = QStringLiteral("localtime_in");
const QString TimeFormatNode::k_time_input = QStringLiteral("time_in");
const QString TimeFormatNode::k_format_input = QStringLiteral("format_in");
const QString TimeFormatNode::k_local_time_input = QStringLiteral("localtime_in");
TimeFormatNode::TimeFormatNode()
{
AddInput(kTimeInput, NodeValue::kFloat);
AddInput(kFormatInput, NodeValue::kText, QStringLiteral("hh:mm:ss"));
AddInput(kLocalTimeInput, NodeValue::kBoolean);
add_input(k_time_input, NodeValue::k_float);
add_input(k_format_input, NodeValue::k_text, QStringLiteral("hh:mm:ss"));
add_input(k_local_time_input, NodeValue::k_boolean);
}
QString TimeFormatNode::Name() const
QString TimeFormatNode::name() const
{
return tr("Time Format");
}
@@ -49,36 +49,36 @@ QString TimeFormatNode::id() const
return QStringLiteral("org.olivevideoeditor.Olive.timeformat");
}
QVector<Node::CategoryID> TimeFormatNode::Category() const
QVector<Node::CategoryID> TimeFormatNode::category() const
{
return { kCategoryGenerator };
return { k_category_generator };
}
QString TimeFormatNode::Description() const
QString TimeFormatNode::description() const
{
return tr("Format time (in Unix epoch seconds) into a string.");
}
void TimeFormatNode::Retranslate()
void TimeFormatNode::retranslate()
{
super::Retranslate();
super::retranslate();
SetInputName(kTimeInput, tr("Time"));
SetInputName(kFormatInput, tr("Format"));
SetInputName(kLocalTimeInput, tr("Interpret time as local time"));
set_input_name(k_time_input, tr("Time"));
set_input_name(k_format_input, tr("Format"));
set_input_name(k_local_time_input, tr("Interpret time as local time"));
}
void TimeFormatNode::Value(const NodeValueRow &value,
void TimeFormatNode::value(const NodeValueRow &value,
const NodeGlobals &globals,
NodeValueTable *table) const
{
qint64 ms_since_epoch = value[kTimeInput].toDouble() * 1000;
bool time_is_local = value[kLocalTimeInput].toBool();
qint64 ms_since_epoch = value[k_time_input].to_double() * 1000;
bool time_is_local = value[k_local_time_input].to_bool();
QDateTime dt = QDateTime::fromMSecsSinceEpoch(
ms_since_epoch, time_is_local ? Qt::LocalTime : Qt::UTC);
QString format = value[kFormatInput].toString();
QString format = value[k_format_input].to_string();
QString output = dt.toString(format);
table->Push(NodeValue(NodeValue::kText, output, this));
table->push(NodeValue(NodeValue::k_text, output, this));
}
}