style: unify identifier naming per updated conventions

Automated with clang-tidy readability-identifier-naming (config added to
.clang-tidy) plus scripted passes, per the updated rules now documented
in CONTRIBUTING.md:

- types (class/struct/enum/alias/template params): PascalCase
- functions, variables, members: snake_case (incl. rational -> Rational)
- private/protected members: trailing underscore; static member
  variables likewise (instance_, available_themes_)
- constants and enum values: snake_case (kLinear -> k_linear,
  F32P -> f32p); ALL_CAPS reserved for macros
- macros: OAK_ prefix (OLIVE_ADD_TEST/OLIVE_ASSERT/OLIVE_CONFIG ->
  OAK_ADD_TEST/OAK_ASSERT/OAK_CONFIG, GL_PREAMBLE -> OAK_GL_PREAMBLE,
  include guards -> OAK_*)
- file names: all lowercase (Current/Plugin/OliveHost/OliveClip/
  OlivePluginInstance -> current/plugin/olivehost/oliveclip/
  oliveplugininstance)
- getters share the member name sans underscore, setters set_foo()
- Qt and third-party (OpenFX) virtual overrides and framework callbacks
  keep their original names (exempt in .clang-tidy)

Manual follow-ups required where automation could not reach:
- string-based QMetaObject/SIGNAL/SLOT references updated to renamed
  methods (AddTask, CreatedFile, DeleteSpecificFile, moveSelectionUp, ...)
- macro bodies referencing renamed methods (OLIVE_CONFIG,
  NODE_DEFAULT_DESTRUCTOR, MANAGEDDISPLAYWIDGET_*)
- self-shadowing locals renamed where signals/methods became same-named
  (size_changed, worker_count, selected_items, import param, filters)
- third_party OFX member/namespace usages restored (OFX::Host::*,
  _created, _clipPrefsDirty, createInstance, clearPersistentMessage)
- STL protocol aliases restored (const_iterator) with .clang-tidy
  ignore rules; qHash overloads restored

Full build and test suite pass: ctest 4/4, ~1960 gtest cases green.
This commit is contained in:
2026-07-19 16:10:54 +08:00
parent cb1718a103
commit bb40b4923e
1014 changed files with 44257 additions and 44220 deletions
+19 -19
View File
@@ -19,8 +19,8 @@
***/
#ifndef SEQUENCE_H
#define SEQUENCE_H
#ifndef OAK_SEQUENCE_H
#define OAK_SEQUENCE_H
#include "node/output/track/tracklist.h"
#include "node/output/viewer/viewer.h"
@@ -38,7 +38,7 @@ public:
NODE_DEFAULT_FUNCTIONS(Sequence)
virtual QString Name() const override
virtual QString name() const override
{
return tr("Sequence");
}
@@ -48,12 +48,12 @@ public:
return QStringLiteral("org.olivevideoeditor.Olive.sequence");
}
virtual QVector<CategoryID> Category() const override
virtual QVector<CategoryID> category() const override
{
return { kCategoryProject };
return { k_category_project };
}
virtual QString Description() const override
virtual QString description() const override
{
return tr(
"A series of cuts that result in an edited video. Also called a timeline.");
@@ -63,36 +63,36 @@ public:
virtual QVariant data(const DataType &d) const override;
const QVector<Track *> &GetTracks() const
const QVector<Track *> &get_tracks() const
{
return track_cache_;
}
Track *GetTrackFromReference(const Track::Reference &track_ref) const
Track *get_track_from_reference(const Track::Reference &track_ref) const
{
if (track_ref.type() < 0 || track_ref.type() >= track_lists_.size()) {
return nullptr;
}
return track_lists_.at(track_ref.type())->GetTrackAt(track_ref.index());
return track_lists_.at(track_ref.type())->get_track_at(track_ref.index());
}
/**
* @brief Same as GetTracks() but omits tracks that are locked.
*/
QVector<Track *> GetUnlockedTracks() const;
QVector<Track *> get_unlocked_tracks() const;
TrackList *track_list(Track::Type type) const
{
return track_lists_.at(type);
}
virtual void Retranslate() override;
virtual void retranslate() override;
virtual void InvalidateCache(const TimeRange &range, const QString &from,
virtual void invalidate_cache(const TimeRange &range, const QString &from,
int element,
InvalidateCacheOptions options) override;
static const QString kTrackInputFormat;
static const QString k_track_input_format;
protected:
virtual void InputConnectedEvent(const QString &input, int element,
@@ -101,13 +101,13 @@ protected:
virtual void InputDisconnectedEvent(const QString &input, int element,
Node *output) override;
virtual rational VerifyLengthInternal(Track::Type type) const override;
virtual Rational verify_length_internal(Track::Type type) const override;
signals:
void TrackAdded(Track *track);
void TrackRemoved(Track *track);
void track_added(Track *track);
void track_removed(Track *track);
void SubtitlesChanged(const TimeRange &range);
void subtitles_changed(const TimeRange &range);
private:
QVector<TrackList *> track_lists_;
@@ -115,9 +115,9 @@ private:
QVector<Track *> track_cache_;
private slots:
void UpdateTrackCache();
void update_track_cache();
};
}
#endif // SEQUENCE_H
#endif // OAK_SEQUENCE_H