style: unify identifier naming per updated conventions

Automated with clang-tidy readability-identifier-naming (config added to
.clang-tidy) plus scripted passes, per the updated rules now documented
in CONTRIBUTING.md:

- types (class/struct/enum/alias/template params): PascalCase
- functions, variables, members: snake_case (incl. rational -> Rational)
- private/protected members: trailing underscore; static member
  variables likewise (instance_, available_themes_)
- constants and enum values: snake_case (kLinear -> k_linear,
  F32P -> f32p); ALL_CAPS reserved for macros
- macros: OAK_ prefix (OLIVE_ADD_TEST/OLIVE_ASSERT/OLIVE_CONFIG ->
  OAK_ADD_TEST/OAK_ASSERT/OAK_CONFIG, GL_PREAMBLE -> OAK_GL_PREAMBLE,
  include guards -> OAK_*)
- file names: all lowercase (Current/Plugin/OliveHost/OliveClip/
  OlivePluginInstance -> current/plugin/olivehost/oliveclip/
  oliveplugininstance)
- getters share the member name sans underscore, setters set_foo()
- Qt and third-party (OpenFX) virtual overrides and framework callbacks
  keep their original names (exempt in .clang-tidy)

Manual follow-ups required where automation could not reach:
- string-based QMetaObject/SIGNAL/SLOT references updated to renamed
  methods (AddTask, CreatedFile, DeleteSpecificFile, moveSelectionUp, ...)
- macro bodies referencing renamed methods (OLIVE_CONFIG,
  NODE_DEFAULT_DESTRUCTOR, MANAGEDDISPLAYWIDGET_*)
- self-shadowing locals renamed where signals/methods became same-named
  (size_changed, worker_count, selected_items, import param, filters)
- third_party OFX member/namespace usages restored (OFX::Host::*,
  _created, _clipPrefsDirty, createInstance, clearPersistentMessage)
- STL protocol aliases restored (const_iterator) with .clang-tidy
  ignore rules; qHash overloads restored

Full build and test suite pass: ctest 4/4, ~1960 gtest cases green.
This commit is contained in:
2026-07-19 16:10:54 +08:00
parent cb1718a103
commit bb40b4923e
1014 changed files with 44257 additions and 44220 deletions
+10 -10
View File
@@ -19,8 +19,8 @@
***/
#ifndef NODEINPUTIMMEDIATE_H
#define NODEINPUTIMMEDIATE_H
#ifndef OAK_NODEINPUTIMMEDIATE_H
#define OAK_NODEINPUTIMMEDIATE_H
#include "common/xmlutils.h"
#include "node/keyframe.h"
@@ -67,7 +67,7 @@ public:
*
* List may be empty if this input is not keyframing or has no keyframes at this time.
*/
QVector<NodeKeyframe *> get_keyframe_at_time(const rational &time) const;
QVector<NodeKeyframe *> get_keyframe_at_time(const Rational &time) const;
/**
* @brief Retrieve the keyframe object at a given time for a given track
@@ -76,7 +76,7 @@ public:
*
* The keyframe object at this time or nullptr if there isn't one or if is_keyframing() is false.
*/
NodeKeyframe *get_keyframe_at_time_on_track(const rational &time,
NodeKeyframe *get_keyframe_at_time_on_track(const Rational &time,
int track) const;
/**
@@ -84,7 +84,7 @@ public:
*
* If is_keyframing() is false or keyframes_ is empty, this will return nullptr.
*/
NodeKeyframe *get_closest_keyframe_to_time_on_track(const rational &time,
NodeKeyframe *get_closest_keyframe_to_time_on_track(const Rational &time,
int track) const;
/**
@@ -92,19 +92,19 @@ public:
*
* If no keyframe is before this time, returns nullptr.
*/
NodeKeyframe *get_closest_keyframe_before_time(const rational &time) const;
NodeKeyframe *get_closest_keyframe_before_time(const Rational &time) const;
/**
* @brief Get closest keyframe that's before the time on any track
*
* If no keyframe is before this time, returns nullptr.
*/
NodeKeyframe *get_closest_keyframe_after_time(const rational &time) const;
NodeKeyframe *get_closest_keyframe_after_time(const Rational &time) const;
/**
* @brief A heuristic to determine what type a keyframe should be if it's inserted at a certain time (between keyframes)
*/
NodeKeyframe::Type get_best_keyframe_type_for_time(const rational &time,
NodeKeyframe::Type get_best_keyframe_type_for_time(const Rational &time,
int track) const;
/**
@@ -147,7 +147,7 @@ public:
* If is_keyframing() is false, this will always return false. This checks all tracks and will return true if *any*
* track has a keyframe.
*/
bool has_keyframe_at_time(const rational &time) const;
bool has_keyframe_at_time(const Rational &time) const;
bool is_using_standard_value(int track) const
{
@@ -182,4 +182,4 @@ private:
}
#endif // NODEINPUTIMMEDIATE_H
#endif // OAK_NODEINPUTIMMEDIATE_H