oak-team/oak-editor
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

style: unify identifier naming per updated conventions

Browse Source 
Automated with clang-tidy readability-identifier-naming (config added to
.clang-tidy) plus scripted passes, per the updated rules now documented
in CONTRIBUTING.md:

- types (class/struct/enum/alias/template params): PascalCase
- functions, variables, members: snake_case (incl. rational -> Rational)
- private/protected members: trailing underscore; static member
  variables likewise (instance_, available_themes_)
- constants and enum values: snake_case (kLinear -> k_linear,
  F32P -> f32p); ALL_CAPS reserved for macros
- macros: OAK_ prefix (OLIVE_ADD_TEST/OLIVE_ASSERT/OLIVE_CONFIG ->
  OAK_ADD_TEST/OAK_ASSERT/OAK_CONFIG, GL_PREAMBLE -> OAK_GL_PREAMBLE,
  include guards -> OAK_*)
- file names: all lowercase (Current/Plugin/OliveHost/OliveClip/
  OlivePluginInstance -> current/plugin/olivehost/oliveclip/
  oliveplugininstance)
- getters share the member name sans underscore, setters set_foo()
- Qt and third-party (OpenFX) virtual overrides and framework callbacks
  keep their original names (exempt in .clang-tidy)

Manual follow-ups required where automation could not reach:
- string-based QMetaObject/SIGNAL/SLOT references updated to renamed
  methods (AddTask, CreatedFile, DeleteSpecificFile, moveSelectionUp, ...)
- macro bodies referencing renamed methods (OLIVE_CONFIG,
  NODE_DEFAULT_DESTRUCTOR, MANAGEDDISPLAYWIDGET_*)
- self-shadowing locals renamed where signals/methods became same-named
  (size_changed, worker_count, selected_items, import param, filters)
- third_party OFX member/namespace usages restored (OFX::Host::*,
  _created, _clipPrefsDirty, createInstance, clearPersistentMessage)
- STL protocol aliases restored (const_iterator) with .clang-tidy
  ignore rules; qHash overloads restored

Full build and test suite pass: ctest 4/4, ~1960 gtest cases green.
This commit is contained in:
Mike-Solar
2026-07-19 16:10:54 +08:00
parent cb1718a103
commit bb40b4923e
1014 changed files with 44257 additions and 44220 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/node/inputimmediate.cpp
+10 -10
View File
@@ -50,7 +50,7 @@ void NodeInputImmediate::set_split_standard_value(const SplitValue &value)
}
QVector<NodeKeyframe *>
NodeInputImmediate::get_keyframe_at_time(const rational &time) const
NodeInputImmediate::get_keyframe_at_time(const Rational &time) const
{
QVector<NodeKeyframe *> keys;
@@ -66,7 +66,7 @@ NodeInputImmediate::get_keyframe_at_time(const rational &time) const
}
NodeKeyframe *
NodeInputImmediate::get_keyframe_at_time_on_track(const rational &time,
NodeInputImmediate::get_keyframe_at_time_on_track(const Rational &time,
int track) const
{
if (!is_using_standard_value(track)) {
@@ -81,7 +81,7 @@ NodeInputImmediate::get_keyframe_at_time_on_track(const rational &time,
}
NodeKeyframe *
NodeInputImmediate::get_closest_keyframe_to_time_on_track(const rational &time,
NodeInputImmediate::get_closest_keyframe_to_time_on_track(const Rational &time,
int track) const
{
if (is_using_standard_value(track)) {
@@ -104,8 +104,8 @@ NodeInputImmediate::get_closest_keyframe_to_time_on_track(const rational &time,
if (prev_key->time() <= time && next_key->time() >= time) {
// Return whichever is closer
rational prev_diff = time - prev_key->time();
rational next_diff = next_key->time() - time;
Rational prev_diff = time - prev_key->time();
Rational next_diff = next_key->time() - time;
if (next_diff < prev_diff) {
return next_key;
@@ -119,7 +119,7 @@ NodeInputImmediate::get_closest_keyframe_to_time_on_track(const rational &time,
}
NodeKeyframe *
NodeInputImmediate::get_closest_keyframe_before_time(const rational &time) const
NodeInputImmediate::get_closest_keyframe_before_time(const Rational &time) const
{
NodeKeyframe *key = nullptr;
@@ -137,7 +137,7 @@ NodeInputImmediate::get_closest_keyframe_before_time(const rational &time) const
}
NodeKeyframe *
NodeInputImmediate::get_closest_keyframe_after_time(const rational &time) const
NodeInputImmediate::get_closest_keyframe_after_time(const Rational &time) const
{
NodeKeyframe *key = nullptr;
@@ -157,7 +157,7 @@ NodeInputImmediate::get_closest_keyframe_after_time(const rational &time) const
}
NodeKeyframe::Type
NodeInputImmediate::get_best_keyframe_type_for_time(const rational &time,
NodeInputImmediate::get_best_keyframe_type_for_time(const Rational &time,
int track) const
{
NodeKeyframe *closest_key =
@@ -167,10 +167,10 @@ NodeInputImmediate::get_best_keyframe_type_for_time(const rational &time,
return closest_key->type();
}
return NodeKeyframe::kDefaultType;
return NodeKeyframe::k_default_type;
}
bool NodeInputImmediate::has_keyframe_at_time(const rational &time) const
bool NodeInputImmediate::has_keyframe_at_time(const Rational &time) const
{
if (!is_keyframing()) {
return false;