oak-team/oak-editor
3
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

style: unify identifier naming per updated conventions

Browse Source 
Automated with clang-tidy readability-identifier-naming (config added to
.clang-tidy) plus scripted passes, per the updated rules now documented
in CONTRIBUTING.md:

- types (class/struct/enum/alias/template params): PascalCase
- functions, variables, members: snake_case (incl. rational -> Rational)
- private/protected members: trailing underscore; static member
  variables likewise (instance_, available_themes_)
- constants and enum values: snake_case (kLinear -> k_linear,
  F32P -> f32p); ALL_CAPS reserved for macros
- macros: OAK_ prefix (OLIVE_ADD_TEST/OLIVE_ASSERT/OLIVE_CONFIG ->
  OAK_ADD_TEST/OAK_ASSERT/OAK_CONFIG, GL_PREAMBLE -> OAK_GL_PREAMBLE,
  include guards -> OAK_*)
- file names: all lowercase (Current/Plugin/OliveHost/OliveClip/
  OlivePluginInstance -> current/plugin/olivehost/oliveclip/
  oliveplugininstance)
- getters share the member name sans underscore, setters set_foo()
- Qt and third-party (OpenFX) virtual overrides and framework callbacks
  keep their original names (exempt in .clang-tidy)

Manual follow-ups required where automation could not reach:
- string-based QMetaObject/SIGNAL/SLOT references updated to renamed
  methods (AddTask, CreatedFile, DeleteSpecificFile, moveSelectionUp, ...)
- macro bodies referencing renamed methods (OLIVE_CONFIG,
  NODE_DEFAULT_DESTRUCTOR, MANAGEDDISPLAYWIDGET_*)
- self-shadowing locals renamed where signals/methods became same-named
  (size_changed, worker_count, selected_items, import param, filters)
- third_party OFX member/namespace usages restored (OFX::Host::*,
  _created, _clipPrefsDirty, createInstance, clearPersistentMessage)
- STL protocol aliases restored (const_iterator) with .clang-tidy
  ignore rules; qHash overloads restored

Full build and test suite pass: ctest 4/4, ~1960 gtest cases green.
This commit is contained in:
Mike-Solar
2026-07-19 16:10:54 +08:00
parent cb1718a103
commit bb40b4923e
1014 changed files with 44257 additions and 44220 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/node/gizmo/text.h
+15 -15
View File
@@ -19,8 +19,8 @@
***/
#ifndef TEXTGIZMO_H
#define TEXTGIZMO_H
#ifndef OAK_TEXTGIZMO_H
#define OAK_TEXTGIZMO_H
#include "gizmo.h"
#include "node/param.h"
@@ -33,39 +33,39 @@ class TextGizmo : public NodeGizmo {
public:
explicit TextGizmo(QObject *parent = nullptr);
const QRectF &GetRect() const
const QRectF &get_rect() const
{
return rect_;
}
void SetRect(const QRectF &r);
void set_rect(const QRectF &r);
const QString &GetHtml() const
const QString &get_html() const
{
return text_;
}
void SetHtml(const QString &t)
void set_html(const QString &t)
{
text_ = t;
}
void SetInput(const NodeKeyframeTrackReference &input)
void set_input(const NodeKeyframeTrackReference &input)
{
input_ = input;
}
void UpdateInputHtml(const QString &s, const rational &time);
void update_input_html(const QString &s, const Rational &time);
Qt::Alignment GetVerticalAlignment() const
Qt::Alignment get_vertical_alignment() const
{
return valign_;
}
void SetVerticalAlignment(Qt::Alignment va);
void set_vertical_alignment(Qt::Alignment va);
signals:
void Activated();
void Deactivated();
void VerticalAlignmentChanged(Qt::Alignment va);
void RectChanged(const QRectF &r);
void activated();
void deactivated();
void vertical_alignment_changed(Qt::Alignment va);
void rect_changed(const QRectF &r);
private:
QRectF rect_;
@@ -79,4 +79,4 @@ private:
}
#endif // TEXTGIZMO_H
#endif // OAK_TEXTGIZMO_H