style: unify identifier naming per updated conventions

Automated with clang-tidy readability-identifier-naming (config added to
.clang-tidy) plus scripted passes, per the updated rules now documented
in CONTRIBUTING.md:

- types (class/struct/enum/alias/template params): PascalCase
- functions, variables, members: snake_case (incl. rational -> Rational)
- private/protected members: trailing underscore; static member
  variables likewise (instance_, available_themes_)
- constants and enum values: snake_case (kLinear -> k_linear,
  F32P -> f32p); ALL_CAPS reserved for macros
- macros: OAK_ prefix (OLIVE_ADD_TEST/OLIVE_ASSERT/OLIVE_CONFIG ->
  OAK_ADD_TEST/OAK_ASSERT/OAK_CONFIG, GL_PREAMBLE -> OAK_GL_PREAMBLE,
  include guards -> OAK_*)
- file names: all lowercase (Current/Plugin/OliveHost/OliveClip/
  OlivePluginInstance -> current/plugin/olivehost/oliveclip/
  oliveplugininstance)
- getters share the member name sans underscore, setters set_foo()
- Qt and third-party (OpenFX) virtual overrides and framework callbacks
  keep their original names (exempt in .clang-tidy)

Manual follow-ups required where automation could not reach:
- string-based QMetaObject/SIGNAL/SLOT references updated to renamed
  methods (AddTask, CreatedFile, DeleteSpecificFile, moveSelectionUp, ...)
- macro bodies referencing renamed methods (OLIVE_CONFIG,
  NODE_DEFAULT_DESTRUCTOR, MANAGEDDISPLAYWIDGET_*)
- self-shadowing locals renamed where signals/methods became same-named
  (size_changed, worker_count, selected_items, import param, filters)
- third_party OFX member/namespace usages restored (OFX::Host::*,
  _created, _clipPrefsDirty, createInstance, clearPersistentMessage)
- STL protocol aliases restored (const_iterator) with .clang-tidy
  ignore rules; qHash overloads restored

Full build and test suite pass: ctest 4/4, ~1960 gtest cases green.
This commit is contained in:
2026-07-19 16:10:54 +08:00
parent cb1718a103
commit bb40b4923e
1014 changed files with 44257 additions and 44220 deletions
+20 -20
View File
@@ -19,8 +19,8 @@
***/
#ifndef SHAPENODEBASE_H
#define SHAPENODEBASE_H
#ifndef OAK_SHAPENODEBASE_H
#define OAK_SHAPENODEBASE_H
#include "generatorwithmerge.h"
#include "node/gizmo/point.h"
@@ -36,17 +36,17 @@ class ShapeNodeBase : public GeneratorWithMerge {
public:
ShapeNodeBase(bool create_color_input = true);
virtual void Retranslate() override;
virtual void retranslate() override;
virtual void UpdateGizmoPositions(const NodeValueRow &row,
virtual void update_gizmo_positions(const NodeValueRow &row,
const NodeGlobals &globals) override;
void SetRect(QRectF rect, const VideoParams &sequence_res,
void set_rect(QRectF rect, const VideoParams &sequence_res,
MultiUndoCommand *command);
static const QString kPositionInput;
static const QString kSizeInput;
static const QString kColorInput;
static const QString k_position_input;
static const QString k_size_input;
static const QString k_color_input;
protected:
PolygonGizmo *poly_gizmo() const
@@ -55,28 +55,28 @@ protected:
}
protected slots:
virtual void GizmoDragMove(double x, double y,
virtual void gizmo_drag_move(double x, double y,
const Qt::KeyboardModifiers &modifiers) override;
private:
QVector2D GenerateGizmoAnchor(const QVector2D &pos, const QVector2D &size,
QVector2D generate_gizmo_anchor(const QVector2D &pos, const QVector2D &size,
NodeGizmo *gizmo,
QVector2D *pt = nullptr) const;
bool IsGizmoTop(NodeGizmo *g) const;
bool IsGizmoBottom(NodeGizmo *g) const;
bool IsGizmoLeft(NodeGizmo *g) const;
bool IsGizmoRight(NodeGizmo *g) const;
bool IsGizmoHorizontalCenter(NodeGizmo *g) const;
bool IsGizmoVerticalCenter(NodeGizmo *g) const;
bool IsGizmoCorner(NodeGizmo *g) const;
bool is_gizmo_top(NodeGizmo *g) const;
bool is_gizmo_bottom(NodeGizmo *g) const;
bool is_gizmo_left(NodeGizmo *g) const;
bool is_gizmo_right(NodeGizmo *g) const;
bool is_gizmo_horizontal_center(NodeGizmo *g) const;
bool is_gizmo_vertical_center(NodeGizmo *g) const;
bool is_gizmo_corner(NodeGizmo *g) const;
// Gizmo variables
static const int kGizmoWholeRect = kGizmoScaleCount;
PointGizmo *point_gizmo_[kGizmoScaleCount];
static const int k_gizmo_whole_rect = k_gizmo_scale_count;
PointGizmo *point_gizmo_[k_gizmo_scale_count];
PolygonGizmo *poly_gizmo_;
};
}
#endif // SHAPENODEBASE_H
#endif // OAK_SHAPENODEBASE_H