oak-team/oak-editor
3
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

style: unify identifier naming per updated conventions

Browse Source 
Automated with clang-tidy readability-identifier-naming (config added to
.clang-tidy) plus scripted passes, per the updated rules now documented
in CONTRIBUTING.md:

- types (class/struct/enum/alias/template params): PascalCase
- functions, variables, members: snake_case (incl. rational -> Rational)
- private/protected members: trailing underscore; static member
  variables likewise (instance_, available_themes_)
- constants and enum values: snake_case (kLinear -> k_linear,
  F32P -> f32p); ALL_CAPS reserved for macros
- macros: OAK_ prefix (OLIVE_ADD_TEST/OLIVE_ASSERT/OLIVE_CONFIG ->
  OAK_ADD_TEST/OAK_ASSERT/OAK_CONFIG, GL_PREAMBLE -> OAK_GL_PREAMBLE,
  include guards -> OAK_*)
- file names: all lowercase (Current/Plugin/OliveHost/OliveClip/
  OlivePluginInstance -> current/plugin/olivehost/oliveclip/
  oliveplugininstance)
- getters share the member name sans underscore, setters set_foo()
- Qt and third-party (OpenFX) virtual overrides and framework callbacks
  keep their original names (exempt in .clang-tidy)

Manual follow-ups required where automation could not reach:
- string-based QMetaObject/SIGNAL/SLOT references updated to renamed
  methods (AddTask, CreatedFile, DeleteSpecificFile, moveSelectionUp, ...)
- macro bodies referencing renamed methods (OLIVE_CONFIG,
  NODE_DEFAULT_DESTRUCTOR, MANAGEDDISPLAYWIDGET_*)
- self-shadowing locals renamed where signals/methods became same-named
  (size_changed, worker_count, selected_items, import param, filters)
- third_party OFX member/namespace usages restored (OFX::Host::*,
  _created, _clipPrefsDirty, createInstance, clearPersistentMessage)
- STL protocol aliases restored (const_iterator) with .clang-tidy
  ignore rules; qHash overloads restored

Full build and test suite pass: ctest 4/4, ~1960 gtest cases green.
This commit is contained in:
Mike-Solar
2026-07-19 16:10:54 +08:00
parent cb1718a103
commit bb40b4923e
1014 changed files with 44257 additions and 44220 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/node/distort/crop/cropdistortnode.h
+20 -20
View File
@@ -19,8 +19,8 @@
***/
#ifndef CROPDISTORTNODE_H
#define CROPDISTORTNODE_H
#ifndef OAK_CROPDISTORTNODE_H
#define OAK_CROPDISTORTNODE_H
#include <QVector2D>
@@ -39,7 +39,7 @@ public:
NODE_DEFAULT_FUNCTIONS(CropDistortNode)
virtual QString Name() const override
virtual QString name() const override
{
return tr("Crop");
}
@@ -49,47 +49,47 @@ public:
return QStringLiteral("org.olivevideoeditor.Olive.crop");
}
virtual QVector<CategoryID> Category() const override
virtual QVector<CategoryID> category() const override
{
return { kCategoryDistort };
return { k_category_distort };
}
virtual QString Description() const override
virtual QString description() const override
{
return tr("Crop the edges of an image.");
}
virtual void Retranslate() override;
virtual void retranslate() override;
virtual void Value(const NodeValueRow &value, const NodeGlobals &globals,
virtual void value(const NodeValueRow &value, const NodeGlobals &globals,
NodeValueTable *table) const override;
virtual ShaderCode
GetShaderCode(const ShaderRequest &request) const override;
get_shader_code(const ShaderRequest &request) const override;
virtual void UpdateGizmoPositions(const NodeValueRow &row,
virtual void update_gizmo_positions(const NodeValueRow &row,
const NodeGlobals &globals) override;
static const QString kTextureInput;
static const QString kLeftInput;
static const QString kTopInput;
static const QString kRightInput;
static const QString kBottomInput;
static const QString kFeatherInput;
static const QString k_texture_input;
static const QString k_left_input;
static const QString k_top_input;
static const QString k_right_input;
static const QString k_bottom_input;
static const QString k_feather_input;
protected slots:
virtual void GizmoDragMove(double delta_x, double delta_y,
virtual void gizmo_drag_move(double delta_x, double delta_y,
const Qt::KeyboardModifiers &modifiers) override;
private:
void CreateCropSideInput(const QString &id);
void create_crop_side_input(const QString &id);
// Gizmo variables
PointGizmo *point_gizmo_[kGizmoScaleCount];
PointGizmo *point_gizmo_[k_gizmo_scale_count];
PolygonGizmo *poly_gizmo_;
QVector2D temp_resolution_;
};
}
#endif // CROPDISTORTNODE_H
#endif // OAK_CROPDISTORTNODE_H