style: unify identifier naming per updated conventions

Automated with clang-tidy readability-identifier-naming (config added to
.clang-tidy) plus scripted passes, per the updated rules now documented
in CONTRIBUTING.md:

- types (class/struct/enum/alias/template params): PascalCase
- functions, variables, members: snake_case (incl. rational -> Rational)
- private/protected members: trailing underscore; static member
  variables likewise (instance_, available_themes_)
- constants and enum values: snake_case (kLinear -> k_linear,
  F32P -> f32p); ALL_CAPS reserved for macros
- macros: OAK_ prefix (OLIVE_ADD_TEST/OLIVE_ASSERT/OLIVE_CONFIG ->
  OAK_ADD_TEST/OAK_ASSERT/OAK_CONFIG, GL_PREAMBLE -> OAK_GL_PREAMBLE,
  include guards -> OAK_*)
- file names: all lowercase (Current/Plugin/OliveHost/OliveClip/
  OlivePluginInstance -> current/plugin/olivehost/oliveclip/
  oliveplugininstance)
- getters share the member name sans underscore, setters set_foo()
- Qt and third-party (OpenFX) virtual overrides and framework callbacks
  keep their original names (exempt in .clang-tidy)

Manual follow-ups required where automation could not reach:
- string-based QMetaObject/SIGNAL/SLOT references updated to renamed
  methods (AddTask, CreatedFile, DeleteSpecificFile, moveSelectionUp, ...)
- macro bodies referencing renamed methods (OLIVE_CONFIG,
  NODE_DEFAULT_DESTRUCTOR, MANAGEDDISPLAYWIDGET_*)
- self-shadowing locals renamed where signals/methods became same-named
  (size_changed, worker_count, selected_items, import param, filters)
- third_party OFX member/namespace usages restored (OFX::Host::*,
  _created, _clipPrefsDirty, createInstance, clearPersistentMessage)
- STL protocol aliases restored (const_iterator) with .clang-tidy
  ignore rules; qHash overloads restored

Full build and test suite pass: ctest 4/4, ~1960 gtest cases green.
This commit is contained in:
2026-07-19 16:10:54 +08:00
parent cb1718a103
commit bb40b4923e
1014 changed files with 44257 additions and 44220 deletions
+9 -9
View File
@@ -19,8 +19,8 @@
***/
#ifndef SEQUENCEDIALOG_H
#define SEQUENCEDIALOG_H
#ifndef OAK_SEQUENCEDIALOG_H
#define OAK_SEQUENCEDIALOG_H
#include <QComboBox>
#include <QDialog>
@@ -54,7 +54,7 @@ public:
/**
* @brief Used to set the dialog mode of operation (see SequenceDialog())
*/
enum Type { kNew, kExisting };
enum Type { k_new, k_existing };
/**
* @brief SequenceDialog Constructor
@@ -68,21 +68,21 @@ public:
* @param parent
* QWidget parent
*/
SequenceDialog(Sequence *s, Type t = kExisting, QWidget *parent = nullptr);
SequenceDialog(Sequence *s, Type t = k_existing, QWidget *parent = nullptr);
/**
* @brief Set whether the parameter changes should be made into an undo command or not
*
* Defaults to true.
*/
void SetUndoable(bool u);
void set_undoable(bool u);
/**
* @brief Set whether the name of this Sequence can be edited with this dialog
*
* Defaults to true.
*/
void SetNameIsEditable(bool e);
void set_name_is_editable(bool e);
public slots:
/**
@@ -110,7 +110,7 @@ private:
const AudioParams &audio_params,
const QString &name, bool autocache);
virtual Project *GetRelevantProject() const override;
virtual Project *get_relevant_project() const override;
protected:
virtual void redo() override;
@@ -131,9 +131,9 @@ private:
};
private slots:
void SetAsDefaultClicked();
void set_as_default_clicked();
};
}
#endif // SEQUENCEDIALOG_H
#endif // OAK_SEQUENCEDIALOG_H