style: unify identifier naming per updated conventions
Automated with clang-tidy readability-identifier-naming (config added to .clang-tidy) plus scripted passes, per the updated rules now documented in CONTRIBUTING.md: - types (class/struct/enum/alias/template params): PascalCase - functions, variables, members: snake_case (incl. rational -> Rational) - private/protected members: trailing underscore; static member variables likewise (instance_, available_themes_) - constants and enum values: snake_case (kLinear -> k_linear, F32P -> f32p); ALL_CAPS reserved for macros - macros: OAK_ prefix (OLIVE_ADD_TEST/OLIVE_ASSERT/OLIVE_CONFIG -> OAK_ADD_TEST/OAK_ASSERT/OAK_CONFIG, GL_PREAMBLE -> OAK_GL_PREAMBLE, include guards -> OAK_*) - file names: all lowercase (Current/Plugin/OliveHost/OliveClip/ OlivePluginInstance -> current/plugin/olivehost/oliveclip/ oliveplugininstance) - getters share the member name sans underscore, setters set_foo() - Qt and third-party (OpenFX) virtual overrides and framework callbacks keep their original names (exempt in .clang-tidy) Manual follow-ups required where automation could not reach: - string-based QMetaObject/SIGNAL/SLOT references updated to renamed methods (AddTask, CreatedFile, DeleteSpecificFile, moveSelectionUp, ...) - macro bodies referencing renamed methods (OLIVE_CONFIG, NODE_DEFAULT_DESTRUCTOR, MANAGEDDISPLAYWIDGET_*) - self-shadowing locals renamed where signals/methods became same-named (size_changed, worker_count, selected_items, import param, filters) - third_party OFX member/namespace usages restored (OFX::Host::*, _created, _clipPrefsDirty, createInstance, clearPersistentMessage) - STL protocol aliases restored (const_iterator) with .clang-tidy ignore rules; qHash overloads restored Full build and test suite pass: ctest 4/4, ~1960 gtest cases green.
This commit is contained in:
@@ -16,8 +16,8 @@
|
||||
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
||||
*/
|
||||
|
||||
#ifndef PROXYDIALOG_H
|
||||
#define PROXYDIALOG_H
|
||||
#ifndef OAK_PROXYDIALOG_H
|
||||
#define OAK_PROXYDIALOG_H
|
||||
|
||||
#include <QCheckBox>
|
||||
#include <QComboBox>
|
||||
@@ -39,36 +39,36 @@ public:
|
||||
|
||||
virtual void accept() override;
|
||||
|
||||
int ProxyWidth() const;
|
||||
int proxy_width() const;
|
||||
|
||||
int ProxyHeight() const;
|
||||
int proxy_height() const;
|
||||
|
||||
int ProxyCRF() const;
|
||||
int proxy_crf() const;
|
||||
|
||||
QString ProxyPreset() const;
|
||||
QString proxy_preset() const;
|
||||
|
||||
bool ProxyIncludeAudio() const;
|
||||
bool proxy_include_audio() const;
|
||||
|
||||
QString FFmpegPath() const;
|
||||
QString f_fmpeg_path() const;
|
||||
|
||||
void SetProxyWidth(int width);
|
||||
void set_proxy_width(int width);
|
||||
|
||||
void SetProxyHeight(int height);
|
||||
void set_proxy_height(int height);
|
||||
|
||||
void SetProxyCRF(int crf);
|
||||
void set_proxy_crf(int crf);
|
||||
|
||||
void SetProxyPreset(const QString &preset);
|
||||
void set_proxy_preset(const QString &preset);
|
||||
|
||||
void SetProxyIncludeAudio(bool include_audio);
|
||||
void set_proxy_include_audio(bool include_audio);
|
||||
|
||||
void SetFFmpegPath(const QString &path);
|
||||
void set_f_fmpeg_path(const QString &path);
|
||||
|
||||
private:
|
||||
ProxyManager::ProxyParams CurrentParams() const;
|
||||
ProxyManager::ProxyParams current_params() const;
|
||||
|
||||
void SaveGlobalSettings();
|
||||
void save_global_settings();
|
||||
|
||||
void RefreshFootageList();
|
||||
void refresh_footage_list();
|
||||
|
||||
QVector<Footage *> footage_;
|
||||
|
||||
@@ -89,13 +89,13 @@ private:
|
||||
QLineEdit *ffmpeg_path_edit_;
|
||||
|
||||
private slots:
|
||||
void GenerateProxies();
|
||||
void generate_proxies();
|
||||
|
||||
void DeleteProxies();
|
||||
void delete_proxies();
|
||||
|
||||
void BrowseForFFmpeg();
|
||||
void browse_for_f_fmpeg();
|
||||
};
|
||||
|
||||
}
|
||||
|
||||
#endif // PROXYDIALOG_H
|
||||
#endif // OAK_PROXYDIALOG_H
|
||||
|
||||
Reference in New Issue
Block a user