oak-team/oak-editor
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

style: unify identifier naming per updated conventions

Browse Source 
Automated with clang-tidy readability-identifier-naming (config added to
.clang-tidy) plus scripted passes, per the updated rules now documented
in CONTRIBUTING.md:

- types (class/struct/enum/alias/template params): PascalCase
- functions, variables, members: snake_case (incl. rational -> Rational)
- private/protected members: trailing underscore; static member
  variables likewise (instance_, available_themes_)
- constants and enum values: snake_case (kLinear -> k_linear,
  F32P -> f32p); ALL_CAPS reserved for macros
- macros: OAK_ prefix (OLIVE_ADD_TEST/OLIVE_ASSERT/OLIVE_CONFIG ->
  OAK_ADD_TEST/OAK_ASSERT/OAK_CONFIG, GL_PREAMBLE -> OAK_GL_PREAMBLE,
  include guards -> OAK_*)
- file names: all lowercase (Current/Plugin/OliveHost/OliveClip/
  OlivePluginInstance -> current/plugin/olivehost/oliveclip/
  oliveplugininstance)
- getters share the member name sans underscore, setters set_foo()
- Qt and third-party (OpenFX) virtual overrides and framework callbacks
  keep their original names (exempt in .clang-tidy)

Manual follow-ups required where automation could not reach:
- string-based QMetaObject/SIGNAL/SLOT references updated to renamed
  methods (AddTask, CreatedFile, DeleteSpecificFile, moveSelectionUp, ...)
- macro bodies referencing renamed methods (OLIVE_CONFIG,
  NODE_DEFAULT_DESTRUCTOR, MANAGEDDISPLAYWIDGET_*)
- self-shadowing locals renamed where signals/methods became same-named
  (size_changed, worker_count, selected_items, import param, filters)
- third_party OFX member/namespace usages restored (OFX::Host::*,
  _created, _clipPrefsDirty, createInstance, clearPersistentMessage)
- STL protocol aliases restored (const_iterator) with .clang-tidy
  ignore rules; qHash overloads restored

Full build and test suite pass: ctest 4/4, ~1960 gtest cases green.
This commit is contained in:
Mike-Solar
2026-07-19 16:10:54 +08:00
parent cb1718a103
commit bb40b4923e
1014 changed files with 44257 additions and 44220 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/common/commandlineparser.h
+11 -11
View File
@@ -19,8 +19,8 @@
***/
#ifndef COMMANDLINEPARSER_H
#define COMMANDLINEPARSER_H
#ifndef OAK_COMMANDLINEPARSER_H
#define OAK_COMMANDLINEPARSER_H
#include <QStringList>
#include <QVector>
@@ -47,12 +47,12 @@ public:
public:
PositionalArgument() = default;
const QString &GetSetting() const
const QString &get_setting() const
{
return setting_;
}
void SetSetting(const QString &s)
void set_setting(const QString &s)
{
setting_ = s;
}
@@ -68,12 +68,12 @@ public:
is_set_ = false;
}
bool IsSet() const
bool is_set() const
{
return is_set_;
}
void Set()
void set()
{
is_set_ = true;
}
@@ -84,18 +84,18 @@ public:
CommandLineParser() = default;
const Option *AddOption(const QStringList &strings,
const Option *add_option(const QStringList &strings,
const QString &description, bool takes_arg = false,
const QString &arg_placeholder = QString(),
bool hidden = false);
const PositionalArgument *AddPositionalArgument(const QString &name,
const PositionalArgument *add_positional_argument(const QString &name,
const QString &description,
bool required = false);
void Process(const QVector<QString> &argv);
void process(const QVector<QString> &argv);
void PrintHelp(const char *filename);
void print_help(const char *filename);
private:
struct KnownOption {
@@ -119,4 +119,4 @@ private:
QVector<KnownPositionalArgument> positional_args_;
};
#endif // COMMANDLINEPARSER_H
#endif // OAK_COMMANDLINEPARSER_H