app: PlaybackController + playhead subscription migration (issues 0c, 1-4)
New app/playback/playbackcontroller.{h,cpp}: a lazily created
process-wide singleton whose set_playhead() forwards to
oakengine_viewer_set_playhead and re-broadcasts playhead_changed as a
plain Qt signal. Every app-side oakengine_viewer_set_playhead call site
(17 across viewer, timelinewidget, timelineview, import tool,
timebasedwidget, keyframecontrol, export dialog, mainwindow) now goes
through it.
Migrate the first four playhead subscribers off the raw C event
subscription / EngineEventBridge to the controller signal:
- TimeBasedView (issue 1)
- NodeParamViewWidgetBridge (issue 2)
- NodeParamViewKeyframeControl (issue 3)
- NodeParamViewConnectedLabel (issue 4)
Each stores a QMetaObject::Connection filtered on its viewer node and
disconnects on teardown; the viewer_sub_ members are gone. Plan docs
mark issues 0c and 1-4 as done.
Closes #30, closes #31, closes #32, closes #51, closes #52.
This commit is contained in:
@@ -64,7 +64,7 @@ C callbacks just queue to the GUI thread and re-emit typed Qt signals.
|
||||
later (b) migrations must use it instead of their own subscriptions.
|
||||
- **Required: build + ctest all green.**
|
||||
|
||||
### issue 0c — App-internal PlaybackController (1 day)
|
||||
### issue 0c ✅ (done) — App-internal PlaybackController (1 day)
|
||||
Create `app/playback/playbackcontroller.{h,cpp}` with a
|
||||
`playhead_changed(oak::Node viewer, Rational)` signal. Route every
|
||||
`oakengine_viewer_set_playhead` call site in the app (ViewerWidget playback
|
||||
@@ -82,26 +82,26 @@ In other words: one app-side controller that every
|
||||
|
||||
## Playhead migrations (pattern A, about half a day each)
|
||||
|
||||
### issue 1 — timebasedview playhead subscription
|
||||
### issue 1 ✅ (done) — timebasedview playhead subscription
|
||||
`app/widget/timebased/timebasedview.cpp:168` (raw C callback). Reconnect to
|
||||
`PlaybackController::playhead_changed`.
|
||||
- Acceptance: the ruler playhead line moves during playback; no raw C
|
||||
subscription remains.
|
||||
- **Required: build + ctest all green.**
|
||||
|
||||
### issue 2 — NodeParamViewWidgetBridge playhead
|
||||
### issue 2 ✅ (done) — NodeParamViewWidgetBridge playhead
|
||||
`app/widget/nodeparamview/nodeparamviewwidgetbridge.cpp:1140` (raw C).
|
||||
- Acceptance: keyframe-interpolated slider values follow the playhead
|
||||
during playback.
|
||||
- **Required: build + ctest all green.**
|
||||
|
||||
### issue 3 — NodeParamViewKeyframeControl playhead
|
||||
### issue 3 ✅ (done) — NodeParamViewKeyframeControl playhead
|
||||
`app/widget/nodeparamview/nodeparamviewkeyframecontrol.cpp:222` (raw C).
|
||||
- Acceptance: prev/next/toggle keyframe buttons have the correct state as
|
||||
the playhead moves.
|
||||
- **Required: build + ctest all green.**
|
||||
|
||||
### issue 4 — NodeParamViewConnectedLabel playhead
|
||||
### issue 4 ✅ (done) — NodeParamViewConnectedLabel playhead
|
||||
`app/widget/nodeparamview/nodeparamviewconnectedlabel.cpp:131` (raw C).
|
||||
- Acceptance: the value tree refreshes with the playhead.
|
||||
- **Required: build + ctest all green.**
|
||||
|
||||
Reference in New Issue
Block a user