From b51cae04752558397fd0376c5941e324f20782ff Mon Sep 17 00:00:00 2001 From: itsmattkc <34096995+itsmattkc@users.noreply.github.com> Date: Sat, 7 May 2022 10:28:48 -0700 Subject: [PATCH] viewer: prepend main widget to tab focus order Fixes UI papercut where maximizing a panel (with `) would auto-focus the time slider, meaning pressing ` again wouldn't immediately un-maximize --- app/widget/viewer/viewer.cpp | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/app/widget/viewer/viewer.cpp b/app/widget/viewer/viewer.cpp index b5720f927..92b92eead 100644 --- a/app/widget/viewer/viewer.cpp +++ b/app/widget/viewer/viewer.cpp @@ -98,6 +98,11 @@ ViewerWidget::ViewerWidget(QWidget *parent) : connect(display_widget_, &ViewerDisplayWidget::HandDragMoved, sizer_, &ViewerSizer::HandDragMove); sizer_->SetWidget(display_widget_); + // Make the display widget the first tabbable widget. While the viewer display cannot actually + // be interacted with by tabbing, it prevents the actual first tabbable widget (the playhead + // slider in `controls_`) from getting auto-focused any time the panel is maximized (with `) + display_widget_->setFocusPolicy(Qt::TabFocus); + // Create waveform view when audio is connected and video isn't waveform_view_ = new AudioWaveformView(); ConnectTimelineView(waveform_view_, true);