From b40dd761f51a9fa6b06aa4c55ae8678e9f74f6bf Mon Sep 17 00:00:00 2001
From: itsmattkc <itsmattkc@gmail.com>
Date: Sat, 28 Mar 2020 11:36:05 +1100
Subject: [PATCH] projectexplorer: cache first selected item for context menu
 operations

Minor optimization.
---
 app/widget/projectexplorer/projectexplorer.cpp | 14 ++++++++------
 app/widget/projectexplorer/projectexplorer.h   |  2 ++
 2 files changed, 10 insertions(+), 6 deletions(-)

diff --git a/app/widget/projectexplorer/projectexplorer.cpp b/app/widget/projectexplorer/projectexplorer.cpp
index d252491b9..1f7468a10 100644
--- a/app/widget/projectexplorer/projectexplorer.cpp
+++ b/app/widget/projectexplorer/projectexplorer.cpp
@@ -246,7 +246,9 @@ void ProjectExplorer::ShowContextMenu()
     QAction* project_properties = menu.addAction(tr("&Project Properties..."));
     connect(project_properties, &QAction::triggered, Core::instance(), &Core::DialogProjectPropertiesShow);
   } else {
-    if (selected_items.first()->type() == Item::kFootage) {
+    context_menu_item_ = selected_items.first();
+
+    if (context_menu_item_->type() == Item::kFootage) {
       QString reveal_text;
 
 #if defined(Q_OS_WINDOWS)
@@ -265,9 +267,9 @@ void ProjectExplorer::ShowContextMenu()
 
     QAction* properties_action = menu.addAction(tr("P&roperties"));
 
-    if (selected_items.first()->type() == Item::kFootage) {
+    if (context_menu_item_->type() == Item::kFootage) {
       connect(properties_action, &QAction::triggered, this, &ProjectExplorer::ShowFootagePropertiesDialog);
-    } else if (selected_items.first()->type() == Item::kSequence) {
+    } else if (context_menu_item_->type() == Item::kSequence) {
       connect(properties_action, &QAction::triggered, this, &ProjectExplorer::ShowSequencePropertiesDialog);
     }
   }
@@ -278,20 +280,20 @@ void ProjectExplorer::ShowContextMenu()
 void ProjectExplorer::ShowFootagePropertiesDialog()
 {
   // FIXME: Support for multiple items
-  FootagePropertiesDialog fpd(this, static_cast<Footage*>(SelectedItems().first()));
+  FootagePropertiesDialog fpd(this, static_cast<Footage*>(context_menu_item_));
   fpd.exec();
 }
 
 void ProjectExplorer::ShowSequencePropertiesDialog()
 {
   // FIXME: Support for multiple items
-  SequenceDialog sd(static_cast<Sequence*>(SelectedItems().first()), SequenceDialog::kExisting, this);
+  SequenceDialog sd(static_cast<Sequence*>(context_menu_item_), SequenceDialog::kExisting, this);
   sd.exec();
 }
 
 void ProjectExplorer::RevealSelectedFootage()
 {
-  Footage* footage = static_cast<Footage*>(SelectedItems().first());
+  Footage* footage = static_cast<Footage*>(context_menu_item_);
 
 #if defined(Q_OS_WINDOWS)
   // Explorer
diff --git a/app/widget/projectexplorer/projectexplorer.h b/app/widget/projectexplorer/projectexplorer.h
index 910ebfd19..84caca476 100644
--- a/app/widget/projectexplorer/projectexplorer.h
+++ b/app/widget/projectexplorer/projectexplorer.h
@@ -136,6 +136,8 @@ private:
 
   QTimer rename_timer_;
 
+  Item* context_menu_item_;
+
 private slots:
   void ItemClickedSlot(const QModelIndex& index);