From 95dbeac8a522303933bf38d0d6a0d1ec3f69f5f7 Mon Sep 17 00:00:00 2001
From: itsmattkc <itsmattkc@gmail.com>
Date: Mon, 15 Jun 2020 15:42:49 +1000
Subject: [PATCH] viewer: don't show playback queue warning if past the video's
 end point

---
 app/widget/viewer/viewer.cpp | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/app/widget/viewer/viewer.cpp b/app/widget/viewer/viewer.cpp
index 934ececd5..1e846d429 100644
--- a/app/widget/viewer/viewer.cpp
+++ b/app/widget/viewer/viewer.cpp
@@ -410,9 +410,14 @@ void DecodeCachedImage(RenderTicketPtr ticket, const QString &fn, const rational
 
 void ViewerWidget::UpdateTextureFromNode(const rational& time)
 {
+  bool frame_exists_at_time = FrameExistsAtTime(time);
+
   // Check playback queue for a frame
   if (IsPlaying()) {
 
+    // We still run the playback queue even when FrameExistsAtTime returns false because we might be
+    // playing backwards and about to start showing frames, so the queue should be prepared for
+    // that.
     while (!playback_queue_.empty()) {
 
       const ViewerPlaybackFrame& pf = playback_queue_.front();
@@ -431,11 +436,14 @@ void ViewerWidget::UpdateTextureFromNode(const rational& time)
       }
     }
 
-    qWarning() << "Playback queue failed to keep up";
+    // Only show warning if frame actually exists
+    if (frame_exists_at_time) {
+      qWarning() << "Playback queue failed to keep up";
+    }
 
   }
 
-  if (!FrameExistsAtTime(time)) {
+  if (!frame_exists_at_time) {
     // There is definitely no frame here, we can immediately flip to showing nothing
     nonqueue_watchers_.clear();
     SetDisplayImage(nullptr, false);