feat: built-in effect params, clip click-select, effect drag-and-drop, project load with plugins
- serializer resolves node types through the factory's dynamic (runtime-registered OpenFX) entries, so a project carrying plugin nodes loads again (was: "unknown node type"); covered by a new CI-gated round-trip test driving the real fixture plugin - built-in effect nodes expose their inputs as inspector parameters like the C++ parameter editor: localized input names from the behavior, combo option tables via the new NodeBehavior::input_combo_strings (16 nodes, string-for-string from the C++ set_combo_box_strings), connection/data inputs excluded - effect library: live drag-and-drop — onto the inspector's effect stack (lands at the indicator position) and onto the node editor canvas (creates the node at the drop point); double-click still appends to the selected clip - inspector parameter controls are no longer recreated per render (gpui stack view caches them per effect), so sliders drag and checkboxes click; the view observes the engine and silently re-syncs values (undo/redo land on the widgets) - timeline: left-press selects clips (plain/keep-multi/Ctrl-Cmd toggle); clip moves clamp the shared delta so no clip of a linked group lands before frame 0 instead of failing with "invalid move target" - oakplugin: createInstance-rejected instances skip the destroyInstance notification (the plugin never owned them); vendor-suite fetchSuite misses moved behind OAK_OFX_TRACE; the worker logs the discovered/ registered plugin counts - CI: the OFX probe step also runs the serialization round-trip test - gpui submodule: params view caching, clip click-select, library drag payload, graph_position_at
This commit is contained in:
@@ -103,6 +103,10 @@ impl<E: AppEngine> Render for EffectLibraryPanel<E> {
|
||||
let row_id = entry.type_id.clone();
|
||||
let name = entry.name.clone();
|
||||
let type_id = entry.type_id.clone();
|
||||
let drag_payload = gpui::effect_stack::LibraryEffectDrag {
|
||||
type_id: SharedString::from(entry.type_id.clone()),
|
||||
name: SharedString::from(entry.name.clone()),
|
||||
};
|
||||
list = list.child(
|
||||
div()
|
||||
.id(SharedString::from(format!("effect-library-{type_id}")))
|
||||
@@ -115,6 +119,14 @@ impl<E: AppEngine> Render for EffectLibraryPanel<E> {
|
||||
.text_color(colors.text)
|
||||
.hover(|style| style.bg(colors.selected))
|
||||
.child(name)
|
||||
// Drag the effect onto the inspector's effect stack (or
|
||||
// the node editor) to add it there; double-click adds it
|
||||
// to the selected clip's chain end.
|
||||
.on_drag(drag_payload, |payload, _origin, _window, cx| {
|
||||
cx.new(|_cx| EffectDragGhost {
|
||||
name: payload.name.clone(),
|
||||
})
|
||||
})
|
||||
.on_click(move |event: &ClickEvent, _window, cx| {
|
||||
// Double-click appends the effect to the selected
|
||||
// clip's chain; the backend clamps the index to the
|
||||
@@ -184,6 +196,28 @@ fn group_header(colors: &gpui::colors::Colors, group: &str) -> impl IntoElement
|
||||
.child(group.to_string())
|
||||
}
|
||||
|
||||
/// The drag ghost shown under the pointer while an effect is dragged out
|
||||
/// of the library (a small floating label with the effect name).
|
||||
struct EffectDragGhost {
|
||||
name: SharedString,
|
||||
}
|
||||
|
||||
impl Render for EffectDragGhost {
|
||||
fn render(&mut self, _window: &mut Window, cx: &mut Context<Self>) -> impl IntoElement {
|
||||
let colors = cx.default_colors().clone();
|
||||
div()
|
||||
.px_2()
|
||||
.py_1()
|
||||
.rounded_sm()
|
||||
.border_1()
|
||||
.border_color(colors.border)
|
||||
.bg(colors.container)
|
||||
.text_sm()
|
||||
.text_color(colors.text)
|
||||
.child(self.name.clone())
|
||||
}
|
||||
}
|
||||
|
||||
impl<E: AppEngine> EventEmitter<PanelEvent> for EffectLibraryPanel<E> {}
|
||||
|
||||
impl<E: AppEngine> DockPanel for EffectLibraryPanel<E> {
|
||||
|
||||
Reference in New Issue
Block a user