From 833d1f7d94b71afbc1ad3f4080c2a3010b2fa8f0 Mon Sep 17 00:00:00 2001 From: itsmattkc Date: Sun, 17 Nov 2019 13:49:40 +0900 Subject: [PATCH] fixed bug where slider widget would signal that it had changed twice When typing a slider value, it would always signal that it had changed twice. This is obviously unnecessary and is fixed in this commit. --- app/widget/slider/sliderbase.cpp | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/app/widget/slider/sliderbase.cpp b/app/widget/slider/sliderbase.cpp index d63470d9e..53b5442ed 100644 --- a/app/widget/slider/sliderbase.cpp +++ b/app/widget/slider/sliderbase.cpp @@ -244,16 +244,16 @@ void SliderBase::LineEditConfirmed() break; } + // Ensure editor doesn't signal that the focus is lost + editor_->blockSignals(true); + if (is_valid) { SetValue(test_val); - emit ValueChanged(value_); - setCurrentWidget(label_); - } else { - // Ensure the editor focusing out when the messagebox appears does not cause another messagebox - editor_->blockSignals(true); + emit ValueChanged(value_); + } else { QMessageBox::critical(this, tr("Invalid Value"), tr("The entered value is not valid for this field."), @@ -261,9 +261,9 @@ void SliderBase::LineEditConfirmed() // Refocus editor editor_->setFocus(); - - editor_->blockSignals(false); } + + editor_->blockSignals(false); } void SliderBase::LineEditCancelled()