From 82df30586d0ac1d24ce3fb6713817a70b61bbf06 Mon Sep 17 00:00:00 2001
From: itsmattkc <itsmattkc@gmail.com>
Date: Wed, 29 Dec 2021 00:12:23 -0800
Subject: [PATCH] correctly handle unicode args on win32

Fixes #1810
---
 CMakeLists.txt                       |  4 +++-
 app/common/commandlineparser.cpp     |  8 ++++----
 app/common/commandlineparser.h       |  2 +-
 app/main.cpp                         | 18 +++++++++++++++++-
 app/window/mainwindow/mainwindow.cpp |  2 +-
 5 files changed, 26 insertions(+), 8 deletions(-)

diff --git a/CMakeLists.txt b/CMakeLists.txt
index e8c28db2a..67de32ebf 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -162,7 +162,9 @@ else()
   endif()
 endif()
 
-if (APPLE)
+if (WIN32)
+  list(APPEND OLIVE_DEFINITIONS "-DUNICODE -D_UNICODE")
+elseif (APPLE)
   list(APPEND OLIVE_LIBRARIES "-framework IOKit")
 elseif(UNIX)
   list(APPEND OLIVE_LIBRARIES Qt5::DBus)
diff --git a/app/common/commandlineparser.cpp b/app/common/commandlineparser.cpp
index 882ffcf24..150bdc244 100644
--- a/app/common/commandlineparser.cpp
+++ b/app/common/commandlineparser.cpp
@@ -52,16 +52,16 @@ const CommandLineParser::PositionalArgument *CommandLineParser::AddPositionalArg
   return a;
 }
 
-void CommandLineParser::Process(int argc, char **argv)
+void CommandLineParser::Process(const QVector<QString> &argv)
 {
   int positional_index = 0;
 
-  for (int i=1; i<argc; i++) {
+  for (int i=1; i<argv.size(); i++) {
     if (argv[i][0] == '-') {
       // Must be an option
 
       // Skip past first dashes
-      const char* arg_basename = &argv[i][1];
+      QString arg_basename = argv[i].mid(1);
 
       bool matched_known = false;
 
@@ -73,7 +73,7 @@ void CommandLineParser::Process(int argc, char **argv)
             // Flag discovered!
             o.option->Set();
 
-            if (o.takes_arg && i+1 < argc) {
+            if (o.takes_arg && i+1 < argv.size()) {
               o.option->SetSetting(argv[i+1]);
               i++;
             }
diff --git a/app/common/commandlineparser.h b/app/common/commandlineparser.h
index 7d131f357..4b32a9134 100644
--- a/app/common/commandlineparser.h
+++ b/app/common/commandlineparser.h
@@ -91,7 +91,7 @@ public:
 
   const PositionalArgument* AddPositionalArgument(const QString& name, const QString& description, bool required = false);
 
-  void Process(int argc, char** argv);
+  void Process(const QVector<QString> &argv);
 
   void PrintHelp(const char* filename);
 
diff --git a/app/main.cpp b/app/main.cpp
index 8a21126ff..7e729216f 100644
--- a/app/main.cpp
+++ b/app/main.cpp
@@ -71,6 +71,22 @@ int main(int argc, char *argv[])
   // Parse command line arguments
   //
 
+  QVector<QString> args;
+#if defined(_WIN32) && defined(UNICODE)
+  int wargc;
+  LPWSTR *wargv = CommandLineToArgvW(GetCommandLineW(), &wargc);
+  args.resize(wargc);
+  for (int i=0; i<wargc; i++) {
+    args[i] = QString::fromWCharArray(wargv[i]);
+  }
+  LocalFree(wargv);
+#else
+  args.resize(argc);
+  for (int i=0; i<argc; i++) {
+    args[i] = QString::fromLocal8Bit(argv[i]);
+  }
+#endif
+
   olive::Core::CoreParams startup_params;
 
   CommandLineParser parser;
@@ -130,7 +146,7 @@ int main(int argc, char *argv[])
   // Hidden crash option for debugging the crash handling
   auto crash_option = parser.AddOption({QStringLiteral("-crash")}, QString(), true, QString(), true);
 
-  parser.Process(argc, argv);
+  parser.Process(args);
 
   if (help_option->IsSet()) {
     // Show help
diff --git a/app/window/mainwindow/mainwindow.cpp b/app/window/mainwindow/mainwindow.cpp
index 8f1ace9ef..142058139 100644
--- a/app/window/mainwindow/mainwindow.cpp
+++ b/app/window/mainwindow/mainwindow.cpp
@@ -47,7 +47,7 @@ MainWindow::MainWindow(QWidget *parent) :
 
 #ifdef Q_OS_WINDOWS
   // Set up taskbar button progress bar (used for some modal tasks like exporting)
-  taskbar_btn_id_ = RegisterWindowMessage("TaskbarButtonCreated");
+  taskbar_btn_id_ = RegisterWindowMessage(TEXT("TaskbarButtonCreated"));
   taskbar_interface_ = nullptr;
 #endif