From 827c9f93ccfef262fbf8b1cefad39595d656ebf9 Mon Sep 17 00:00:00 2001 From: itsmattkc Date: Tue, 24 Nov 2020 11:02:42 +1100 Subject: [PATCH] AudioVisualWaveform: implement same size check as AudioPlaybackCache to prevent index out of bounds crashes --- app/audio/audiovisualwaveform.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/app/audio/audiovisualwaveform.cpp b/app/audio/audiovisualwaveform.cpp index 2fc07b683..ec99aed9d 100644 --- a/app/audio/audiovisualwaveform.cpp +++ b/app/audio/audiovisualwaveform.cpp @@ -151,6 +151,10 @@ void AudioVisualWaveform::Shift(const rational &from, const rational &to) return; } + if (from_index > data_.size()) { + return; + } + if (from_index > to_index) { // Shifting backwards <- int copy_sz = data_.size() - from_index;