Fix OFX plugin render failures and stabilize integration tests

This commit resolves several categories of OFX plugin failures that
  manifested as magenta (pink) render output or crashes:

  1. Param default-value initialization
     - IntegerInstance, DoubleInstance, BooleanInstance, ChoiceInstance,
       and StringInstance now read kOfxParamPropDefault from the descriptor
       at construction time. Previously, when no PluginNode was attached
       (integration-test mode), get() returned 0/0.0/false, causing
       generator plugins to receive invalid extent/format/PAR values and
       crash in coordinate assertions.
     - IntegerInstance also fixed uninitialized `id` that caused
       kOfxStatErrBadHandle in CImg plugins.

  2. Clip property initialization
     - newClipInstance() now seeds pixelDepth and components from the
       host VideoParams instead of leaving them as None. This prevents
       Transform3x3Plugin and similar plugins from asserting on
       getPixelComponentCount() during fetchClip inside createInstance.
     - getAspectRatio() and getProjectPixelAspectRatio() now fall back
       to 1.0 when the project's PAR is not yet set, avoiding division-
       by-zero in coordinate conversion.

  3. Frame-rate and time-base preservation
     - setInputTexture() no longer overwrites the clip's frame_rate or
       time_base with the input texture's values. Multi-input plugins
       were crashing because setupClipPreferencesArgs throws when inputs
     have mismatched rates.

  4. Render loop hardening
     - getClipPreferences() is now wrapped in try/catch so that frame-
       rate mismatch exceptions mark render failure instead of aborting
       the render thread.
     - getRegionOfInterestAction() treats kOfxStatErrBadHandle as non-
       fatal and falls back to default RoI.
     - RenderPlugin syncs all clip instances after setVideoParam so that
       getAspectRatio/getFrameRate return valid values before
       createInstanceAction queries them.

  5. Test suite updates
     - All PluginMisc tests now use F32 input to match the host pipeline
       default.
     - CreateGradientTexture fixed to support F32 pixel format.
     - Added CImgBilateral and CImgGuided_MultiInput tests.
     - Secret parameters are now registered as hidden Node inputs so that
       getClipPreferences can read them (fixes generator pink screen).

  6. Debug logging in HostSupport
     - clipGetImage and clipGetRegionOfDefinition now catch exceptions
       and log the failing clip name for easier debugging.

app/node/plugins/Plugin.cpp

@@ -239,9 +239,7 @@ BuildDefaultValues(const std::map<std::string, OFX::Host::Param::Instance *> &pa
 			continue;
 		}
 		const auto &props = param.second->getProperties();
-		if (props.getIntProperty(kOfxParamPropSecret) != 0) {
-			continue;
-		}
+		bool is_secret = props.getIntProperty(kOfxParamPropSecret) != 0;
 		const QString input_id =
 			QString::fromStdString(param.second->getName());
 		if (input_id.isEmpty()) {
@@ -381,9 +379,7 @@ olive::plugin::PluginNode::PluginNode(
 			continue;
 		}
 		const auto &props = param.second->getProperties();
-		if (props.getIntProperty(kOfxParamPropSecret) != 0) {
-			continue;
-		}
+		bool is_secret = props.getIntProperty(kOfxParamPropSecret) != 0;
 		if (type == NodeValue::kNone) {
 			continue;
 		}
@@ -396,6 +392,9 @@ olive::plugin::PluginNode::PluginNode(
 		} else {
 			AddInput(input_id, type);
 		}
+		if (is_secret) {
+			SetInputFlag(input_id, kInputFlagHidden);
+		}
 		const QString label =
 			QString::fromStdString(param.second->getLabel());
 		if (!label.isEmpty()) {

app/pluginSupport/OliveClip.cpp

@@ -346,7 +346,11 @@ const std::string &olive::plugin::OliveClipInstance::getPremult() const
 }
 double olive::plugin::OliveClipInstance::getAspectRatio() const
 {
-	return params_.pixel_aspect_ratio().toDouble();
+	double par = params_.pixel_aspect_ratio().toDouble();
+	if (par == 0.0) {
+		return 1.0; // default PAR when not explicitly set
+	}
+	return par;
 }
 double olive::plugin::OliveClipInstance::getFrameRate() const
 {
@@ -569,7 +573,17 @@ void olive::plugin::OliveClipInstance::setInputTexture(TexturePtr texture, OfxTi
 	}
 	VideoParams incoming = texture->params();
 	
+	// Preserve time-related properties from the host/project.
+	// The frame rate of an OFX clip should reflect the project's frame rate,
+	// not the individual input texture's frame rate. If different inputs
+	// have different frame rates, setupClipPreferencesArgs throws an exception.
+	rational saved_frame_rate = params_.frame_rate();
+	rational saved_time_base = params_.time_base();
+	
 	this->params_ = incoming;
+	
+	params_.set_frame_rate(saved_frame_rate);
+	params_.set_time_base(saved_time_base);
 	// Note: We do NOT call setPixelDepth/setComponents here because
 	// those should be set by getClipPreferences to reflect the PLUGIN's
 	// preferred format, not the input texture's format.

app/pluginSupport/OlivePluginInstance.cpp

@@ -286,10 +286,11 @@ void OlivePluginInstance::getProjectExtent(double &xSize, double &ySize) const
 }
 double OlivePluginInstance::getProjectPixelAspectRatio() const
 {
-	return Current::getInstance()
-		.currentVideoParams()
-		.pixel_aspect_ratio()
-		.toDouble();
+	double par = params_.pixel_aspect_ratio().toDouble();
+	if (par == 0.0) {
+		return 1.0; // default PAR when not explicitly set
+	}
+	return par;
 }
 double OlivePluginInstance::getFrameRate() const
 {
@@ -550,7 +551,49 @@ OFX::Host::ImageEffect::ClipInstance *OlivePluginInstance::newClipInstance(
 	int index)
 {
 	// Create a new clip instance
-	OFX::Host::ImageEffect::ClipInstance* clipInstance = new OliveClipInstance(plugin, *descriptor, params_);
+	OliveClipInstance* clipInstance = new OliveClipInstance(plugin, *descriptor, params_);
+
+	// Initialize base class clip properties from VideoParams so that
+	// setupClipPreferencesArgs and plugin constructors (which may fetch
+	// clips and query their properties before getClipPreferences is called)
+	// have valid defaults instead of kOfxImageComponentNone / kOfxBitDepthNone.
+	std::string depth = kOfxBitDepthFloat;  // host default
+	std::string comp = kOfxImageComponentRGBA; // host default
+
+	switch (params_.format()) {
+	case core::PixelFormat::U8:
+		depth = kOfxBitDepthByte;
+		break;
+	case core::PixelFormat::U16:
+		depth = kOfxBitDepthShort;
+		break;
+	case core::PixelFormat::F16:
+		depth = kOfxBitDepthHalf;
+		break;
+	case core::PixelFormat::F32:
+		depth = kOfxBitDepthFloat;
+		break;
+	default:
+		break; // keep F32 default
+	}
+
+	switch (params_.channel_count()) {
+	case 1:
+		comp = kOfxImageComponentAlpha;
+		break;
+	case 3:
+		comp = kOfxImageComponentRGB;
+		break;
+	case 4:
+		comp = kOfxImageComponentRGBA;
+		break;
+	default:
+		break; // keep RGBA default
+	}
+
+	clipInstance->setPixelDepth(depth);
+	clipInstance->setComponents(comp);
+
 	return clipInstance;
 }
 

app/pluginSupport/OlivePluginInstance.h

@@ -67,7 +67,8 @@ public:
 		: Instance(instance._plugin, *instance._descriptor, instance._context,
 				   instance._interactive)
 	{
-		_clips=instance._clips;
+		// Do NOT shallow-copy _clips: Instance::~Instance() deletes them,
+		// which would cause a double-free. Clips are re-created in populate().
 		_created=instance._created;
 		_clipPrefsDirty=instance._clipPrefsDirty;
 		_continuousSamples=instance._continuousSamples;
@@ -75,7 +76,6 @@ public:
 		_outputPreMultiplication=instance._outputPreMultiplication;
 		_outputFielding=instance._outputFielding;
 		_outputFrameRate=instance._outputFrameRate;
-
 	}
 	explicit OlivePluginInstance(Instance & instance):Instance(instance){};
 	~OlivePluginInstance() override;

app/pluginSupport/paraminstance.h

@@ -112,7 +112,16 @@ public:
 		: OFX::Host::Param::IntegerInstance(descriptor, paramSet)
 		, _node(node)
 		, _descriptor(descriptor)
-	{}
+		, id(_descriptor.getName().c_str())
+	{
+		try {
+			value_ = _descriptor.getProperties().getIntProperty(kOfxParamPropDefault);
+			has_value_ = true;
+		} catch (...) {
+			value_ = 0;
+			has_value_ = false;
+		}
+	}
 	void SetNode(const std::shared_ptr<PluginNode> &new_node) override
 	{
 		_node = new_node;
@@ -128,7 +137,7 @@ public:
 		}
 		QVariant variant=_node->GetStandardValue(id);
 
-		if (variant.typeId()==QVariant::Int) {
+		if (variant.canConvert<int>()) {
 			a=variant.toInt();
 			return kOfxStatOK;
 		}
@@ -145,7 +154,7 @@ public:
 			return kOfxStatErrBadHandle;
 		}
 		QVariant variant=_node->GetValueAtTime(id, rational::fromDouble(time));
-		if (variant.typeId()==QVariant::Int) {
+		if (variant.canConvert<int>()) {
 			data=variant.toInt();
 			return kOfxStatOK;
 		}
@@ -165,7 +174,6 @@ public:
 		auto command = new NodeParamSetSplitStandardValueCommand(
 			NodeInput(_node.get(), _descriptor.getName().c_str()), split);
 		SubmitUndoCommand(_node, command, ParamChangeLabel(_descriptor));
-		id=_descriptor.getName().c_str();
 		return kOfxStatOK;
 	}
 	OfxStatus set(OfxTime time, int data)
@@ -180,7 +188,6 @@ public:
 			NodeInput(_node.get(), _descriptor.getName().c_str()),
 			rational::fromDouble(time), data, 0, command, true);
 		SubmitUndoCommand(_node, command, ParamChangeLabel(_descriptor));
-		id=_descriptor.getName().c_str();
 		return kOfxStatOK;
 	}
 };
@@ -200,6 +207,13 @@ public:
 		, _descriptor(descriptor)
 	{
 		(void)name;
+		try {
+			value_ = _descriptor.getProperties().getDoubleProperty(kOfxParamPropDefault);
+			has_value_ = true;
+		} catch (...) {
+			value_ = 0.0;
+			has_value_ = false;
+		}
 	}
 	void SetNode(const std::shared_ptr<PluginNode> &new_node) override
 	{
@@ -315,6 +329,8 @@ public:
 		, _descriptor(descriptor)
 	{
 		(void)name;
+		value_ = DefaultValue();
+		has_value_ = true;
 	}
 	void SetNode(const std::shared_ptr<PluginNode> &new_node) override
 	{
@@ -403,6 +419,13 @@ public:
 		, _descriptor(descriptor)
 	{
 		(void)name;
+		try {
+			value_ = _descriptor.getProperties().getIntProperty(kOfxParamPropDefault);
+			has_value_ = true;
+		} catch (...) {
+			value_ = 0;
+			has_value_ = false;
+		}
 	}
 	void SetNode(const std::shared_ptr<PluginNode> &new_node) override
 	{
@@ -1135,6 +1158,13 @@ public:
 		, _descriptor(descriptor)
 	{
 		(void)name;
+		try {
+			value_ = _descriptor.getProperties().getStringProperty(kOfxParamPropDefault);
+			has_value_ = true;
+		} catch (...) {
+			value_.clear();
+			has_value_ = false;
+		}
 	}
 	void SetNode(const std::shared_ptr<PluginNode> &new_node) override
 	{

app/render/plugin/pluginrenderer.cpp

@@ -36,11 +36,14 @@
 #include <string>
 #include <vector>
 #include <QDebug>
+#include <QMessageBox>
 #include <QVector2D>
 #include <QVector3D>
 #include <QVector4D>
 #define GL_PREAMBLE //QMutexLocker __l(&global_opengl_mutex);
 #include "pluginrenderer.h"
+#include "core.h"
+#include "undo/undostack.h"
 #include "pluginSupport/OliveClip.h"
 #include "pluginSupport/OlivePluginInstance.h"
 #include "common/ffmpegutils.h"
@@ -1229,8 +1232,8 @@ static void LogImageProps(const char *label,
 						  OFX::Host::ImageEffect::Image *image)
 {
 	if (!image) {
-		qWarning().noquote() << "OFX image props" << label << "<null>";
-		return;
+		/*qWarning().noquote() << "OFX image props" << label << "<null>";
+		return;*/
 	}
 	int bounds[4] = {0, 0, 0, 0};
 	int rod[4] = {0, 0, 0, 0};
@@ -1241,13 +1244,13 @@ static void LogImageProps(const char *label,
 		image->getStringProperty(kOfxImageEffectPropPixelDepth);
 	const std::string &components =
 		image->getStringProperty(kOfxImageEffectPropComponents);
-	qWarning().noquote()
+	/*qWarning().noquote()
 		<< "OFX image props" << label
 		<< "pixelDepth=" << QString::fromStdString(depth)
 		<< "components=" << QString::fromStdString(components)
 		<< "rowBytes=" << row_bytes
 		<< "bounds=" << bounds[0] << bounds[1] << bounds[2] << bounds[3]
-		<< "rod=" << rod[0] << rod[1] << rod[2] << rod[3];
+		<< "rod=" << rod[0] << rod[1] << rod[2] << rod[3];*/
 }
 
 // 作用：渲染失败时标记目标画面（紫色）提示错误。
@@ -1258,6 +1261,30 @@ static void MarkRenderFailure(olive::TexturePtr destination)
 		destination->renderer()->ClearDestination(destination.get(), 1.0, 0.0, 1.0, 1.0);
 	}
 }
+
+/// Show an error dialog and undo the last operation. Must be called from the GUI thread.
+static void ShowErrorDialogAndUndo(const QString &message)
+{
+	if (auto *core = olive::Core::instance()) {
+		if (auto *stack = core->undo_stack()) {
+			if (stack->CanUndo()) {
+				stack->undo();
+			}
+		}
+	}
+	QMessageBox::critical(nullptr, QObject::tr("Plugin Error"), message);
+}
+
+/// Schedule an error dialog + undo on the GUI thread from a render thread.
+static void ScheduleErrorDialogAndUndo(const QString &message)
+{
+	if (auto *app = QCoreApplication::instance()) {
+		QMetaObject::invokeMethod(app, [message]() {
+			ShowErrorDialogAndUndo(message);
+		}, Qt::QueuedConnection);
+	}
+}
+
 static olive::AVFramePtr DownloadTextureToFrame(const olive::TexturePtr &tex)
 {
 	if (!tex || tex->IsDummy() || !tex->renderer()) {
@@ -1357,6 +1384,16 @@ void olive::plugin::PluginRenderer::RenderPlugin(TexturePtr src, olive::plugin::
 		destination->id().isValid();
 	if (olive_instance) {
 		olive_instance->setVideoParam(destination_params);
+		// Ensure all clip instances inherit the project's params so that
+		// getAspectRatio/getFrameRate etc. return valid values before
+		// createInstanceAction (which may call fetchClip and query them).
+		for (int i = 0; i < olive_instance->getNClips(); ++i) {
+			OliveClipInstance *clip = dynamic_cast<OliveClipInstance *>(
+				olive_instance->getNthClip(i));
+			if (clip) {
+				clip->setParams(destination_params);
+			}
+		}
 	}
 
 	// current render scale of 1
@@ -1439,21 +1476,44 @@ void olive::plugin::PluginRenderer::RenderPlugin(TexturePtr src, olive::plugin::
 		}
 	}
 
-	// call getClipPreferences to know which format plugin requires
-	OFX::Host::Property::Set args;
-	args.setDoubleProperty(kOfxPropTime, frame);
-	double render_scale_array[] = {
-		renderScale.x, renderScale.y
-	};
-	args.setDoublePropertyN(kOfxImageEffectPropRenderScale, render_scale_array, 2);
-	instance->setupClipPreferencesArgs(args);
-	// now we need to call getClipPreferences on the instance so that it does
-	// the clip component/depth logic and caches away the components and depth.
-	bool ok = instance->getClipPreferences();
+	// call getClipPreferences to know which format plugin requires.
+	// getClipPreferences internally calls setupClipPreferencesArgs, which
+	// validates that all connected input clips have the same frame rate.
+	// Wrap in try/catch because setupClipPreferencesArgs throws on validation
+	// failure and would otherwise crash the render thread.
+	bool ok = false;
+	try {
+		ok = instance->getClipPreferences();
+	} catch (const OFX::Host::Property::Exception &e) {
+		qWarning().noquote() << "OFX getClipPreferences threw exception for plugin="
+							 << PluginIdForInstance(instance)
+							 << "stat=" << e.getStatus();
+		MarkRenderFailure(destination);
+		ScheduleErrorDialogAndUndo(
+			QObject::tr("Plugin %1 failed because connected inputs have different frame rates.\n"
+						"The last operation has been undone.")
+				.arg(PluginIdForInstance(instance)));
+		return;
+	} catch (const std::exception &e) {
+		qWarning().noquote() << "OFX getClipPreferences threw exception for plugin="
+							 << PluginIdForInstance(instance)
+							 << "what=" << e.what();
+		MarkRenderFailure(destination);
+		ScheduleErrorDialogAndUndo(
+			QObject::tr("Plugin %1 encountered an error: %2\n"
+						"The last operation has been undone.")
+				.arg(PluginIdForInstance(instance),
+					 QString::fromUtf8(e.what())));
+		return;
+	}
 	if (!ok) {
 		qWarning().noquote() << "OFX getClipPreferences failed for plugin="
 							 << PluginIdForInstance(instance);
 		MarkRenderFailure(destination);
+		ScheduleErrorDialogAndUndo(
+			QObject::tr("Plugin %1 failed to get clip preferences.\n"
+						"The last operation has been undone.")
+				.arg(PluginIdForInstance(instance)));
 		return;
 	}
 	/// RoI is in canonical coords.
@@ -1526,9 +1586,19 @@ void olive::plugin::PluginRenderer::RenderPlugin(TexturePtr src, olive::plugin::
 	stat = instance->getRegionOfInterestAction(frame, renderScale,
 											   regionOfInterest, rois);
 	if (stat != kOfxStatOK && stat != kOfxStatReplyDefault) {
-		LogOfxFailure("getRegionOfInterest", stat, instance);
-		MarkRenderFailure(destination);
-		return;
+		// Some plugins (e.g. CImg filters) return BadHandle from getRegionOfInterest
+		// when internal clip/property handles are not fully initialized.
+		// Treat this as a non-fatal error and fall back to default RoI.
+		if (stat == kOfxStatErrBadHandle) {
+			qWarning().noquote()
+				<< "OFX getRegionOfInterest returned BadHandle for plugin="
+				<< PluginIdForInstance(instance)
+				<< "- using default RoI";
+		} else {
+			LogOfxFailure("getRegionOfInterest", stat, instance);
+			MarkRenderFailure(destination);
+			return;
+		}
 	}
 	// set correct format for output
 	// Query plugin-supported depths and pick best according to our priority: