From 7ea8c52c78dbe180144bff698cc448fc668520d9 Mon Sep 17 00:00:00 2001 From: itsmattkc Date: Wed, 15 Apr 2020 02:52:24 +1000 Subject: [PATCH] /nodeparamviewwidgetbridge: block combobox signals when updating from node Prevents unnecessary re-caching caused by the combobox signalling that its value has changed when we're really just setting the value that the node already has. --- app/widget/nodeparamview/nodeparamviewwidgetbridge.cpp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/app/widget/nodeparamview/nodeparamviewwidgetbridge.cpp b/app/widget/nodeparamview/nodeparamviewwidgetbridge.cpp index d66a50e9a..52a46d376 100644 --- a/app/widget/nodeparamview/nodeparamviewwidgetbridge.cpp +++ b/app/widget/nodeparamview/nodeparamviewwidgetbridge.cpp @@ -479,7 +479,10 @@ void NodeParamViewWidgetBridge::UpdateWidgetValues() } case NodeParam::kCombo: { - static_cast(widgets_.first())->setCurrentIndex(input_->get_value_at_time(node_time).toInt()); + QComboBox* cb = static_cast(widgets_.first()); + cb->blockSignals(true); + cb->setCurrentIndex(input_->get_value_at_time(node_time).toInt()); + cb->blockSignals(false); break; } case NodeParam::kFootage: