From 96074d3f3a111799bb716608705371dc310ff6de Mon Sep 17 00:00:00 2001 From: lightyear15 Date: Fri, 8 Nov 2019 19:25:47 +0100 Subject: [PATCH] timerange quick refactor std::swap can saves some lines of code, and less code means less to maintain --- app/common/timerange.cpp | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/app/common/timerange.cpp b/app/common/timerange.cpp index dabcecfac..8813d6be5 100644 --- a/app/common/timerange.cpp +++ b/app/common/timerange.cpp @@ -1,5 +1,7 @@ #include "timerange.h" +#include + TimeRange::TimeRange(const rational &in, const rational &out) : in_(in), out_(out) @@ -54,10 +56,9 @@ bool TimeRange::operator>(const TimeRange &r) const void TimeRange::normalize() { // If `out` is earlier than `in`, swap them - if (out_ < in_) { - rational temp = in_; - in_ = out_; - out_ = temp; + if (out_ < in_) + { + std::swap(out_, in_); } // Calculate length