From afa89ff452bf980b6a2e70e3be30e3b2b39d6b9c Mon Sep 17 00:00:00 2001 From: itsmattkc Date: Mon, 11 Mar 2019 03:40:44 +1100 Subject: [PATCH] added comment regarding blending shaders --- project/effectloaders.cpp | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/project/effectloaders.cpp b/project/effectloaders.cpp index 2e1f2d9e9..8f6f97465 100644 --- a/project/effectloaders.cpp +++ b/project/effectloaders.cpp @@ -372,6 +372,12 @@ void GenerateBlendingShader() } // Write the main() function for the shader + // + // NOTE/FIXME: Unfortunately the current blending shaders (from https://github.com/jamieowen/glsl-blend) all seem to + // be calculated for unassociated alpha, while Olive's internal pipeline largely functions in associated alpha. + // Therefore for the blending shaders to work as expected, the alpha has to be unassociated at this stage. + // Naturally, this sucks, but I'm not entirely sure what the solution is apart from rewriting the blending shaders + // or maybe finding a new library. olive::generated_blending_shader.append("\n return blend;\n" // default return value "}\n"