From 7281806c386febe70b90bfe6fd8c05e80a4f10b7 Mon Sep 17 00:00:00 2001 From: Thomas Wilshaw Date: Fri, 16 Oct 2020 22:30:54 +0100 Subject: [PATCH] Fix #1271 Duplicate Keyframed Node When nodes with keyframes were copied their parent NodeInput was not set properly leading to a segfult when key->GetParent was called in KeyframeViewItem::UpdatePos(). This fix properly sets parent_ when keys are copied. --- app/node/input.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/app/node/input.cpp b/app/node/input.cpp index 2c5a9d3eb..181b9e7e0 100644 --- a/app/node/input.cpp +++ b/app/node/input.cpp @@ -1075,7 +1075,9 @@ void NodeInput::CopyValues(NodeInput *source, NodeInput *dest, bool include_conn for (int i=0;ikeyframe_tracks_.size();i++) { dest->keyframe_tracks_[i].clear(); foreach (NodeKeyframePtr key, source->keyframe_tracks_.at(i)) { - dest->keyframe_tracks_[i].append(key->copy()); + NodeKeyframePtr key_copy = key->copy(); + key_copy->set_parent(dest); + dest->keyframe_tracks_[i].append(key_copy); } }