oak-team/oak-editor
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: initialize EncodingParams enum members

Browse Source 
format_, video_codec_, audio_codec_, subtitle_sidecar_fmt_ and
subtitles_codec_ were left indeterminate by the constructor; reading
them before the corresponding Enable* call was UB. Initialize to the
kFormatCount/kCodecCount invalid sentinels.
This commit is contained in:
Mike-Solar
2026-07-17 17:04:39 +08:00
parent ba55123b13
commit 7223900b6d
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/codec/encoder.h
+5 -5
View File
@@ -268,10 +268,10 @@ private:
bool LoadV1(QXmlStreamReader *reader);
QString filename_;
ExportFormat::Format format_;
ExportFormat::Format format_ = ExportFormat::kFormatCount;
bool video_enabled_;
ExportCodec::Codec video_codec_;
ExportCodec::Codec video_codec_ = ExportCodec::kCodecCount;
VideoParams video_params_;
QHash<QString, QString> video_opts_;
int64_t video_bit_rate_;
@@ -284,14 +284,14 @@ private:
ColorTransform color_transform_;
bool audio_enabled_;
ExportCodec::Codec audio_codec_;
ExportCodec::Codec audio_codec_ = ExportCodec::kCodecCount;
AudioParams audio_params_;
int64_t audio_bit_rate_;
bool subtitles_enabled_;
bool subtitles_are_sidecar_;
ExportFormat::Format subtitle_sidecar_fmt_;
ExportCodec::Codec subtitles_codec_;
ExportFormat::Format subtitle_sidecar_fmt_ = ExportFormat::kFormatCount;
ExportCodec::Codec subtitles_codec_ = ExportCodec::kCodecCount;
rational export_length_;
VideoScalingMethod video_scaling_method_;