oak-team/oak-editor
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

build/ci: green builds and tests on all three platforms

Browse Source 
Compiler hygiene (all platforms):
- Silence warnings across the tree: missing override, -Wreorder ctor
  init, -Wshadow, -Wsign-compare, missing switch cases, unused
  functions/captures, Qt 6.11 deprecations (QMouseEvent/QDropEvent
  accessors, qAsConst, Q_FOREACH over non-shared containers,
  AA_UseHighDpiPixmaps) and the .bak/ backup tree removal.
- Fix regressions from the cleanup: missing clip decls in
  capi/timeline.cpp, plugin.cpp rename fallout, panel setFocus
  ambiguity, QGraphicsItem::pos vs event->position(), duplicate
  k_push_button case, boolean test variable.

Windows:
- Qt portability: CommandLineParser is_set/add_option, QTimeZone
  systemTimeZone (QTimeZone::LocalTime is 6.11-only), k_progress_* enum.
- Linking: stop adding oakengine to OLIVE_LIBRARIES (import lib plus
  oakengine-obj caused multiple definitions); add OAKENGINE_STATIC so
  internal consumers no longer reference __imp_* stubs.
- oakengine.ver: export olive::Renderer typeinfo so liboakgl.so can be
  dlopened (Linux), DynamicRenderer no longer dlcloses backend libraries
  (crash in RenderManager's dtor calling into unmapped memory).
- OTIO runtime: copy DLLs next to every binary on Windows instead of
  relying on PATH (0xc0000135 in gtest discovery).
- Headless GL: the runner only has GDI OpenGL 1.1, killing every render
  worker. Deploy Mesa llvmpipe as opengl32sw.dll (Qt's software-GL
  channel) with QT_OPENGL=software, and let QT_OPENGL override the
  AA_UseDesktopOpenGL default. ExportTask fails fast after 8 consecutive
  undelivered frames instead of segfaulting or grinding forever;
  FFmpegEncoder::write_frame tolerates null frames.
- Tests: GetTempPathA+PID temp dirs, GetLongPathNameA for 8.3 names,
  forward-slash normalization when comparing project filenames.

Linux:
- Install libshaderc-dev so oakvulkan compiles GLSL (Vulkan tests).
- Accept UNORM floor-or-round (63/64) in the blit ping-pong test.
- Skip MainWindow construction test on the offscreen QPA (cannot paint
  QOpenGLWidget).

Also: oak_cli_transcode gets a 300s ctest timeout, worker logs GL
context version and LoadGraph/render_frame stages, and
docs/plans/eliminate-event-bridge-issues.md (English translation).
This commit is contained in:
Mike-Solar
2026-08-04 21:34:31 +08:00
parent 5006382790
commit 712badbaa7
127 changed files with 826 additions and 8498 deletions
Download Patch File Download Diff File Expand all files Collapse all files
engine/pluginSupport/image.cpp
+3
View File
@@ -37,8 +37,11 @@ static const char *pixel_depth_to_ofx(core::PixelFormat format)
return kOfxBitDepthShort;
case core::PixelFormat::f16:
return kOfxBitDepthHalf;
default:
break;
case core::PixelFormat::f32:
return kOfxBitDepthFloat;
case core::PixelFormat::u10:
case core::PixelFormat::invalid:
case core::PixelFormat::count:
break;
engine/pluginSupport/olivehost.h
+6 -6
View File
@@ -79,18 +79,18 @@ public:
makeDescriptor(const std::string &bundle_path,
OFX::Host::ImageEffect::ImageEffectPlugin *plugin) override;
/// vmessage
virtual OfxStatus vmessage(const char *type, const char *id,
const char *format, va_list args);
OfxStatus vmessage(const char *type, const char *id,
const char *format, va_list args) override;
/// vmessage
virtual OfxStatus setPersistentMessage(const char *type, const char *id,
const char *format, va_list args);
OfxStatus setPersistentMessage(const char *type, const char *id,
const char *format, va_list args) override;
/// vmessage
virtual OfxStatus clearPersistentMessage();
OfxStatus clearPersistentMessage() override;
#ifdef OFX_SUPPORTS_OPENGLRENDER
/// @see OfxImageEffectOpenGLRenderSuiteV1.flushResources()
virtual OfxStatus flushOpenGLResources() const
virtual OfxStatus flushOpenGLResources() const override
{
return kOfxStatFailed;
};
engine/pluginSupport/oliveplugininstance.h
+3 -3
View File
@@ -209,13 +209,13 @@ public:
/// get the current time on the timeline. This is not necessarily the same
/// time as being passed to an action (eg render)
virtual double timeLineGetTime();
double timeLineGetTime() override;
/// set the timeline to a specific time
virtual void timeLineGotoTime(double t);
void timeLineGotoTime(double t) override;
/// get the first and last times available on the effect's timeline
virtual void timeLineGetBounds(double &t1, double &t2);
void timeLineGetBounds(double &t1, double &t2) override;
void setCustomInArgs(const std::string &action,
OFX::Host::Property::Set &in_args) override;
engine/pluginSupport/paraminstance.h
+50 -50
View File
@@ -132,7 +132,7 @@ public:
{
node_ = new_node;
}
OfxStatus get(int &a)
OfxStatus get(int &a) override
{
if (!node_) {
std::lock_guard<std::mutex> lock(no_node_mutex_);
@@ -151,7 +151,7 @@ public:
a = 0;
return kOfxStatErrValue;
}
OfxStatus get(OfxTime time, int &data)
OfxStatus get(OfxTime time, int &data) override
{
if (!node_) {
std::lock_guard<std::mutex> lock(no_node_mutex_);
@@ -170,7 +170,7 @@ public:
data = 0;
return kOfxStatErrValue;
}
OfxStatus set(int data)
OfxStatus set(int data) override
{
if (!node_) {
std::lock_guard<std::mutex> lock(no_node_mutex_);
@@ -186,7 +186,7 @@ public:
submit_undo_command(node_, command, param_change_label(descriptor_));
return kOfxStatOK;
}
OfxStatus set(OfxTime time, int data)
OfxStatus set(OfxTime time, int data) override
{
if (!node_) {
std::lock_guard<std::mutex> lock(no_node_mutex_);
@@ -233,7 +233,7 @@ public:
{
node_ = new_node;
}
OfxStatus get(double &data)
OfxStatus get(double &data) override
{
if (!node_) {
data = has_value_ ? value_ : 0.0;
@@ -253,7 +253,7 @@ public:
data = 0.0;
return kOfxStatErrValue;
}
OfxStatus get(OfxTime time, double &data)
OfxStatus get(OfxTime time, double &data) override
{
if (!node_) {
data = has_value_ ? value_ : 0.0;
@@ -273,7 +273,7 @@ public:
data = 0.0;
return kOfxStatErrValue;
}
OfxStatus set(double data)
OfxStatus set(double data) override
{
if (!node_) {
value_ = data;
@@ -293,7 +293,7 @@ public:
submit_undo_command(node_, command, param_change_label(descriptor_));
return kOfxStatOK;
}
OfxStatus set(OfxTime time, double data)
OfxStatus set(OfxTime time, double data) override
{
if (!node_) {
value_ = data;
@@ -313,11 +313,11 @@ public:
submit_undo_command(node_, command, param_change_label(descriptor_));
return kOfxStatOK;
}
OfxStatus derive(OfxTime, double &)
OfxStatus derive(OfxTime, double &) override
{
return kOfxStatErrUnsupported;
}
OfxStatus integrate(OfxTime, OfxTime, double &)
OfxStatus integrate(OfxTime, OfxTime, double &) override
{
return kOfxStatErrUnsupported;
}
@@ -352,7 +352,7 @@ public:
{
node_ = new_node;
}
OfxStatus get(bool &data)
OfxStatus get(bool &data) override
{
if (!node_) {
data = has_value_ ? value_ : false;
@@ -367,7 +367,7 @@ public:
data = default_value();
return kOfxStatOK;
}
OfxStatus get(OfxTime time, bool &data)
OfxStatus get(OfxTime time, bool &data) override
{
if (!node_) {
data = has_value_ ? value_ : false;
@@ -392,7 +392,7 @@ public:
data = default_value();
return kOfxStatOK;
}
OfxStatus set(bool data)
OfxStatus set(bool data) override
{
if (!node_) {
value_ = data;
@@ -406,7 +406,7 @@ public:
submit_undo_command(node_, command, param_change_label(descriptor_));
return kOfxStatOK;
}
OfxStatus set(OfxTime time, bool data)
OfxStatus set(OfxTime time, bool data) override
{
if (!node_) {
value_ = data;
@@ -452,7 +452,7 @@ public:
{
node_ = new_node;
}
OfxStatus get(int &data)
OfxStatus get(int &data) override
{
if (!node_) {
data = has_value_ ? value_ : 0;
@@ -467,7 +467,7 @@ public:
data = 0;
return kOfxStatErrValue;
}
OfxStatus get(OfxTime time, int &data)
OfxStatus get(OfxTime time, int &data) override
{
if (!node_) {
data = has_value_ ? value_ : 0;
@@ -482,7 +482,7 @@ public:
data = 0;
return kOfxStatErrValue;
}
OfxStatus set(int data)
OfxStatus set(int data) override
{
if (!node_) {
value_ = data;
@@ -496,7 +496,7 @@ public:
submit_undo_command(node_, command, param_change_label(descriptor_));
return kOfxStatOK;
}
OfxStatus set(OfxTime time, int data)
OfxStatus set(OfxTime time, int data) override
{
if (!node_) {
value_ = data;
@@ -534,7 +534,7 @@ public:
{
node_ = new_node;
}
OfxStatus get(double &r, double &g, double &b, double &a)
OfxStatus get(double &r, double &g, double &b, double &a) override
{
if (!node_) {
if (has_value_) {
@@ -557,7 +557,7 @@ public:
a = static_cast<double>(c.alpha());
return kOfxStatOK;
}
OfxStatus get(OfxTime time, double &r, double &g, double &b, double &a)
OfxStatus get(OfxTime time, double &r, double &g, double &b, double &a) override
{
if (!node_) {
if (has_value_) {
@@ -581,7 +581,7 @@ public:
a = static_cast<double>(c.alpha());
return kOfxStatOK;
}
OfxStatus set(double r, double g, double b, double a)
OfxStatus set(double r, double g, double b, double a) override
{
if (!node_) {
value_[0] = r;
@@ -599,7 +599,7 @@ public:
submit_undo_command(node_, command, param_change_label(descriptor_));
return kOfxStatOK;
}
OfxStatus set(OfxTime time, double r, double g, double b, double a)
OfxStatus set(OfxTime time, double r, double g, double b, double a) override
{
if (!node_) {
value_[0] = r;
@@ -646,7 +646,7 @@ public:
{
node_ = new_node;
}
OfxStatus get(double &r, double &g, double &b)
OfxStatus get(double &r, double &g, double &b) override
{
if (!node_) {
if (has_value_) {
@@ -667,7 +667,7 @@ public:
b = static_cast<double>(c.blue());
return kOfxStatOK;
}
OfxStatus get(OfxTime time, double &r, double &g, double &b)
OfxStatus get(OfxTime time, double &r, double &g, double &b) override
{
if (!node_) {
if (has_value_) {
@@ -689,7 +689,7 @@ public:
b = static_cast<double>(c.blue());
return kOfxStatOK;
}
OfxStatus set(double r, double g, double b)
OfxStatus set(double r, double g, double b) override
{
if (!node_) {
value_[0] = r;
@@ -706,7 +706,7 @@ public:
submit_undo_command(node_, command, param_change_label(descriptor_));
return kOfxStatOK;
}
OfxStatus set(OfxTime time, double r, double g, double b)
OfxStatus set(OfxTime time, double r, double g, double b) override
{
if (!node_) {
value_[0] = r;
@@ -751,7 +751,7 @@ public:
{
node_ = new_node;
}
OfxStatus get(double &x, double &y)
OfxStatus get(double &x, double &y) override
{
if (!node_) {
if (has_value_) {
@@ -774,7 +774,7 @@ public:
}
return kOfxStatOK;
}
OfxStatus get(OfxTime time, double &x, double &y)
OfxStatus get(OfxTime time, double &x, double &y) override
{
if (!node_) {
if (has_value_) {
@@ -798,7 +798,7 @@ public:
}
return kOfxStatOK;
}
OfxStatus set(double x, double y)
OfxStatus set(double x, double y) override
{
if (!node_) {
value_[0] = x;
@@ -820,7 +820,7 @@ public:
submit_undo_command(node_, command, param_change_label(descriptor_));
return kOfxStatOK;
}
OfxStatus set(OfxTime time, double x, double y)
OfxStatus set(OfxTime time, double x, double y) override
{
if (!node_) {
value_[0] = x;
@@ -869,7 +869,7 @@ public:
{
node_ = new_node;
}
OfxStatus get(int &x, int &y)
OfxStatus get(int &x, int &y) override
{
if (!node_) {
if (has_value_) {
@@ -886,7 +886,7 @@ public:
y = static_cast<int>(vec.y());
return kOfxStatOK;
}
OfxStatus get(OfxTime time, int &x, int &y)
OfxStatus get(OfxTime time, int &x, int &y) override
{
if (!node_) {
if (has_value_) {
@@ -904,7 +904,7 @@ public:
y = static_cast<int>(vec.y());
return kOfxStatOK;
}
OfxStatus set(int x, int y)
OfxStatus set(int x, int y) override
{
if (!node_) {
value_[0] = x;
@@ -919,7 +919,7 @@ public:
submit_undo_command(node_, command, param_change_label(descriptor_));
return kOfxStatOK;
}
OfxStatus set(OfxTime time, int x, int y)
OfxStatus set(OfxTime time, int x, int y) override
{
if (!node_) {
value_[0] = x;
@@ -961,7 +961,7 @@ public:
{
node_ = new_node;
}
OfxStatus get(double &x, double &y, double &z)
OfxStatus get(double &x, double &y, double &z) override
{
if (!node_) {
if (has_value_) {
@@ -987,7 +987,7 @@ public:
}
return kOfxStatOK;
}
OfxStatus get(OfxTime time, double &x, double &y, double &z)
OfxStatus get(OfxTime time, double &x, double &y, double &z) override
{
if (!node_) {
if (has_value_) {
@@ -1014,7 +1014,7 @@ public:
}
return kOfxStatOK;
}
OfxStatus set(double x, double y, double z)
OfxStatus set(double x, double y, double z) override
{
if (!node_) {
value_[0] = x;
@@ -1038,7 +1038,7 @@ public:
submit_undo_command(node_, command, param_change_label(descriptor_));
return kOfxStatOK;
}
OfxStatus set(OfxTime time, double x, double y, double z)
OfxStatus set(OfxTime time, double x, double y, double z) override
{
if (!node_) {
value_[0] = x;
@@ -1091,7 +1091,7 @@ public:
{
node_ = new_node;
}
OfxStatus get(int &x, int &y, int &z)
OfxStatus get(int &x, int &y, int &z) override
{
if (!node_) {
if (has_value_) {
@@ -1110,7 +1110,7 @@ public:
z = static_cast<int>(vec.z());
return kOfxStatOK;
}
OfxStatus get(OfxTime time, int &x, int &y, int &z)
OfxStatus get(OfxTime time, int &x, int &y, int &z) override
{
if (!node_) {
if (has_value_) {
@@ -1130,7 +1130,7 @@ public:
z = static_cast<int>(vec.z());
return kOfxStatOK;
}
OfxStatus set(int x, int y, int z)
OfxStatus set(int x, int y, int z) override
{
if (!node_) {
value_[0] = x;
@@ -1146,7 +1146,7 @@ public:
submit_undo_command(node_, command, param_change_label(descriptor_));
return kOfxStatOK;
}
OfxStatus set(OfxTime time, int x, int y, int z)
OfxStatus set(OfxTime time, int x, int y, int z) override
{
if (!node_) {
value_[0] = x;
@@ -1198,7 +1198,7 @@ public:
{
node_ = new_node;
}
OfxStatus get(std::string &data)
OfxStatus get(std::string &data) override
{
if (!node_) {
data = has_value_ ? value_ : std::string();
@@ -1213,7 +1213,7 @@ public:
data.clear();
return kOfxStatErrValue;
}
OfxStatus get(OfxTime time, std::string &data)
OfxStatus get(OfxTime time, std::string &data) override
{
if (!node_) {
data = has_value_ ? value_ : std::string();
@@ -1228,7 +1228,7 @@ public:
data.clear();
return kOfxStatErrValue;
}
OfxStatus set(const char *data)
OfxStatus set(const char *data) override
{
if (!node_) {
value_ = data ? data : "";
@@ -1243,7 +1243,7 @@ public:
submit_undo_command(node_, command, param_change_label(descriptor_));
return kOfxStatOK;
}
OfxStatus set(OfxTime time, const char *data)
OfxStatus set(OfxTime time, const char *data) override
{
if (!node_) {
value_ = data ? data : "";
@@ -1282,7 +1282,7 @@ public:
{
node_ = new_node;
}
OfxStatus get(std::string &data)
OfxStatus get(std::string &data) override
{
if (!node_) {
data = has_value_ ? value_ : std::string();
@@ -1301,7 +1301,7 @@ public:
data.clear();
return kOfxStatErrValue;
}
OfxStatus get(OfxTime time, std::string &data)
OfxStatus get(OfxTime time, std::string &data) override
{
if (!node_) {
data = has_value_ ? value_ : std::string();
@@ -1320,7 +1320,7 @@ public:
data.clear();
return kOfxStatErrValue;
}
OfxStatus set(const char *data)
OfxStatus set(const char *data) override
{
if (!node_) {
value_ = data ? data : "";
@@ -1335,7 +1335,7 @@ public:
submit_undo_command(node_, command, param_change_label(descriptor_));
return kOfxStatOK;
}
OfxStatus set(OfxTime time, const char *data)
OfxStatus set(OfxTime time, const char *data) override
{
if (!node_) {
value_ = data ? data : "";