build/ci: green builds and tests on all three platforms
Compiler hygiene (all platforms): - Silence warnings across the tree: missing override, -Wreorder ctor init, -Wshadow, -Wsign-compare, missing switch cases, unused functions/captures, Qt 6.11 deprecations (QMouseEvent/QDropEvent accessors, qAsConst, Q_FOREACH over non-shared containers, AA_UseHighDpiPixmaps) and the .bak/ backup tree removal. - Fix regressions from the cleanup: missing clip decls in capi/timeline.cpp, plugin.cpp rename fallout, panel setFocus ambiguity, QGraphicsItem::pos vs event->position(), duplicate k_push_button case, boolean test variable. Windows: - Qt portability: CommandLineParser is_set/add_option, QTimeZone systemTimeZone (QTimeZone::LocalTime is 6.11-only), k_progress_* enum. - Linking: stop adding oakengine to OLIVE_LIBRARIES (import lib plus oakengine-obj caused multiple definitions); add OAKENGINE_STATIC so internal consumers no longer reference __imp_* stubs. - oakengine.ver: export olive::Renderer typeinfo so liboakgl.so can be dlopened (Linux), DynamicRenderer no longer dlcloses backend libraries (crash in RenderManager's dtor calling into unmapped memory). - OTIO runtime: copy DLLs next to every binary on Windows instead of relying on PATH (0xc0000135 in gtest discovery). - Headless GL: the runner only has GDI OpenGL 1.1, killing every render worker. Deploy Mesa llvmpipe as opengl32sw.dll (Qt's software-GL channel) with QT_OPENGL=software, and let QT_OPENGL override the AA_UseDesktopOpenGL default. ExportTask fails fast after 8 consecutive undelivered frames instead of segfaulting or grinding forever; FFmpegEncoder::write_frame tolerates null frames. - Tests: GetTempPathA+PID temp dirs, GetLongPathNameA for 8.3 names, forward-slash normalization when comparing project filenames. Linux: - Install libshaderc-dev so oakvulkan compiles GLSL (Vulkan tests). - Accept UNORM floor-or-round (63/64) in the blit ping-pong test. - Skip MainWindow construction test on the offscreen QPA (cannot paint QOpenGLWidget). Also: oak_cli_transcode gets a 300s ctest timeout, worker logs GL context version and LoadGraph/render_frame stages, and docs/plans/eliminate-event-bridge-issues.md (English translation).
This commit is contained in:
@@ -19,6 +19,7 @@
|
||||
|
||||
***/
|
||||
|
||||
#include <utility>
|
||||
#include "viewer.h"
|
||||
|
||||
#include <QDateTime>
|
||||
@@ -172,11 +173,16 @@ const Rational k_video_playback_interval = Rational(1, 10);
|
||||
|
||||
ViewerWidget::ViewerWidget(ViewerDisplayWidget *display, QWidget *parent)
|
||||
: super(false, true, parent)
|
||||
, overlay_(nullptr)
|
||||
, info_chip_(nullptr)
|
||||
, safe_frame_btn_(nullptr)
|
||||
, overlay_zoom_index_(5)
|
||||
, playback_speed_(0)
|
||||
, color_menu_enabled_(true)
|
||||
, time_changed_from_timer_(false)
|
||||
, prequeuing_video_(false)
|
||||
, prequeuing_audio_(0)
|
||||
, audio_processor_(oakengine_audio_processor_create())
|
||||
, record_armed_(false)
|
||||
, recording_(false)
|
||||
, first_requeue_watcher_(nullptr)
|
||||
@@ -185,11 +191,6 @@ ViewerWidget::ViewerWidget(ViewerDisplayWidget *display, QWidget *parent)
|
||||
, ignore_scrub_(0)
|
||||
, multicam_panel_(nullptr)
|
||||
, bridge_(new EngineEventBridge(this))
|
||||
, audio_processor_(oakengine_audio_processor_create())
|
||||
, overlay_(nullptr)
|
||||
, info_chip_(nullptr)
|
||||
, safe_frame_btn_(nullptr)
|
||||
, overlay_zoom_index_(5)
|
||||
{
|
||||
// Set up main layout
|
||||
QVBoxLayout *layout = new QVBoxLayout(this);
|
||||
@@ -958,13 +959,13 @@ void ViewerWidget::detect_multicam_node(const Rational &time)
|
||||
const Rational seq_tb = sequence_timebase(seq);
|
||||
|
||||
// Prefer selected nodes
|
||||
for (OakEngineNode *n : qAsConst(node_view_selected_)) {
|
||||
for (OakEngineNode *n : std::as_const(node_view_selected_)) {
|
||||
// MultiCam check via facade predicate (replaces
|
||||
// dynamic_cast<MultiCamNode*>)
|
||||
if (oakengine_node_is_multicam(n)) {
|
||||
multicam = n;
|
||||
// Found multicam, now try to find corresponding clip from selected timeline blocks
|
||||
for (OakEngineBlock *b : qAsConst(timeline_selected_blocks_)) {
|
||||
for (OakEngineBlock *b : std::as_const(timeline_selected_blocks_)) {
|
||||
// Clip check via facade predicate (replaces
|
||||
// dynamic_cast<ClipBlock*>)
|
||||
if (oakengine_node_is_clip(
|
||||
@@ -983,7 +984,7 @@ void ViewerWidget::detect_multicam_node(const Rational &time)
|
||||
|
||||
// Next, prefer multicam from selected block
|
||||
if (!multicam) {
|
||||
for (OakEngineBlock *b : qAsConst(timeline_selected_blocks_)) {
|
||||
for (OakEngineBlock *b : std::as_const(timeline_selected_blocks_)) {
|
||||
if (block_range_contains(b, seq_tb, time) &&
|
||||
oakengine_node_is_clip(
|
||||
reinterpret_cast<OakEngineNode *>(b))) {
|
||||
|
||||
Reference in New Issue
Block a user