From 516a5246c6e74615702a2a951983b83b1a3fa94d Mon Sep 17 00:00:00 2001
From: itsmattkc <itsmattkc@gmail.com>
Date: Fri, 22 Jan 2021 15:40:52 +1100
Subject: [PATCH] improved decibel handling in floatslider

---
 app/widget/slider/floatslider.cpp | 32 +++++++++++++++++++++++++++----
 app/widget/slider/floatslider.h   |  4 ++++
 2 files changed, 32 insertions(+), 4 deletions(-)

diff --git a/app/widget/slider/floatslider.cpp b/app/widget/slider/floatslider.cpp
index 4c30e7d0b..c7f5f43e9 100644
--- a/app/widget/slider/floatslider.cpp
+++ b/app/widget/slider/floatslider.cpp
@@ -21,6 +21,7 @@
 #include "floatslider.h"
 
 #include <QAudio>
+#include <QDebug>
 
 namespace olive {
 
@@ -94,7 +95,13 @@ QString FloatSlider::ValueToString(const QVariant &v)
     break;
   case kDecibel:
     // Convert to decibels and return dB formatted string
-    val = QAudio::convertVolume(val, QAudio::LinearVolumeScale, QAudio::DecibelVolumeScale);
+
+    // Return negative infinity for zero volume
+    if (qIsNull(val)) {
+      return tr("\xE2\x88\x9E");
+    }
+
+    val = LinearToDecibel(val);
     break;
   case kPercentage:
     // Multiply value by 100 for user-friendly percentage
@@ -131,7 +138,7 @@ QVariant FloatSlider::StringToValue(const QString &s, bool *ok)
 
     if (valid) {
       // Convert from decibel scale to linear decimal
-      return QAudio::convertVolume(decibels, QAudio::DecibelVolumeScale, QAudio::LinearVolumeScale);
+      return DecibelToLinear(decibels);
     }
 
     break;
@@ -166,9 +173,9 @@ double FloatSlider::AdjustDragDistanceInternal(const double &start, const double
     break;
   case kDecibel:
   {
-    qreal current_db = QAudio::convertVolume(start, QAudio::LinearVolumeScale, QAudio::DecibelVolumeScale);
+    double current_db = LinearToDecibel(start);
     current_db += drag;
-    qreal adjusted_linear = QAudio::convertVolume(current_db, QAudio::DecibelVolumeScale, QAudio::LinearVolumeScale);
+    double adjusted_linear = DecibelToLinear(current_db);
 
     return adjusted_linear;
   }
@@ -184,4 +191,21 @@ void FloatSlider::ConvertValue(QVariant v)
   emit ValueChanged(v.toDouble());
 }
 
+double FloatSlider::LinearToDecibel(double linear)
+{
+  return double(20.0) * std::log10(linear);
+}
+
+double FloatSlider::DecibelToLinear(double decibel)
+{
+  double to_linear = std::pow(double(10.0), decibel / double(20.0));
+
+  // Minimum threshold that we figure is close enough to 0 that we may as well just return 0
+  if (to_linear < 0.000001) {
+    return 0;
+  } else {
+    return to_linear;
+  }
+}
+
 }
diff --git a/app/widget/slider/floatslider.h b/app/widget/slider/floatslider.h
index 51b806fce..69c7eeedf 100644
--- a/app/widget/slider/floatslider.h
+++ b/app/widget/slider/floatslider.h
@@ -65,6 +65,10 @@ private slots:
   void ConvertValue(QVariant v);
 
 private:
+  static double LinearToDecibel(double linear);
+
+  static double DecibelToLinear(double decibel);
+
   DisplayType display_type_;
 
   int decimal_places_;