From 5109dd2995cf850f5597628cc3f57f621a6b1d00 Mon Sep 17 00:00:00 2001
From: Mike Solar <iam@mikesolar.cn>
Date: Mon, 20 Jul 2026 01:04:57 +0800
Subject: [PATCH] refactor: move the ratio input dialog out of engine common/
 into dialog/

get_float_ratio_from_user() is pure UI (QInputDialog/QMessageBox);
common/ stays dialog-free.
---
 app/common/CMakeLists.txt                            | 2 --
 app/dialog/CMakeLists.txt                            | 2 ++
 app/{common => dialog}/ratiodialog.cpp               | 0
 app/{common => dialog}/ratiodialog.h                 | 0
 app/widget/standardcombos/pixelaspectratiocombobox.h | 2 +-
 app/widget/viewer/viewer.cpp                         | 2 +-
 tests/gtest/common_ratiodialog_test.cpp              | 2 +-
 7 files changed, 5 insertions(+), 5 deletions(-)
 rename app/{common => dialog}/ratiodialog.cpp (100%)
 rename app/{common => dialog}/ratiodialog.h (100%)

diff --git a/app/common/CMakeLists.txt b/app/common/CMakeLists.txt
index 2f855f4e1..772dea669 100644
--- a/app/common/CMakeLists.txt
+++ b/app/common/CMakeLists.txt
@@ -47,8 +47,6 @@ target_sources(libolive-editor PRIVATE
         qtutils.cpp
         qtutils.h
         range.h
-        ratiodialog.cpp
-        ratiodialog.h
         threadsafemap.h
         tohex.h
         util.h
diff --git a/app/dialog/CMakeLists.txt b/app/dialog/CMakeLists.txt
index c3cab7449..66e31bb6e 100644
--- a/app/dialog/CMakeLists.txt
+++ b/app/dialog/CMakeLists.txt
@@ -41,5 +41,7 @@ add_subdirectory(text)
 
 set(OLIVE_SOURCES
         ${OLIVE_SOURCES}
+        dialog/ratiodialog.cpp
+        dialog/ratiodialog.h
         PARENT_SCOPE
 )
diff --git a/app/common/ratiodialog.cpp b/app/dialog/ratiodialog.cpp
similarity index 100%
rename from app/common/ratiodialog.cpp
rename to app/dialog/ratiodialog.cpp
diff --git a/app/common/ratiodialog.h b/app/dialog/ratiodialog.h
similarity index 100%
rename from app/common/ratiodialog.h
rename to app/dialog/ratiodialog.h
diff --git a/app/widget/standardcombos/pixelaspectratiocombobox.h b/app/widget/standardcombos/pixelaspectratiocombobox.h
index 7b8b03642..a9acb8367 100644
--- a/app/widget/standardcombos/pixelaspectratiocombobox.h
+++ b/app/widget/standardcombos/pixelaspectratiocombobox.h
@@ -24,7 +24,7 @@
 
 #include <QComboBox>
 
-#include "common/ratiodialog.h"
+#include "dialog/ratiodialog.h"
 #include "render/videoparams.h"
 
 namespace olive
diff --git a/app/widget/viewer/viewer.cpp b/app/widget/viewer/viewer.cpp
index 4e6e3ec6d..d9e157229 100644
--- a/app/widget/viewer/viewer.cpp
+++ b/app/widget/viewer/viewer.cpp
@@ -33,7 +33,7 @@
 #include <QVBoxLayout>
 
 #include "audio/audiomanager.h"
-#include "common/ratiodialog.h"
+#include "dialog/ratiodialog.h"
 #include "config/config.h"
 #include "core.h"
 #include "node/block/gap/gap.h"
diff --git a/tests/gtest/common_ratiodialog_test.cpp b/tests/gtest/common_ratiodialog_test.cpp
index 1572eaeb4..6e45e51a1 100644
--- a/tests/gtest/common_ratiodialog_test.cpp
+++ b/tests/gtest/common_ratiodialog_test.cpp
@@ -7,7 +7,7 @@
 #include <QMessageBox>
 #include <QTimer>
 
-#include "common/ratiodialog.h"
+#include "dialog/ratiodialog.h"
 
 using namespace olive;