workspace: zero compiler warnings across all targets
254 warnings (320 counting replayed-cache re-emitters) cleaned: unused mut/imports/variables, irrefutable if-lets and unreachable patterns, dead code removed or annotated #[allow(dead_code)] with the reason (C++ parity value sets, cfg(test) helpers, public API reservations), drop(&ref) no-ops removed, fn-pointer identity via std::ptr::fn_addr_eq, the test-stubs feature declared in oak-node's manifest, missing docs filled. Every unused-Result site was judged individually: meaningful errors propagate, intentional ignores are let _ = with a note. Two pre-existing latent bugs are documented in place, behavior preserved: app.rs's timeline-tool observer and dialogs.rs's format subscription both drop the returned Subscription immediately, so they never fire.
This commit is contained in:
@@ -39,7 +39,7 @@ use crate::graph::Graph;
|
||||
use crate::id::NodeId;
|
||||
use crate::keyframe::{Interpolation, Keyframe};
|
||||
use crate::node::NodeCore;
|
||||
use crate::project::{NodeRef, Project};
|
||||
use crate::project::Project;
|
||||
use crate::value::{NodeValue, ValueType};
|
||||
|
||||
/// Minimal XML reader surface the serializer needs (implemented over
|
||||
@@ -565,7 +565,6 @@ fn load_project_body(
|
||||
reader: &mut dyn XmlRead,
|
||||
project: &mut Project,
|
||||
) -> crate::error::Result<std::collections::HashMap<u64, NodeId>> {
|
||||
use crate::error::Error;
|
||||
// Identity -> NodeId map for connection resolution.
|
||||
let mut id_map: std::collections::HashMap<u64, NodeId> = std::collections::HashMap::new();
|
||||
// Deferred connections: (output_identity, input_node_id, input_id, element).
|
||||
@@ -693,7 +692,7 @@ fn load_node(
|
||||
// types fall back to an error. `create_any` also covers the dynamic
|
||||
// (runtime-registered OpenFX plugin) entries — `find` alone would
|
||||
// reject every project that carries a plugin node.
|
||||
let (mut core, behavior): (NodeCore, Box<dyn crate::node::NodeBehavior>) =
|
||||
let (core, behavior): (NodeCore, Box<dyn crate::node::NodeBehavior>) =
|
||||
match create_timeline_type(&type_id) {
|
||||
Some(x) => x,
|
||||
None => match crate::factory::Factory::global().create_any(&type_id) {
|
||||
|
||||
Reference in New Issue
Block a user