workspace: zero compiler warnings across all targets

254 warnings (320 counting replayed-cache re-emitters) cleaned:
unused mut/imports/variables, irrefutable if-lets and unreachable
patterns, dead code removed or annotated #[allow(dead_code)] with
the reason (C++ parity value sets, cfg(test) helpers, public API
reservations), drop(&ref) no-ops removed, fn-pointer identity via
std::ptr::fn_addr_eq, the test-stubs feature declared in
oak-node's manifest, missing docs filled. Every unused-Result site
was judged individually: meaningful errors propagate, intentional
ignores are let _ = with a note.

Two pre-existing latent bugs are documented in place, behavior
preserved: app.rs's timeline-tool observer and dialogs.rs's format
subscription both drop the returned Subscription immediately, so
they never fire.
This commit is contained in:
2026-09-11 16:38:44 +08:00
parent faebc79c31
commit 4f0f5cbba6
98 changed files with 409 additions and 455 deletions
+11 -11
View File
@@ -425,7 +425,7 @@ fn push_start_element(
// value (XML_ERROR_INVALID_TOKEN).
return None;
}
let value = match attr.unescape_value() {
let value = match attr.normalized_value(quick_xml::XmlVersion::Implicit1_0) {
Ok(v) => v.into_owned(),
Err(_) => return None,
};
@@ -714,19 +714,19 @@ mod tests {
#[test]
fn reader_unclosed_element_is_error() {
let mut r = XmlReader::new("<a>").unwrap();
let r = XmlReader::new("<a>").unwrap();
assert!(r.has_error().unwrap());
}
#[test]
fn reader_empty_document_is_error() {
let mut r = XmlReader::new("").unwrap();
let r = XmlReader::new("").unwrap();
assert!(r.has_error().unwrap());
}
#[test]
fn reader_undefined_entity_is_error() {
let mut r = XmlReader::new("<a>&foo;</a>").unwrap();
let r = XmlReader::new("<a>&foo;</a>").unwrap();
assert!(r.has_error().unwrap());
}
@@ -742,7 +742,7 @@ mod tests {
#[test]
fn reader_name_before_read_is_empty() {
let mut r = XmlReader::new("<a></a>").unwrap();
let r = XmlReader::new("<a></a>").unwrap();
assert_eq!(r.name().unwrap(), "");
assert_eq!(r.attribute_count().unwrap(), 0);
}
@@ -824,7 +824,7 @@ mod tests {
/// (XML_ERROR_DUPLICATE_ATTRIBUTE).
#[test]
fn reader_duplicate_attribute_is_error() {
let mut r = XmlReader::new("<e a=\"1\" a=\"2\"/>").unwrap();
let r = XmlReader::new("<e a=\"1\" a=\"2\"/>").unwrap();
assert!(r.has_error().unwrap());
}
@@ -832,7 +832,7 @@ mod tests {
/// (XML_ERROR_INVALID_TOKEN).
#[test]
fn reader_lt_in_attribute_value_is_error() {
let mut r = XmlReader::new("<e a=\"x<y\"/>").unwrap();
let r = XmlReader::new("<e a=\"x<y\"/>").unwrap();
assert!(r.has_error().unwrap());
}
@@ -885,13 +885,13 @@ mod tests {
#[test]
fn reader_text_before_root_is_error() {
let mut r = XmlReader::new("junk<a/>").unwrap();
let r = XmlReader::new("junk<a/>").unwrap();
assert!(r.has_error().unwrap());
}
#[test]
fn reader_text_after_root_is_error() {
let mut r = XmlReader::new("<a/>junk").unwrap();
let r = XmlReader::new("<a/>junk").unwrap();
assert!(r.has_error().unwrap());
}
@@ -899,10 +899,10 @@ mod tests {
/// element").
#[test]
fn reader_second_root_element_is_error() {
let mut r = XmlReader::new("<a/><b/>").unwrap();
let r = XmlReader::new("<a/><b/>").unwrap();
assert!(r.has_error().unwrap());
let mut r = XmlReader::new("<a></a><b></b>").unwrap();
let r = XmlReader::new("<a></a><b></b>").unwrap();
assert!(r.has_error().unwrap());
}