From 4ddeadaf46980eab1db3fc3a587751210d7ce2aa Mon Sep 17 00:00:00 2001 From: itsmattkc Date: Mon, 16 Dec 2019 03:00:26 +1100 Subject: [PATCH] fixed regression in slider The recent slider focus addition caused the label to re-focus if the user pressed enter in the line edit, causing the line edit to never disappear. --- app/widget/slider/sliderbase.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/app/widget/slider/sliderbase.cpp b/app/widget/slider/sliderbase.cpp index 09329a477..2d34c4c30 100644 --- a/app/widget/slider/sliderbase.cpp +++ b/app/widget/slider/sliderbase.cpp @@ -233,6 +233,7 @@ void SliderBase::LineEditConfirmed() // Ensure editor doesn't signal that the focus is lost editor_->blockSignals(true); + label_->blockSignals(true); if (is_valid) { SetValue(test_val); @@ -251,15 +252,18 @@ void SliderBase::LineEditConfirmed() } editor_->blockSignals(false); + label_->blockSignals(false); } void SliderBase::LineEditCancelled() { // Ensure editor doesn't signal that the focus is lost editor_->blockSignals(true); + label_->blockSignals(true); // Set widget back to label setCurrentWidget(label_); editor_->blockSignals(false); + label_->blockSignals(false); }