From 7f4157042dad760ba436adc1a0d45eab608edaf0 Mon Sep 17 00:00:00 2001 From: Simran Spiller Date: Wed, 23 Sep 2020 14:23:42 +0200 Subject: [PATCH 1/3] github: issue template formatting Wrap lines at ~80 characters, add space after subjects in title --- .github/ISSUE_TEMPLATE/00-olive_unsupported.md | 13 ++++++++----- .github/ISSUE_TEMPLATE/01-crash_issue.md | 4 ++-- .github/ISSUE_TEMPLATE/50-build_issue.md | 9 ++++++--- .github/ISSUE_TEMPLATE/50-cache_issue.md | 9 ++++++--- .github/ISSUE_TEMPLATE/50-codec_issue.md | 8 +++++--- .github/ISSUE_TEMPLATE/50-color_issue.md | 8 +++++--- .github/ISSUE_TEMPLATE/50-editing_issue.md | 8 +++++--- .github/ISSUE_TEMPLATE/50-export_issue.md | 8 +++++--- .github/ISSUE_TEMPLATE/50-node_issue.md | 8 +++++--- .github/ISSUE_TEMPLATE/50-playback_issue.md | 8 +++++--- .github/ISSUE_TEMPLATE/50-project_issue.md | 8 +++++--- .github/ISSUE_TEMPLATE/50-renderer_issue.md | 8 +++++--- .github/ISSUE_TEMPLATE/50-ui_issue.md | 8 +++++--- 13 files changed, 67 insertions(+), 40 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/00-olive_unsupported.md b/.github/ISSUE_TEMPLATE/00-olive_unsupported.md index 88e715ff8..2fd86f774 100644 --- a/.github/ISSUE_TEMPLATE/00-olive_unsupported.md +++ b/.github/ISSUE_TEMPLATE/00-olive_unsupported.md @@ -1,11 +1,14 @@ --- name: Legacy Olive 0.1.x issue ⛔ -about: Olive 0.1 is no longer supported and issues made about it will be automatically closed. -title: "[UNSUPPORTED]" -labels: "Legacy (Unsupported)" +about: >- + Olive 0.1 is no longer supported and issues made about it will be + automatically closed. +title: '[UNSUPPORTED] ' +labels: 'Legacy (Unsupported)' assignees: '' --- # Olive 0.1 is unsupported -Unfortunately no one is supporting Olive 0.1 at this time. Any reports pertaining to it will be -closed to keep the issue tracker focused on supported versions. +Unfortunately no one is supporting Olive 0.1 at this time. Any reports +pertaining to it will be closed to keep the issue tracker focused on supported +versions. diff --git a/.github/ISSUE_TEMPLATE/01-crash_issue.md b/.github/ISSUE_TEMPLATE/01-crash_issue.md index 87e916dee..24f1d03ec 100644 --- a/.github/ISSUE_TEMPLATE/01-crash_issue.md +++ b/.github/ISSUE_TEMPLATE/01-crash_issue.md @@ -1,8 +1,8 @@ --- name: Crash about: Report a fatal crash that resulted in Olive unexpectedly closing. -title: "[CRASH]" -labels: "Crash, Triage" +title: '[CRASH] ' +labels: 'Crash, Triage' assignees: '' --- **Commit Hash** diff --git a/.github/ISSUE_TEMPLATE/50-build_issue.md b/.github/ISSUE_TEMPLATE/50-build_issue.md index 155c7c750..66e56f503 100644 --- a/.github/ISSUE_TEMPLATE/50-build_issue.md +++ b/.github/ISSUE_TEMPLATE/50-build_issue.md @@ -1,8 +1,11 @@ --- name: Build/Packaging -about: Report an issue related to compiling or packaging (including continuous integration). Note that we do not officially support custom build configurations and may choose not to address issues involving them. -title: "[BUILD]" -labels: "Building/Packaging, Triage" +about: >- + Report an issue related to compiling or packaging (including nightly builds / + continuous integration). Note that we do not officially support custom build + configurations and may choose not to address issues involving them. +title: '[BUILD] ' +labels: 'Building/Packaging, Triage' assignees: '' --- **Commit Hash** diff --git a/.github/ISSUE_TEMPLATE/50-cache_issue.md b/.github/ISSUE_TEMPLATE/50-cache_issue.md index f346d8245..aa67eb877 100644 --- a/.github/ISSUE_TEMPLATE/50-cache_issue.md +++ b/.github/ISSUE_TEMPLATE/50-cache_issue.md @@ -1,8 +1,11 @@ --- name: Disk Cache -about: Report an issue related to the disk cache system, including failure to cache, frames being set to appear at the wrong time, disk space or memory usage issues, etc. -title: "[CACHE]" -labels: "Disk Cache, Triage" +about: >- + Report an issue related to the disk cache system, including failure to cache, + frames being set to appear at the wrong time, disk space or memory usage + issues, etc. +title: '[CACHE] ' +labels: 'Disk Cache, Triage' assignees: '' --- **Commit Hash** diff --git a/.github/ISSUE_TEMPLATE/50-codec_issue.md b/.github/ISSUE_TEMPLATE/50-codec_issue.md index 09fc991ac..c0a94eef6 100644 --- a/.github/ISSUE_TEMPLATE/50-codec_issue.md +++ b/.github/ISSUE_TEMPLATE/50-codec_issue.md @@ -1,8 +1,10 @@ --- name: Codec -about: Report an issue related to codec handling, including importing footage or any footage usage issues while editing. -title: "[CODEC]" -labels: "Codec, Triage" +about: >- + Report an issue related to codec handling, including importing footage or any + footage usage issues while editing. +title: '[CODEC] ' +labels: 'Codec, Triage' assignees: '' --- **Commit Hash** diff --git a/.github/ISSUE_TEMPLATE/50-color_issue.md b/.github/ISSUE_TEMPLATE/50-color_issue.md index 99e4c803c..7fb55c049 100644 --- a/.github/ISSUE_TEMPLATE/50-color_issue.md +++ b/.github/ISSUE_TEMPLATE/50-color_issue.md @@ -1,8 +1,10 @@ --- name: Color Management -about: Report an issue related to the management of pixels and color, including inaccurate results, color inconsistencies, etc. -title: "[COLOR]" -labels: "Color Management, Triage" +about: >- + Report an issue related to the management of pixels and color, including + inaccurate results, color inconsistencies, etc. +title: '[COLOR] ' +labels: 'Color Management, Triage' assignees: '' --- **Commit Hash** diff --git a/.github/ISSUE_TEMPLATE/50-editing_issue.md b/.github/ISSUE_TEMPLATE/50-editing_issue.md index 88d2f16c1..08d8cb93f 100644 --- a/.github/ISSUE_TEMPLATE/50-editing_issue.md +++ b/.github/ISSUE_TEMPLATE/50-editing_issue.md @@ -1,8 +1,10 @@ --- name: Timeline/Editing -about: Report an issue related to the overall editing experience, including usage of the timeline, interchange, synchronization, multi-camera support, etc. -title: "[EDIT]" -labels: "Timeline/Editing, Triage" +about: >- + Report an issue related to the overall editing experience, including usage of + the timeline, interchange, synchronization, multi-camera support, etc. +title: '[EDIT] ' +labels: 'Timeline/Editing, Triage' assignees: '' --- **Commit Hash** diff --git a/.github/ISSUE_TEMPLATE/50-export_issue.md b/.github/ISSUE_TEMPLATE/50-export_issue.md index 4e6e1f3a2..9f7544115 100644 --- a/.github/ISSUE_TEMPLATE/50-export_issue.md +++ b/.github/ISSUE_TEMPLATE/50-export_issue.md @@ -1,8 +1,10 @@ --- name: Export -about: Report an issue related to exporting videos from Olive, including errors while exporting, issues with the resulting video, etc. -title: "[EXPORT]" -labels: "Export, Triage" +about: >- + Report an issue related to exporting videos from Olive, including errors + while exporting, issues with the resulting video, etc. +title: '[EXPORT] ' +labels: 'Export, Triage' assignees: '' --- **Commit Hash** diff --git a/.github/ISSUE_TEMPLATE/50-node_issue.md b/.github/ISSUE_TEMPLATE/50-node_issue.md index ec31c8989..3d60610aa 100644 --- a/.github/ISSUE_TEMPLATE/50-node_issue.md +++ b/.github/ISSUE_TEMPLATE/50-node_issue.md @@ -1,8 +1,10 @@ --- name: Node/Compositing -about: Report an issue related to the node-based compositing system, including node graph usability issues, issues working with node effects, issues with composited output, etc. -title: "[NODES]" -labels: "Nodes/Compositing, Triage" +about: >- + Report an issue related to the node-based compositing system, including node graph + usability issues, issues working with node effects, issues with composited output, etc. +title: '[NODES] ' +labels: 'Nodes/Compositing, Triage' assignees: '' --- **Commit Hash** diff --git a/.github/ISSUE_TEMPLATE/50-playback_issue.md b/.github/ISSUE_TEMPLATE/50-playback_issue.md index 32a3cc13b..14aa90f62 100644 --- a/.github/ISSUE_TEMPLATE/50-playback_issue.md +++ b/.github/ISSUE_TEMPLATE/50-playback_issue.md @@ -1,8 +1,10 @@ --- name: Playback -about: Report an issue related to the playback of video or audio, including laggy or inconsistent playback, failure to playback, etc. -title: "[PLAYBACK]" -labels: "Playback, Triage" +about: >- + Report an issue related to the playback of video or audio, including laggy or + inconsistent playback, failure to playback, etc. +title: '[PLAYBACK] ' +labels: 'Playback, Triage' assignees: '' --- **Commit Hash** diff --git a/.github/ISSUE_TEMPLATE/50-project_issue.md b/.github/ISSUE_TEMPLATE/50-project_issue.md index ff9175354..1cf79b649 100644 --- a/.github/ISSUE_TEMPLATE/50-project_issue.md +++ b/.github/ISSUE_TEMPLATE/50-project_issue.md @@ -1,8 +1,10 @@ --- name: Project Management -about: Report an issue related to project management, including working with and organizing imported files. -title: "[PROJECT]" -labels: "Project, Triage" +about: >- + Report an issue related to project management, including working with and + organizing imported files. +title: '[PROJECT] ' +labels: 'Project, Triage' assignees: '' --- **Commit Hash** diff --git a/.github/ISSUE_TEMPLATE/50-renderer_issue.md b/.github/ISSUE_TEMPLATE/50-renderer_issue.md index e77316402..4f6ffd0da 100644 --- a/.github/ISSUE_TEMPLATE/50-renderer_issue.md +++ b/.github/ISSUE_TEMPLATE/50-renderer_issue.md @@ -1,8 +1,10 @@ --- name: Renderer -about: Report an issue related to rendering, including corrupted frames, incorrect render results, unexpected black or white frames, etc. -title: "[RENDER]" -labels: "Renderer, Triage" +about: >- + Report an issue related to rendering, including corrupted frames, incorrect + render results, unexpected black or white frames, etc. +title: '[RENDER] ' +labels: 'Renderer, Triage' assignees: '' --- **Commit Hash** diff --git a/.github/ISSUE_TEMPLATE/50-ui_issue.md b/.github/ISSUE_TEMPLATE/50-ui_issue.md index f746024de..251a65b1e 100644 --- a/.github/ISSUE_TEMPLATE/50-ui_issue.md +++ b/.github/ISSUE_TEMPLATE/50-ui_issue.md @@ -1,8 +1,10 @@ --- name: User Interface -about: Report an issue related to general user interface usability, including behavior issues, usability issues, look and feel, etc. -title: "[UI]" -labels: "User Interface, Triage" +about: >- + Report an issue related to general user interface usability, including + behavior issues, usability issues, look and feel, etc. +title: '[UI] ' +labels: 'User Interface, Triage' assignees: '' --- **Commit Hash** From 21412c5eee41e132abd30cc6339b2b56596bcbbe Mon Sep 17 00:00:00 2001 From: Simran Spiller Date: Wed, 23 Sep 2020 14:34:12 +0200 Subject: [PATCH 2/3] github: Fix build issue templates There's a limitation to the length of frontmatter fields it seems: About is too long (maximum is 200 characters) --- .github/ISSUE_TEMPLATE/50-build_issue.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/50-build_issue.md b/.github/ISSUE_TEMPLATE/50-build_issue.md index 66e56f503..556e4cabe 100644 --- a/.github/ISSUE_TEMPLATE/50-build_issue.md +++ b/.github/ISSUE_TEMPLATE/50-build_issue.md @@ -1,9 +1,9 @@ --- name: Build/Packaging about: >- - Report an issue related to compiling or packaging (including nightly builds / - continuous integration). Note that we do not officially support custom build - configurations and may choose not to address issues involving them. + Report an issue related to compiling or packaging (including continuous + integration). Note that we do not officially support custom build + configurations and may not address issues involving them. title: '[BUILD] ' labels: 'Building/Packaging, Triage' assignees: '' From faf36708508dc40ef689ef99588e7e747f04aa23 Mon Sep 17 00:00:00 2001 From: Simran Spiller Date: Wed, 23 Sep 2020 14:50:48 +0200 Subject: [PATCH 3/3] ci: Don't trigger build on certain paths Makes no sense for updates to issue templates, the funding config and readme. Also exclude docker folder, as changes will not affect the build until someone builds & pushes updated images. Do not exclude the LICENSE file however, as it gets packaged in CI runs. --- .github/workflows/ci.yml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index a8b435f31..9a1f1f0ee 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -4,6 +4,12 @@ on: push: branches: - master + paths-ignore: + - '.github/ISSUE_TEMPLATE/**' + - '.github/FUNDING.yml' + - 'docker/**' + - 'CONTRIBUTING.md' + - 'README.md' env: DOWNLOAD_TOOL: curl -fLOSs --retry 3