moved timeline undoable commands to using the new NodeAddCommand

Previous iteration used some "magic code" that added clips automatically to the
timeline. This was functional but ultimately outside of the undo commands'
control meaning nodes could be infinitely added and abandoned. This makes the
add process part of the undo command which means it's all undoable as the user
would expect.

app/widget/nodeview/nodeviewitem.cpp

@@ -47,6 +47,7 @@ NodeViewItem::NodeViewItem(QGraphicsItem *parent) :
   // Set flags for this widget
   setFlag(QGraphicsItem::ItemIsMovable);
   setFlag(QGraphicsItem::ItemIsSelectable);
+  setFlag(QGraphicsItem::ItemSendsGeometryChanges);
 
   //
   // We use font metrics to set all the UI measurements for DPI-awareness
@@ -77,6 +78,8 @@ void NodeViewItem::SetNode(Node *n)
 {
   node_ = n;
 
+  setPos(node_->GetPosition());
+
   update();
 }
 
@@ -256,8 +259,6 @@ void NodeViewItem::paint(QPainter *painter, const QStyleOptionGraphicsItem *opti
   }
 }
 
-#include "node/block/block.h"
-
 void NodeViewItem::mousePressEvent(QGraphicsSceneMouseEvent *event)
 {
   // We override standard mouse behavior in some cases. In these cases, we don't want the standard "move" and "release"
@@ -470,3 +471,12 @@ void NodeViewItem::mouseReleaseEvent(QGraphicsSceneMouseEvent *event)
     QGraphicsRectItem::mouseReleaseEvent(event);
   }
 }
+
+QVariant NodeViewItem::itemChange(QGraphicsItem::GraphicsItemChange change, const QVariant &value)
+{
+  if (change == ItemPositionHasChanged && node_) {
+    node_->SetPosition(value.toPointF());
+  }
+
+  return QGraphicsItem::itemChange(change, value);
+}

app/widget/nodeview/nodeviewitem.h

@@ -82,6 +82,8 @@ protected:
   virtual void mouseMoveEvent(QGraphicsSceneMouseEvent *event) override;
   virtual void mouseReleaseEvent(QGraphicsSceneMouseEvent *event) override;
 
+  virtual QVariant itemChange(QGraphicsItem::GraphicsItemChange change, const QVariant &value) override;
+
 private:
   /**
    * @brief Get the relative position to draw text for a parameter at a certain index

app/widget/nodeview/nodeviewundo.cpp

@@ -70,8 +70,8 @@ NodeAddCommand::NodeAddCommand(NodeGraph *graph, Node *node, QUndoCommand *paren
   graph_(graph),
   node_(node)
 {
-  // Ensures that when this command is destroyed, if redo() hasn't been called, the node will be destroyed too
-  node->setParent(&memory_manager_);
+  // Ensures that when this command is destroyed, if redo() is never called again, the node will be destroyed too
+  node_->setParent(&memory_manager_);
 }
 
 void NodeAddCommand::redo()

app/widget/nodeview/nodeviewundo.h

@@ -5,6 +5,7 @@
 
 #include "node/graph.h"
 #include "node/node.h"
+#include "nodeviewitem.h"
 
 /**
  * @brief An undoable commnd for connecting two NodeParams together
@@ -62,7 +63,9 @@ private:
 
 class NodeRemoveCommand : public QUndoCommand {
 public:
-  NodeRemoveCommand(NodeGraph* graph, const QList<Node*>& nodes, QUndoCommand* parent = nullptr);
+  NodeRemoveCommand(NodeGraph* graph,
+                    const QList<Node*>& nodes,
+                    QUndoCommand* parent = nullptr);
 
   virtual void redo() override;
   virtual void undo() override;