fix: bug-fix sweep across node, audio, render, plugin subsystems
Node core: - MathNode/TrigonometryNode combo strings realigned with Operation enums - mathbase scalar/vector operand pick no longer uses bitwise type checks - NodeSetPositionAndDependenciesRecursively moves dependencies again - RemoveAllKeyframes undo actually restores keyframes - NodeGroup GetInputName null-deref guard, passthrough ids use input id - NodeValueTable::Has is an exact type match; tag fallback only for empty tags; kStrCombo/kPushButton get data type names - delete_all_keyframes no longer loops forever on unparented keyframes; keyframe-load failures propagate; rational interpolation falls back to double; OpacityEffect no longer leaks its internal MathNode Audio/footage: - AudioVisualWaveform: GetSummaryFromTime underflow OOB read, TrimIn prepend length bookkeeping, OverwriteSums source channel indexing - PanNode inserts the pan value into the sample job (keyframed pan works); OutputParamsChanged is emitted on device change; PortAudio device indices are validated before Pa_GetDeviceInfo - Footage: AdjustTimeByLoopMode no longer hangs/UBs on degenerate lengths, GetStreamIndex bounds-checked, CheckFootage clears stale state on missing files, failed probes are not cached, FootageDescription::Load requires its own root element Render/track: - ViewerOutput pushes the tagged samples value; TrackList disconnects the track-height lambda; GetTrackFromReference validity check - RenderManager dummy backend: null-initialized threads, guarded decoder-cache/timer paths; Renderer::Destroy releases color cache shaders/textures; unknown dynamic backends no longer alias to oakgl - SharedMemoryRegion POSIX attach validates segment size; ReadMessage skips blank lines instead of failing; GC counter clamped; IsRenderingCustomRange implemented; TimeOffsetNode gets a true inverse OutputTimeAdjustment; zero-speed clips return the held frame Plugin/nodes: - OliveClip: stored default region of definition is honored, on-demand images are cached; OliveHost sets host identity properties and logs instead of showing modal dialogs offscreen; Plugin.h dead decls gone - DespillNode guards graph-less use with Rec.709 fallback; description typos fixed (despill, swirl); mosaic applies when only one axis matches; Windows-only Project filename separator test fixed
This commit is contained in:
@@ -566,6 +566,38 @@ TEST(PluginClipInstance, RegionOfDefinitionPerTimeOverride)
|
||||
EXPECT_DOUBLE_EQ(at_four.y2, 80.0);
|
||||
}
|
||||
|
||||
TEST(PluginClipInstance, RegionOfDefinitionFallsBackToStoredDefault)
|
||||
{
|
||||
OFX::Host::ImageEffect::ClipDescriptor desc(kOfxImageEffectOutputClipName);
|
||||
|
||||
// Zero-sized params yield no usable params-derived region, so the stored
|
||||
// default is used.
|
||||
olive::VideoParams empty_params =
|
||||
MakeParams(0, 0, olive::core::PixelFormat::U8, 4, false);
|
||||
olive::plugin::OliveClipInstance empty_clip(nullptr, desc, empty_params);
|
||||
|
||||
OfxRectD stored = { 2.0, 4.0, 202.0, 104.0 };
|
||||
empty_clip.setDefaultRegionOfDefinition(stored);
|
||||
|
||||
OfxRectD fallback = empty_clip.getRegionOfDefinition(0.0);
|
||||
EXPECT_DOUBLE_EQ(fallback.x1, 2.0);
|
||||
EXPECT_DOUBLE_EQ(fallback.y1, 4.0);
|
||||
EXPECT_DOUBLE_EQ(fallback.x2, 202.0);
|
||||
EXPECT_DOUBLE_EQ(fallback.y2, 104.0);
|
||||
|
||||
// A params-derived region still takes precedence over the stored default.
|
||||
olive::VideoParams params =
|
||||
MakeParams(100, 80, olive::core::PixelFormat::U8, 4, false);
|
||||
olive::plugin::OliveClipInstance clip(nullptr, desc, params);
|
||||
clip.setDefaultRegionOfDefinition(stored);
|
||||
|
||||
OfxRectD derived = clip.getRegionOfDefinition(0.0);
|
||||
EXPECT_DOUBLE_EQ(derived.x1, 0.0);
|
||||
EXPECT_DOUBLE_EQ(derived.y1, 0.0);
|
||||
EXPECT_DOUBLE_EQ(derived.x2, 100.0);
|
||||
EXPECT_DOUBLE_EQ(derived.y2, 80.0);
|
||||
}
|
||||
|
||||
TEST(PluginClipInstance, OutputImageBoundsFollowRegionOfDefinition)
|
||||
{
|
||||
OFX::Host::ImageEffect::ClipDescriptor desc(kOfxImageEffectOutputClipName);
|
||||
@@ -787,11 +819,11 @@ TEST(PluginClipInstance, PruneImagesCacheEvictsOldestInputImages)
|
||||
}
|
||||
clip.pruneImagesCache();
|
||||
|
||||
// The oldest entry (time 1) was evicted and is recreated on demand,
|
||||
// while later entries remain cached.
|
||||
// The oldest entry (time 1) was evicted; its on-demand recreation is
|
||||
// cached again, while later entries remained cached throughout.
|
||||
OFX::Host::ImageEffect::Image *evicted_a = clip.getImage(1.0, nullptr);
|
||||
OFX::Host::ImageEffect::Image *evicted_b = clip.getImage(1.0, nullptr);
|
||||
EXPECT_NE(evicted_a, evicted_b);
|
||||
EXPECT_EQ(evicted_a, evicted_b);
|
||||
|
||||
OFX::Host::ImageEffect::Image *cached_a = clip.getImage(2.0, nullptr);
|
||||
OFX::Host::ImageEffect::Image *cached_b = clip.getImage(2.0, nullptr);
|
||||
|
||||
Reference in New Issue
Block a user