fix: bug-fix sweep across node, audio, render, plugin subsystems
Node core: - MathNode/TrigonometryNode combo strings realigned with Operation enums - mathbase scalar/vector operand pick no longer uses bitwise type checks - NodeSetPositionAndDependenciesRecursively moves dependencies again - RemoveAllKeyframes undo actually restores keyframes - NodeGroup GetInputName null-deref guard, passthrough ids use input id - NodeValueTable::Has is an exact type match; tag fallback only for empty tags; kStrCombo/kPushButton get data type names - delete_all_keyframes no longer loops forever on unparented keyframes; keyframe-load failures propagate; rational interpolation falls back to double; OpacityEffect no longer leaks its internal MathNode Audio/footage: - AudioVisualWaveform: GetSummaryFromTime underflow OOB read, TrimIn prepend length bookkeeping, OverwriteSums source channel indexing - PanNode inserts the pan value into the sample job (keyframed pan works); OutputParamsChanged is emitted on device change; PortAudio device indices are validated before Pa_GetDeviceInfo - Footage: AdjustTimeByLoopMode no longer hangs/UBs on degenerate lengths, GetStreamIndex bounds-checked, CheckFootage clears stale state on missing files, failed probes are not cached, FootageDescription::Load requires its own root element Render/track: - ViewerOutput pushes the tagged samples value; TrackList disconnects the track-height lambda; GetTrackFromReference validity check - RenderManager dummy backend: null-initialized threads, guarded decoder-cache/timer paths; Renderer::Destroy releases color cache shaders/textures; unknown dynamic backends no longer alias to oakgl - SharedMemoryRegion POSIX attach validates segment size; ReadMessage skips blank lines instead of failing; GC counter clamped; IsRenderingCustomRange implemented; TimeOffsetNode gets a true inverse OutputTimeAdjustment; zero-speed clips return the held frame Plugin/nodes: - OliveClip: stored default region of definition is honored, on-demand images are cached; OliveHost sets host identity properties and logs instead of showing modal dialogs offscreen; Plugin.h dead decls gone - DespillNode guards graph-less use with Rec.709 fallback; description typos fixed (despill, swirl); mosaic applies when only one axis matches; Windows-only Project filename separator test fixed
This commit is contained in:
@@ -23,6 +23,7 @@
|
||||
|
||||
#include <QDir>
|
||||
#include <QFile>
|
||||
#include <QGuiApplication>
|
||||
#include <QTemporaryDir>
|
||||
|
||||
#include "ofxCore.h"
|
||||
@@ -34,6 +35,7 @@
|
||||
#include "common/Current.h"
|
||||
#include "node/plugins/Plugin.h"
|
||||
#include "pluginSupport/OliveHost.h"
|
||||
#include "version.h"
|
||||
|
||||
namespace
|
||||
{
|
||||
@@ -202,11 +204,12 @@ TEST(OliveHost, DestroyInstanceIgnoresNull)
|
||||
}
|
||||
|
||||
// ============================================================================
|
||||
// OliveHost message routing (error paths only)
|
||||
// OliveHost message routing
|
||||
//
|
||||
// The successful vmessage/setPersistentMessage paths pop modal QMessageBox
|
||||
// dialogs whenever a QApplication exists, which a headless test cannot
|
||||
// dismiss, so only the early-return failure paths are exercised here.
|
||||
// With a QApplication on a non-offscreen platform the successful
|
||||
// vmessage/setPersistentMessage paths pop modal QMessageBox dialogs, which a
|
||||
// headless test cannot dismiss; on the offscreen platform they log to stderr
|
||||
// instead, so those paths are exercised here behind a platform check.
|
||||
// ============================================================================
|
||||
|
||||
TEST(OliveHost, VMessageRejectsNullArguments)
|
||||
@@ -236,6 +239,44 @@ TEST(OliveHost, SetPersistentMessageRejectsUnknownType)
|
||||
kOfxStatFailed);
|
||||
}
|
||||
|
||||
TEST(OliveHost, VMessageOffscreenLogsInsteadOfDialog)
|
||||
{
|
||||
if (QGuiApplication::platformName() != QLatin1String("offscreen")) {
|
||||
GTEST_SKIP() << "requires the offscreen QPA platform";
|
||||
}
|
||||
|
||||
olive::plugin::OliveHost host;
|
||||
// No modal dialog is shown on the offscreen platform; the message is
|
||||
// logged to stderr and acknowledged.
|
||||
EXPECT_EQ(CallVMessage(host, kOfxMessageError, "id", "%s", "boom"),
|
||||
kOfxStatOK);
|
||||
EXPECT_EQ(CallVMessage(host, kOfxMessageWarning, "id", "%s", "boom"),
|
||||
kOfxStatOK);
|
||||
EXPECT_EQ(CallVMessage(host, kOfxMessageMessage, "id", "%s", "boom"),
|
||||
kOfxStatOK);
|
||||
// A question cannot be answered headlessly, so it is a "no".
|
||||
EXPECT_EQ(CallVMessage(host, kOfxMessageQuestion, "id", "%s", "boom"),
|
||||
kOfxStatReplyNo);
|
||||
}
|
||||
|
||||
TEST(OliveHost, SetPersistentMessageOffscreenSucceeds)
|
||||
{
|
||||
if (QGuiApplication::platformName() != QLatin1String("offscreen")) {
|
||||
GTEST_SKIP() << "requires the offscreen QPA platform";
|
||||
}
|
||||
|
||||
olive::plugin::OliveHost host;
|
||||
EXPECT_EQ(CallSetPersistentMessage(host, kOfxMessageError, "id", "%s",
|
||||
"boom"),
|
||||
kOfxStatOK);
|
||||
EXPECT_EQ(CallSetPersistentMessage(host, kOfxMessageWarning, "id", "%s",
|
||||
"boom"),
|
||||
kOfxStatOK);
|
||||
EXPECT_EQ(CallSetPersistentMessage(host, kOfxMessageMessage, "id", "%s",
|
||||
"boom"),
|
||||
kOfxStatOK);
|
||||
}
|
||||
|
||||
TEST(OliveHost, ClearPersistentMessageSucceeds)
|
||||
{
|
||||
olive::plugin::OliveHost host;
|
||||
@@ -268,6 +309,29 @@ TEST(OliveHost, HostPropertiesIdentifyAsOfxHost)
|
||||
EXPECT_EQ(host.getProperties().getStringProperty(kOfxPropType), "Host");
|
||||
}
|
||||
|
||||
TEST(OliveHost, HostPropertiesIdentifyApplication)
|
||||
{
|
||||
// The ctor stamps the app identity over HostSupport's "UNKNOWN" defaults
|
||||
// so plugins querying the host description see real values.
|
||||
olive::plugin::OliveHost host;
|
||||
const auto &props = host.getProperties();
|
||||
|
||||
EXPECT_EQ(props.getStringProperty(kOfxPropName), "Oak Video Editor");
|
||||
EXPECT_EQ(props.getStringProperty(kOfxPropLabel), "Oak Video Editor");
|
||||
EXPECT_EQ(props.getStringProperty(kOfxPropVersionLabel),
|
||||
olive::kAppVersion.toStdString());
|
||||
|
||||
const QStringList version_parts =
|
||||
olive::kAppVersion.section(QLatin1Char('-'), 0, 0)
|
||||
.split(QLatin1Char('.'));
|
||||
EXPECT_EQ(props.getIntProperty(kOfxPropVersion, 0),
|
||||
version_parts.value(0).toInt());
|
||||
EXPECT_EQ(props.getIntProperty(kOfxPropVersion, 1),
|
||||
version_parts.value(1).toInt());
|
||||
EXPECT_EQ(props.getIntProperty(kOfxPropVersion, 2),
|
||||
version_parts.value(2).toInt());
|
||||
}
|
||||
|
||||
#ifdef OFX_SUPPORTS_OPENGLRENDER
|
||||
TEST(OliveHost, FlushOpenGLResourcesReportsFailure)
|
||||
{
|
||||
|
||||
Reference in New Issue
Block a user